Skip to content

Commit c0088a6

Browse files
Removed wrong -aws from domain and set ttl to 7200 for CODE and PROD
Co-authored-by: Akash <akash1810@users.noreply.github.com>
1 parent 884e265 commit c0088a6

3 files changed

Lines changed: 9 additions & 10 deletions

File tree

cdk/bin/cdk.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,7 @@ export const registrationCodeProps: RegistrationProps = {
5252
{ period: Duration.hours(24), threshold: 1 },
5353
],
5454
cloudFormationStackName: 'mobile-notifications-registration-CODE',
55-
intermediateCname:
56-
'registration.notifications-aws.code.dev-guardianapis.com.',
55+
intermediateCname: 'registration.notifications.code.dev-guardianapis.com.',
5756
intermediateCnameTTLInSeconds: 7200,
5857
};
5958

@@ -71,8 +70,8 @@ export const registrationProdProps: RegistrationProps = {
7170
{ period: Duration.hours(24), threshold: 150_000 },
7271
],
7372
cloudFormationStackName: 'mobile-notifications-registration-PROD',
74-
intermediateCname: 'registration.notifications-aws.guardianapis.com.',
75-
intermediateCnameTTLInSeconds: 3600,
73+
intermediateCname: 'registration.notifications.guardianapis.com.',
74+
intermediateCnameTTLInSeconds: 7200,
7675
};
7776

7877
new Registration(app, 'Registration-CODE', registrationCodeProps);

cdk/lib/__snapshots__/registration.test.ts.snap

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -599,7 +599,7 @@ exports[`The Registration stack matches the snapshot for CODE 1`] = `
599599
"Name": "notifications.code.dev-guardianapis.com",
600600
"RecordType": "CNAME",
601601
"ResourceRecords": [
602-
"registration.notifications-aws.code.dev-guardianapis.com.",
602+
"registration.notifications.code.dev-guardianapis.com.",
603603
],
604604
"Stage": "CODE",
605605
"TTL": 7200,
@@ -2603,10 +2603,10 @@ exports[`The Registration stack matches the snapshot for PROD 1`] = `
26032603
"Name": "notifications.guardianapis.com",
26042604
"RecordType": "CNAME",
26052605
"ResourceRecords": [
2606-
"registration.notifications-aws.guardianapis.com.",
2606+
"registration.notifications.guardianapis.com.",
26072607
],
26082608
"Stage": "PROD",
2609-
"TTL": 3600,
2609+
"TTL": 7200,
26102610
},
26112611
"Type": "Guardian::DNS::RecordSet",
26122612
},

cdk/lib/registration.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,9 @@ export interface RegistrationProps extends GuStackProps {
3030
| 'notifications.code.dev-guardianapis.com';
3131
// This maps to the DnsRecord resource in Route53; we can remove this complexity as part of the DNS switchover
3232
intermediateCname:
33-
| 'registration.notifications-aws.guardianapis.com.'
34-
| 'registration.notifications-aws.code.dev-guardianapis.com.';
35-
intermediateCnameTTLInSeconds: 3600 | 7200;
33+
| 'registration.notifications.guardianapis.com.'
34+
| 'registration.notifications.code.dev-guardianapis.com.';
35+
intermediateCnameTTLInSeconds: 7200;
3636
instanceMetricGranularity: '1Minute' | '5Minute';
3737
minAsgSize: number;
3838
maxAsgSize?: number;

0 commit comments

Comments
 (0)