Remove midnight KO filtering on World Cup matches (#1854)

Author: aracho1

football/src/main/scala/com/gu/mobile/notifications/football/lib/FootballData.scala

@@ -1,6 +1,6 @@
 package com.gu.mobile.notifications.football.lib
 
-import java.time.{LocalDate, ZonedDateTime}
+import java.time.{LocalDate, LocalTime, ZonedDateTime}
 import com.gu.mobile.notifications.football.{Configuration, Logging}
 import com.gu.mobile.notifications.football.models.RawMatchData
 import org.joda.time.DateTime
@@ -124,17 +124,28 @@ class FootballData(
       .getOrElse(false) // Shouldn't ever happen
   }
 
+
+  /**
+   * PA give 00:00 as the start time when they don't actually know the kickoff time yet,
+   * so those matches are unusable and should be filtered out. Competitions in
+   * `competitionsAllowingMidnightKO` are excluded from this check because a 00:00 kickoff can be
+   * genuine for them (e.g. the World Cup, whose schedule spans multiple time zones and is
+   * published months in advance).
+   */
+  private val competitionsAllowingMidnightKO = Set(
+    "700", // FIFA World Cup
+    "701", // FIFA World Cup qualifying
+    "714", // Copa America
+  )
+  private[lib] def isFakeMidnightKO(matchDay: MatchDay): Boolean = {
+    val isAllowlisted = matchDay.competition.exists(c => competitionsAllowingMidnightKO.contains(c.id))
+    !isAllowlisted && matchDay.date.toLocalTime == LocalTime.MIDNIGHT
+  }
+
   def matchIdsInProgress(dateTime: ZonedDateTime): Future[List[MatchDay]] = {
     def inProgress(m: MatchDay): Boolean =
       m.date.minusHours(2).isBefore(dateTime) && m.date.plusHours(4).isAfter(dateTime)
 
-    // unfortunately PA provide 00:00 as start date when they don't have the start date
-    // so we can't do anything with these matches
-    def isMidnight(matchDay: MatchDay): Boolean = {
-      val localDate = matchDay.date.toLocalTime
-      localDate.getHour() == 0 && localDate.getMinute() == 0
-    }
-
     logger.info(s"Retrieving matches on or around $dateTime from PA")
     for {
       matches <- paClient.aroundToday(dateTime)
@@ -154,7 +165,7 @@ class FootballData(
       matchesInSupportedCompetitions
         .filter(inProgress)
         .filter(paProvideAlerts)
-        .filterNot(isMidnight)
+        .filterNot(isFakeMidnightKO)
     }
   }
 

football/src/test/scala/com/gu/mobile/notifications/football/lib/FootballDataSpec.scala

@@ -177,4 +177,24 @@ class FootballDataSpec extends Specification {
       footballData.paProvideAlerts(matchWith("303", roundNumber = "Final")) must beTrue
     }
   }
+
+  "isMidnight" should {
+
+    val footballData = new FootballData(null, null, null, "test")
+
+    "return true for a non-exempt competition kicking off at 00:00" in new FootballDataScope {
+      val m = matchDayWithCompetition("100").copy(date = ZonedDateTime.parse("2026-05-18T00:00:00Z"))
+      footballData.isFakeMidnightKO(m) must beTrue
+    }
+
+    "return false for a non-exempt competition kicking off at a non-midnight time" in new FootballDataScope {
+      val m = matchDayWithCompetition("100").copy(date = ZonedDateTime.parse("2026-05-18T15:00:00Z"))
+      footballData.isFakeMidnightKO(m) must beFalse
+    }
+
+    "return false for the World Cup (700) kicking off at 00:00" in new FootballDataScope {
+      val m = matchDayWithCompetition("700").copy(date = ZonedDateTime.parse("2026-05-18T00:00:00Z"))
+      footballData.isFakeMidnightKO(m) must beFalse
+    }
+  }
 }