Prevent default security groups from accessing registration DB (#1718)

Author: jacobwinch

registration-db.yaml

@@ -20,9 +20,6 @@ Parameters:
   PrivateVpcSubnets:
     Description: Private Subnets to use in VPC
     Type: List<AWS::EC2::Subnet::Id>
-  VPCSecurityGroup:
-    Type: AWS::EC2::SecurityGroup::Id
-    Description: The default security group of the VPC
   MasterUserName:
     Type: String
     Description: The root user name to create in the database
@@ -54,16 +51,6 @@ Resources:
           FromPort: 5432
           IpProtocol: tcp
           ToPort: 5432
-
-        # TODO Remove this rule once all applications are using the PostgresAccessSecurityGroup
-        - SourceSecurityGroupId: !Ref VPCSecurityGroup
-          FromPort: 5432
-          IpProtocol: tcp
-          ToPort: 5432
-        - SourceSecurityGroupId: !ImportValue NotificationsDefaultSecurityGroup-NotificationsMainSecurityGroup
-          FromPort: 5432
-          IpProtocol: tcp
-          ToPort: 5432
       Tags:
         - Key: Stage
           Value: !Ref Stage