Fix broadcast metrics

Author: vlbee

liveactivities/src/main/scala/com/gu/liveactivities/BroadcastLambda.scala

@@ -77,9 +77,11 @@ object BroadcastLambda extends RequestStreamHandler with Lambda with Logging {
     // to ensure the Lambda doesn't fail a healthy request that is just running slow.
     Try(Await.result(broadcastFuture, 160.seconds)) match {
       case Success(msg) => {
+        metrics.increment(Metrics.BroadcastProcessed)
         logger.info(msg) // Broadcast successfully processed or processing is disabled by config msg.
       }
       case Failure(exception) => {
+        metrics.increment(Metrics.BroadcastNotProcessed)
         logger.error(s"Failed to send broadcast ${if(shouldEndBroadcast)"END"} for liveActivityID $matchId: ${exception.getMessage}")
         throw exception
       }

liveactivities/src/main/scala/com/gu/liveactivities/service/BroadcastService.scala

@@ -24,7 +24,7 @@ class BroadcastService(repository: ChannelMappingsRepository, broadcastApiClient
 
       if (broadcastNotAllowed) {
         logger.warn(s"${requestPayload.eventType.asString} event ID $eventId not allowed after ${EndLiveActivityEvent.asString} for match ID $matchId")
-        metrics.increment(Metrics.BroadcastNotProcessed)
+        metrics.increment(Metrics.BroadcastNotAllowed)
         Future.successful(mapping.channelId)
       } else {
         for {

liveactivities/src/main/scala/com/gu/liveactivities/util/Metrics.scala

@@ -46,7 +46,9 @@ object Metrics {
   val ChannelManagerLambdaName = "channel-manager"
   val ChannelCleanUpLambdaName = "channel-cleanup"
 
+  val BroadcastProcessed = "BroadcastProcessed"
   val BroadcastNotProcessed = "BroadcastNotProcessed"
+  val BroadcastNotAllowed = "BroadcastNotAllowed"
   val ChannelNotActive = "ChannelNotActive"
   val DuplicateEvent = "DuplicateEvent"
   val OutOfOrderEvent = "OutOfOrderEvent"