fix(window-title): stop mojibake when setting GW window title to char name

GetPlayerName() fell back to CharContext::player_name, a fixed-size
buffer that isn't always null-terminated yet (e.g. still on the login
screen), and read it unbounded via wcslen — running off into unrelated
memory and rendering as garbled/CJK-looking text. Bound the read and
return empty instead of garbage.

Also send WM_SETTEXT via DefWindowProcW instead of SetWindowTextW when
setting the title on GW's own HWND, since that window may be an ANSI
window class, which would otherwise thunk the string through the
system codepage. Same trick already used for our own windows in
imgui_impl_win32.cpp.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Author: 3vcloud

GWToolboxdll/Modules/GameSettings.cpp

@@ -86,7 +86,11 @@ namespace {
         }
         const std::wstring title = GetPlayerName();
         if (!title.empty()) {
-            SetWindowTextW(hwnd, title.c_str());
+            // Guild Wars' window may be registered as an ANSI (non-Unicode) window class; in that
+            // case SetWindowTextW() gets thunked down to the system codepage before being applied,
+            // corrupting any character outside it. Sending WM_SETTEXT via DefWindowProcW directly
+            // bypasses that thunking, same trick already used for our own windows in imgui_impl_win32.cpp.
+            DefWindowProcW(hwnd, WM_SETTEXT, 0, reinterpret_cast<LPARAM>(title.c_str()));
         }
     }
 

GWToolboxdll/Utils/ToolboxUtils.cpp

@@ -1004,9 +1004,18 @@ namespace ToolboxUtils {
         if (!player_number) {
             player = GW::PlayerMgr::GetPlayerByID(GW::PlayerMgr::GetPlayerNumber());
             if (!player || !player->name) {
-                // Map not loaded; try to get from character context
+                // Map not loaded; try to get from character context.
+                // player_name is a fixed-size buffer that may not be populated/null-terminated
+                // yet (e.g. still on the login/char select screen); reading it unbounded via
+                // wcslen can run off into unrelated memory and produce garbled (often CJK-looking)
+                // output. Bail out to an empty string instead so callers retry later.
                 const auto c = GW::GetCharContext();
-                return c ? c->player_name : L"";
+                if (!c) {
+                    return L"";
+                }
+                constexpr size_t max_len = sizeof(c->player_name) / sizeof(c->player_name[0]);
+                const size_t len = wcsnlen(c->player_name, max_len);
+                return len < max_len ? std::wstring(c->player_name, len) : L"";
             }
         }
         else {