Merge pull request #857 from hadashiA/ku/fix-incremental-generation

Make incremental generator skip unchanged output

Author: hadashiA

VContainer.SourceGenerator.Roslyn3/VContainer.SourceGenerator.Roslyn3.csproj

@@ -4,7 +4,7 @@
         <RootNamespace>VContaienr.SourceGenerator</RootNamespace>
         <AnalyzerLanguage>cs</AnalyzerLanguage>
         <IncludeBuildOutput>false</IncludeBuildOutput>
-        <LangVersion>11</LangVersion>
+        <LangVersion>12</LangVersion>
         <Nullable>enable</Nullable>
         <SuppressDependenciesWhenPacking>true</SuppressDependenciesWhenPacking>
         <DevelopmentDependency>true</DevelopmentDependency>

VContainer.SourceGenerator.Roslyn3/VContainerSourceGenerator.cs

@@ -56,13 +56,19 @@ public void Execute(GeneratorExecutionContext context)
 
     static void Execute(TypeMeta typeMeta, CodeWriter codeWriter, ReferenceSymbols referenceSymbols, in GeneratorExecutionContext context)
     {
-        if (Emitter.TryEmitGeneratedInjector(typeMeta, codeWriter, referenceSymbols, in context))
+        var diagnostics = new System.Collections.Generic.List<DiagnosticInfo>();
+        var model = InjectorModelBuilder.Build(typeMeta, referenceSymbols);
+        if (Emitter.TryEmitGeneratedInjector(model, codeWriter, diagnostics))
         {
             var fullType = typeMeta.FullTypeName
                 .Replace("global::", "")
                 .Replace("<", "_")
                 .Replace(">", "_");
             context.AddSource($"{fullType}GeneratedInjector.g.cs", codeWriter.ToString());
         }
+        foreach (var diagnostic in diagnostics)
+        {
+            context.ReportDiagnostic(diagnostic.ToDiagnostic());
+        }
     }
 }

VContainer.SourceGenerator/Analyzer.cs

@@ -89,7 +89,7 @@ public static bool IsRegisterSyntaxCandidate(SyntaxNode syntax)
     }
 }
 
-record struct TypeDeclarationCandidate(TypeDeclarationSyntax Syntax, SemanticModel SemanticModel)
+readonly record struct TypeDeclarationCandidate(TypeDeclarationSyntax Syntax, SemanticModel SemanticModel)
 {
     public TypeMeta? Analyze(ReferenceSymbols referenceSymbols, CancellationToken cancellation = default)
     {
@@ -100,7 +100,7 @@ record struct TypeDeclarationCandidate(TypeDeclarationSyntax Syntax, SemanticMod
     }
 }
 
-record struct RegisterInvocationCandidate(InvocationExpressionSyntax Syntax, SemanticModel SemanticModel)
+readonly record struct RegisterInvocationCandidate(InvocationExpressionSyntax Syntax, SemanticModel SemanticModel)
 {
     public IEnumerable<TypeMeta> Analyze(ReferenceSymbols referenceSymbols, CancellationToken cancellation = default)
     {