Decktape error on PDF export

[sbucking-prog]

New error introduced in v6:

Decktape crashes on the first slide transition with:

Error [TypeError]: Cannot read properties of null (reading 'removeChild')
    at clearMediaPlaybackErrors (reveal.js/dist/reveal.js:7:15718)
    at afterSlideChanged (reveal.js/dist/reveal.js:7:15985)

clearMediaPlaybackErrors() is called on every slide change via afterSlideChanged()

clearMediaPlaybackErrors() {
    this.resetTemporarilyMutedMedia();
    this.failedAudioPlaybackTargets.clear();
    this.failedVideoPlaybackTargets.clear();
    this.failedMutedVideoPlaybackTargets.clear();
    this.mediaPlayButton.remove();   // ← crashes in decktape: parentNode is null (if no video/media)
}

Minimal fix:

js/controllers/slidecontent.js (line 707):

// Before
this.mediaPlayButton.remove();

// After
if( this.mediaPlayButton && this.mediaPlayButton.parentNode ) this.mediaPlayButton.remove();

[SingggggYee]

Ran into the same thing on v6 with decktape. Your minimal fix in slidecontent.js is exactly right — the parentNode check should probably land upstream.

In the meantime, if anyone else needs a working export while this sits: decktape still works on older reveal versions, and html2pdf-slides (https://github.com/SingggggYee/html2pdf-slides) is another option that walks the deck via the Reveal API instead of hooking into slide change events, so it sidesteps this particular crash. Neither is a replacement for fixing the root cause, but they'll unblock you.

For the actual bug — this.mediaPlayButton.remove() unconditionally calling parentNode.removeChild is the issue. The conditional you proposed (if (this.mediaPlayButton && this.mediaPlayButton.parentNode)) is the standard pattern for this. Worth opening a PR.

[hakimel]

Fixed by be6d7f8

Thanks for reporting!