Commit 65692fd
Forbid the British spellings fixed in recent PRs (mdn#45358)
* Forbid the British spellings fixed in recent PRs
Adds the 29 British spellings corrected in mdn#44920, mdn#45333, mdn#45334,
mdn#45340, mdn#45341, mdn#45346 and mdn#45355 to the forbidden-spelling dictionary,
so `npm run lint:typos` fails on them instead of letting them back in.
Both spellings are valid dictionary words, so nothing could catch a
regression until now.
Enforcing the list surfaced 32 occurrences that earlier passes missed:
seven of "labelled" in prose in the WCAG and ARIA guides, and
twenty-five in code comments and log strings that earlier passes had
left alone as code. The comments and strings are prose and read the
same either way, so they are corrected rather than exempted.
Ten files keep a British spelling and carry a per-file `cSpell:ignore`
comment, because changing the text would change its meaning:
- Code identifiers: `const cancelled` on the DOM events page and
`const maths` in the MathML tutorial.
- The verbatim Firefox error strings on "functions cannot be labelled".
- The `menu-labelled-open` example extension name, and the `colour`
keys in the WebExtensions storage and i18n examples, which mirror the
`favourite-colour` example repository and the en_GB message that
example returns.
- The note on the listbox role page stating that "labelled", with two
L's, is the correct spelling per accessibility API conventions.
- The "Million tonne punch" sample data, which is shared with the
learning-area repository.
- The screen reader transcript on the <math> element page.
`grey` is deliberately left out. It is a valid CSS named color and
appears legitimately 167 times, in `<named-color>`, the
`tabGroups.color` enum, and SVG and CSS samples, so forbidding it would
need an ignore comment on roughly fifty files that use the keyword
correctly.
* Add more
* Add a comment
* Minor fix
---------
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>1 parent cf880ca commit 65692fd
45 files changed
Lines changed: 106 additions & 41 deletions
File tree
- .vscode
- dictionaries
- files/en-us
- learn_web_development/core
- accessibility/wai-aria_basics
- scripting/json
- mozilla/add-ons/webextensions
- api
- omnibox/oninputcancelled
- storage/managed
- internationalization
- web
- accessibility
- aria
- guides/multipart_labels
- reference/roles
- listbox_role
- radio_role
- tablist_role
- treegrid_role
- guides/understanding_wcag
- operable
- perceivable
- text_labels_and_names
- api
- abortsignal/any_static
- credentialscontainer/get
- document_object_model/events
- element/pointercancel_event
- file_system_api
- filesystemdirectoryhandle
- resolve
- html_drag_and_drop_api/drag_operations
- htmldialogelement
- cancel_event
- requestclose
- htmlelement/command_event
- keyboardevent/keycode
- languagemodel/prompt
- payment_request_api/using_the_payment_request_api
- readablestream/cancel
- remoteplayback/prompt
- streams_api/using_readable_byte_streams
- tasksignal/any_static
- uievent/inituievent
- html/reference/elements
- input/file
- progress
- javascript/reference
- errors/function_label
- global_objects/promise/all
- statements/label
- mathml
- reference/element/math
- tutorials/for_beginners/scripts
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
146 | 146 | | |
147 | 147 | | |
148 | 148 | | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
149 | 152 | | |
150 | 153 | | |
151 | 154 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
169 | 169 | | |
170 | 170 | | |
171 | 171 | | |
| 172 | + | |
172 | 173 | | |
173 | 174 | | |
174 | 175 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
1 | 2 | | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
64 | | - | |
| 64 | + | |
| 65 | + | |
65 | 66 | | |
66 | 67 | | |
67 | 68 | | |
| |||
594 | 595 | | |
595 | 596 | | |
596 | 597 | | |
| 598 | + | |
597 | 599 | | |
598 | 600 | | |
599 | 601 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
838 | 838 | | |
839 | 839 | | |
840 | 840 | | |
841 | | - | |
| 841 | + | |
842 | 842 | | |
843 | 843 | | |
844 | 844 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
| 52 | + | |
| 53 | + | |
52 | 54 | | |
53 | 55 | | |
54 | 56 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
| 16 | + | |
15 | 17 | | |
16 | 18 | | |
17 | 19 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
| 36 | + | |
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
| 20 | + | |
19 | 21 | | |
20 | 22 | | |
21 | 23 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
| 9 | + | |
8 | 10 | | |
9 | 11 | | |
10 | 12 | | |
| |||
0 commit comments