adjusted optional parameter

Author: pdiffley

packages/collab-client/src/index.ts

@@ -15,7 +15,7 @@ export { collab, collabKey } from "./plugin";
 export interface CommitsListener {
   listen: (
     editorState: EditorState,
-    options?: { signal?: AbortSignal },
+    options?: { signal?: AbortSignal | undefined },
   ) => AsyncIterableIterator<Commit[]>;
 }
 
@@ -63,8 +63,9 @@ export class CollabClient {
   }
 
   async listen(editorState: EditorState, signal?: AbortSignal) {
-    let options = signal ? { signal } : {};
-    for await (const newCommits of this.listener.listen(editorState, options)) {
+    for await (const newCommits of this.listener.listen(editorState, {
+      signal,
+    })) {
       if (signal && signal.aborted) break;
       this.receiveCommits(newCommits);
     }
@@ -93,7 +94,7 @@ export class LongPollListener {
     this.headers = headers;
   }
 
-  async *listen(editorState: EditorState, options: { signal?: AbortSignal } = {}) {
+  async *listen(editorState: EditorState, options: { signal?: AbortSignal | undefined } = {}) {
     const seen = new Set<string>();
     let version = getVersion(editorState);
     if (version === undefined) {

packages/presence-client/src/index.ts

@@ -13,7 +13,7 @@ export { type PresenceIndicator, type PresenceClientConfig };
 export interface IndicatorListener {
   listen: (
     clientId: string,
-    options?: { signal?: AbortSignal },
+    options?: { signal?: AbortSignal | undefined },
   ) => AsyncIterableIterator<Record<string, PresenceIndicator>>;
 }
 
@@ -77,8 +77,9 @@ export class PresenceClient {
   }
 
   async listen(signal?: AbortSignal) {
-    const options = signal ? { signal } : {};
-    for await (const indicators of this.listener.listen(this.clientId, options)) {
+    for await (const indicators of this.listener.listen(this.clientId, {
+      signal,
+    })) {
       if (signal && signal.aborted) break;
       this.receiveIndicators(indicators);
     }
@@ -107,7 +108,7 @@ export class LongPollListener {
     this.headers = headers;
   }
 
-  async *listen(clientId: string, options: { signal?: AbortSignal } = {}) {
+  async *listen(clientId: string, options: { signal?: AbortSignal | undefined } = {}) {
     let refs: Record<string, string> = {};
 
     while (!options?.signal || !options.signal.aborted) {