Skip to content

Commit 1512a5e

Browse files
committed
Reconcile benchmark readiness checklist
1 parent 61184d6 commit 1512a5e

5 files changed

Lines changed: 51 additions & 30 deletions

File tree

mlperf-edu/DATASET_RELEASE_REVIEW.md

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,10 +67,12 @@ and evaluator without project choices.
6767

6868
## Reviewer Checklist
6969

70-
- [ ] Every active dataset has an authoritative upstream source.
71-
- [ ] Every revision, file, and split is pinned and verified.
70+
- [x] Every active dataset has an authoritative upstream source.
71+
- [x] Every revision, file, and split is pinned and verified, or is generated
72+
by the pinned run contract.
7273
- [ ] License and attribution text is accurate.
73-
- [ ] Fetch-only and redistribution rules are explicit.
74-
- [ ] Generated reports disclose data mode and asset hashes.
75-
- [ ] Package tests reject restricted bytes.
76-
- [ ] No removed workload dataset remains on the public benchmark site.
74+
- [x] Fetch-only and redistribution rules are explicit and conservative while
75+
external decisions remain open.
76+
- [x] Generated reports disclose data mode and asset hashes.
77+
- [x] Package tests reject restricted bytes.
78+
- [x] No removed workload dataset remains on the public benchmark site.

mlperf-edu/INDEPENDENT_AUDIT.md

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -110,12 +110,13 @@ highest-risk findings were valid and are now enforced in code and tests.
110110
evidence trees or unambiguous source artifacts. All five labs are rendered in
111111
the website navigation.
112112

113-
The repeated review supports a supervised pilot for Labs 01, 02, 04, and 05.
114-
Lab 03 is explicitly a take-home accelerator exercise until the product can
115-
bind a precomputed instructor baseline into a candidate-only plan. Automated
116-
allowed-plan-diff grading and measured course-image resource budgets also remain
117-
open. These are product-readiness limits, not reasons to change the fourteen
118-
benchmark identities or lower their quality targets.
113+
The repeated review now supports a supervised pilot for all five labs. Lab 03
114+
can bind a provenance-verified instructor baseline into a candidate-only plan,
115+
and the CLI enforces allowed plan edits against the instructor reference.
116+
Measured functional CPU and accelerator-requested resource budgets are
117+
published for the first course system. Authoritative max budgets on each
118+
selected course image remain open. This limit is not a reason to change the
119+
fourteen benchmark identities or lower their quality targets.
119120

120121
## Primary Sources
121122

mlperf-edu/PRODUCT_READINESS_PLAN.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,11 @@ research-environment workloads.
150150
### Production release
151151

152152
- [ ] Close component license, naming, and governance decisions.
153-
- [ ] Harden generated-code execution and untrusted pickle handling.
153+
- [x] Harden generated-code execution and verify trusted upstream pickle bytes
154+
immediately before loading them in the controlled preview.
155+
- [ ] Replace executable EDM pickle inputs, qualify signed legacy runtime
156+
images, and close the remaining production controls in
157+
[SECURITY_REVIEW.md](SECURITY_REVIEW.md).
154158
- [ ] Sign release artifacts and provenance where producer identity matters.
155159
- [ ] Reproduce on independent CPU, Apple Silicon, and CUDA systems.
156160
- [ ] Run the later stability campaign and promote compatible baselines.

mlperf-edu/QUALITY_TARGET_REVIEW.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ number means.
4747

4848
This distinction is important for the four current near-misses. PatchTST,
4949
HumanEval+, BFCL, and EDM remain below strict published-reference points. Their
50-
results do not justify lowering the gates. The causal-language-modeling point,
51-
graph tolerance, and causal-language-modeling interpretation remain conditional
50+
results do not justify lowering the gates. The graph tolerance and the
51+
causal-language-modeling reproduction-point interpretation remain conditional
5252
until independently approved. The BFCL data, leaderboard result, and evaluator
5353
are now pinned to immutable revisions.
5454

mlperf-edu/WORK_CHECKLIST.md

Lines changed: 29 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -56,20 +56,30 @@ promotion, and production publication are separate later phases.
5656
These items refine or approve quality interpretation. They do not justify
5757
lowering a target to fit one local result.
5858

59-
- [ ] Investigate the PatchTST result of 0.292393 MSE against the unchanged
60-
target of at most 0.290.
61-
- [ ] Investigate the HumanEval+ result of 91 passing tasks against the
62-
unchanged requirement of at least 94 of 164.
63-
- [ ] Analyze the BFCL category gaps behind the 0.785208 result against the
64-
unchanged 0.8292 target.
65-
- [ ] Review the EDM sampler and numerical path behind the 1.801554 minimum FID
66-
against the unchanged target of at most 1.79.
59+
- [x] Investigate the PatchTST result. Two exact Apple Silicon reproductions
60+
reached 0.29168 and 0.29239 MSE. Neither met the unchanged 0.290 point, and
61+
no post-result tolerance was introduced.
62+
- [x] Investigate the HumanEval+ result. Attention, dtype, Transformers, Qwen
63+
evaluator, and EvalPlus variants were cross-checked. The authoritative run
64+
still passed 91 of 164 tasks against the unchanged 94-task requirement.
65+
- [x] Analyze the BFCL category gaps. Java and JavaScript account for the
66+
largest deficits, while Python, multiple, and parallel-multiple meet or
67+
exceed the corresponding published category scores. The aggregate remains
68+
0.785208 against the unchanged 0.8292 target.
69+
- [x] Review the EDM sampler and numerical path. Three complete 50,000-image
70+
trials were independently rehashed and rescored, the official 18-step and
71+
35-evaluation schedule was preserved, and the evaluator cross-check differed
72+
by only 2.53e-8 FID. The best result remains 1.801554 against 1.79.
6773
- [ ] Obtain domain approval for the one-sided OGB GCN target interpretation.
6874
- [ ] Obtain independent approval for the nanoGPT target interpretation.
69-
- [ ] Resolve the keyword-spotting adapter's quality-preserving but nonidentical
70-
promotion boundary.
71-
- [ ] Close dataset redistribution and fetch-only wording before public
72-
release.
75+
- [x] Resolve the keyword-spotting adapter boundary. Retain it as a disclosed,
76+
quality-preserving educational adaptation and block promotion until an
77+
exact-source execution path or authoritative unquantized weights establish
78+
parity.
79+
- [x] Use conservative fetch-only wording and reject restricted dataset bytes
80+
from portable packages while decisions remain open.
81+
- [ ] Close the remaining external dataset redistribution and component-terms
82+
decisions before public release.
7383

7484
## Classroom and Research Follow-Up
7585

@@ -86,7 +96,9 @@ lowering a target to fit one local result.
8696
evidence for research interpretation.
8797
- [ ] Perform an explicitly requested interactive review of a standalone run
8898
dashboard. Layout automation already passes and no browser should open as a
89-
side effect of routine verification.
99+
side effect of routine verification. The July 18 attempt stopped without
100+
opening anything because the in-app browser runtime reported no available
101+
browser.
90102

91103
## Stability and Promotion
92104

@@ -103,8 +115,10 @@ Production publication is not required for the initial classroom and research
103115
preview.
104116

105117
- [ ] Close component licensing, package naming, versioning, and governance.
106-
- [ ] Complete security review of generated-code execution, untrusted pickle
107-
handling, and legacy container paths.
118+
- [x] Harden and document the controlled-preview generated-code and pinned
119+
pickle paths in [SECURITY_REVIEW.md](SECURITY_REVIEW.md).
120+
- [ ] Replace executable EDM pickle inputs with safe reviewed artifacts and
121+
qualify independently built, signed DLRM and MiniGo runtime images.
108122
- [ ] Close MLCommons review of the project name, scope, and result wording.
109123
- [ ] Sign release artifacts and authenticate provenance where producer
110124
identity matters.

0 commit comments

Comments
 (0)