Merge pull request #1971 from Shashank-Tripathi-07/fix/tito-subprocess-encoding-crash

fix(tinytorch): tito crashes on Windows when a subprocess's output can't be decoded as cp1252

Author: profvjreddi

tinytorch/tito/commands/dev/preflight.py

@@ -246,7 +246,7 @@ def _run_command(self, cmd: List[str], cwd: Path, timeout: int = 60, verbose: bo
                 cmd,
                 cwd=cwd,
                 capture_output=True,
-                text=True,
+                text=True, encoding="utf-8", errors="replace",
                 timeout=timeout
             )
 

tinytorch/tito/commands/dev/test.py

@@ -352,6 +352,8 @@ def _build_package(self, project_root: Path, verbose: bool, ci_mode: bool = Fals
                     stdout=subprocess.PIPE,
                     stderr=subprocess.STDOUT,
                     text=True,
+                    encoding="utf-8",
+                    errors="replace",
                     bufsize=1
                 )
 
@@ -370,6 +372,8 @@ def _build_package(self, project_root: Path, verbose: bool, ci_mode: bool = Fals
                     cwd=project_root,
                     capture_output=True,
                     text=True,
+                    encoding="utf-8",
+                    errors="replace",
                     timeout=600  # 10 minutes for full build
                 )
                 returncode = result.returncode
@@ -464,6 +468,8 @@ def _run_pytest(self, project_root: Path, test_path: str, name: str,
                     stdout=subprocess.PIPE,
                     stderr=subprocess.STDOUT,
                     text=True,
+                    encoding="utf-8",
+                    errors="replace",
                     bufsize=1
                 )
 
@@ -551,6 +557,8 @@ def _run_pytest(self, project_root: Path, test_path: str, name: str,
                     env=env,
                     capture_output=True,
                     text=True,
+                    encoding="utf-8",
+                    errors="replace",
                     timeout=timeout
                 )
 
@@ -658,6 +666,8 @@ def _run_inline_tests(self, project_root: Path, module: Optional[str],
                      "dev", "export", module_num],
                     capture_output=True,
                     text=True,
+                    encoding="utf-8",
+                    errors="replace",
                     cwd=project_root,
                     timeout=120  # 2 min for export
                 )
@@ -690,6 +700,8 @@ def _run_inline_tests(self, project_root: Path, module: Optional[str],
                      "module", "complete", module_num],
                     capture_output=True,
                     text=True,
+                    encoding="utf-8",
+                    errors="replace",
                     cwd=project_root,
                     timeout=300  # 5 min per module
                 )
@@ -917,6 +929,8 @@ def _run_user_journey(self, project_root: Path, args: Namespace) -> TestResult:
                      "module", "start", module_num, "--no-jupyter"],
                     capture_output=True,
                     text=True,
+                    encoding="utf-8",
+                    errors="replace",
                     cwd=project_root,
                     timeout=120
                 )
@@ -951,6 +965,8 @@ def _run_user_journey(self, project_root: Path, args: Namespace) -> TestResult:
                      "module", "complete", module_num],
                     capture_output=True,
                     text=True,
+                    encoding="utf-8",
+                    errors="replace",
                     cwd=project_root,
                     timeout=300
                 )
@@ -1007,6 +1023,8 @@ def _run_user_journey(self, project_root: Path, args: Namespace) -> TestResult:
                              "milestone", "run", milestone_id, "--skip-checks"],
                             capture_output=True,
                             text=True,
+                            encoding="utf-8",
+                            errors="replace",
                             cwd=project_root,
                             timeout=300  # 5 min for heavy milestones (CNN, Transformer)
                         )

tinytorch/tito/commands/export_utils.py

@@ -161,7 +161,7 @@ def convert_py_to_notebook(module_path: Path, venv_path: Path, console) -> bool:
         venv_jupytext = get_venv_bin_dir(venv_path) / "jupytext"
 
         if venv_jupytext.exists():
-            test_result = subprocess.run([str(venv_jupytext), "--version"], capture_output=True, text=True)
+            test_result = subprocess.run([str(venv_jupytext), "--version"], capture_output=True, text=True, encoding="utf-8", errors="replace")
             if test_result.returncode == 0:
                 jupytext_path = str(venv_jupytext)
                 console.print(f"[dim]🔧 Using venv jupytext: {venv_jupytext}[/dim]")
@@ -175,7 +175,7 @@ def convert_py_to_notebook(module_path: Path, venv_path: Path, console) -> bool:
         result = subprocess.run(
             [jupytext_path, "--to", "ipynb", str(dev_file), "--output", str(notebook_file)],
             capture_output=True,
-            text=True,
+            text=True, encoding="utf-8", errors="replace",
             cwd=project_root,
         )
 

tinytorch/tito/commands/milestone.py

@@ -1005,7 +1005,7 @@ def _handle_demo_command(self, args: Namespace) -> int:
             result = subprocess.run(
                 [sys.executable, str(demo_path)],
                 capture_output=False,
-                text=True
+                text=True, encoding="utf-8", errors="replace"
             )
 
             if result.returncode == 0:
@@ -1302,7 +1302,7 @@ def _handle_run_command(self, args: Namespace) -> int:
                 result = subprocess.run(
                     [sys.executable, script_file],
                     capture_output=False,
-                    text=True
+                    text=True, encoding="utf-8", errors="replace"
                 )
 
                 console.print("\n" + "━" * 80)

tinytorch/tito/commands/module/test.py

@@ -109,6 +109,8 @@ def run_inline_tests(
                 [sys.executable, str(module_file)],
                 capture_output=True,
                 text=True,
+                encoding="utf-8",
+                errors="replace",
                 cwd=self.config.project_root,
                 timeout=300,
             )
@@ -161,6 +163,8 @@ def run_module_pytest(
                 cmd,
                 capture_output=True,
                 text=True,
+                encoding="utf-8",
+                errors="replace",
                 cwd=self.config.project_root,
                 timeout=300,
             )
@@ -263,6 +267,8 @@ def run_integration_tests(
                 cmd,
                 capture_output=True,
                 text=True,
+                encoding="utf-8",
+                errors="replace",
                 cwd=self.config.project_root,
                 timeout=600,  # 10 minute timeout for integration tests
             )

tinytorch/tito/commands/module/workflow.py

@@ -536,7 +536,9 @@ def _open_jupyter(self, module_name: str) -> int:
                 cwd=str(module_dir),
                 stdout=subprocess.PIPE,
                 stderr=subprocess.PIPE,
-                text=True
+                text=True,
+                encoding="utf-8",
+                errors="replace"
             )
 
             # Give Jupyter a moment to start and capture the URL

tinytorch/tito/commands/nbgrader.py

@@ -768,7 +768,7 @@ def _run_external(self, cmd: List[str], *, capture_output: bool = False) -> subp
                 cwd=self.project_root,
                 check=False,
                 capture_output=capture_output,
-                text=True,
+                text=True, encoding="utf-8", errors="replace",
             )
         except FileNotFoundError as exc:
             return subprocess.CompletedProcess(cmd, 127, "", str(exc))

tinytorch/tito/commands/setup.py

@@ -120,7 +120,7 @@ def _check_package_installed(self, package_name: str) -> bool:
         try:
             result = subprocess.run(
                 [sys.executable, "-m", "pip", "show", package_name],
-                capture_output=True, text=True, timeout=10
+                capture_output=True, text=True, encoding="utf-8", errors="replace", timeout=10
             )
             return result.returncode == 0
         except Exception:
@@ -178,7 +178,7 @@ def install_packages(self) -> bool:
                     try:
                         result = subprocess.run([
                             sys.executable, "-m", "pip", "install", "-q", pkg_spec
-                        ], capture_output=True, text=True, timeout=120)
+                        ], capture_output=True, text=True, encoding="utf-8", errors="replace", timeout=120)
 
                         if result.returncode == 0:
                             progress.update(task, description=f"[green]✅ {pkg_name}[/green]")
@@ -215,7 +215,7 @@ def install_packages(self) -> bool:
                 try:
                     result = subprocess.run([
                         sys.executable, "-m", "pip", "install", "-q", "-e", "."
-                    ], cwd=self.config.project_root, capture_output=True, text=True, timeout=120)
+                    ], cwd=self.config.project_root, capture_output=True, text=True, encoding="utf-8", errors="replace", timeout=120)
 
                     if result.returncode == 0:
                         progress.update(task, description="[green]✅ Tiny🔥Torch installed[/green]")
@@ -238,7 +238,7 @@ def install_packages(self) -> bool:
                 "--user",
                 "--name", "tinytorch",
                 "--display-name", "TinyTorch (Python 3)"
-            ], capture_output=True, text=True, timeout=60)
+            ], capture_output=True, text=True, encoding="utf-8", errors="replace", timeout=60)
 
             if result.returncode == 0:
                 self.console.print("[green]✅ Jupyter kernel 'tinytorch' registered[/green]")
@@ -304,7 +304,7 @@ def create_virtual_environment(self, force: bool = False) -> bool:
                     # Check actual hardware
                     hw_check = sp.run(
                         ["sysctl", "-n", "machdep.cpu.brand_string"],
-                        capture_output=True, text=True
+                        capture_output=True, text=True, encoding="utf-8", errors="replace"
                     )
                     if "Apple" in hw_check.stdout:
                         self.console.print("[yellow]⚠️  Detected Apple Silicon but Python is running in Rosetta (x86_64)[/yellow]")
@@ -319,12 +319,12 @@ def create_virtual_environment(self, force: bool = False) -> bool:
                 result = subprocess.run(
                     f'{python_exe} -m venv {venv_path}',
                     shell=True,
-                    capture_output=True, text=True
+                    capture_output=True, text=True, encoding="utf-8", errors="replace"
                 )
             else:
                 result = subprocess.run([
                     python_exe, "-m", "venv", str(venv_path)
-                ], capture_output=True, text=True)
+                ], capture_output=True, text=True, encoding="utf-8", errors="replace")
 
             if result.returncode != 0:
                 self.console.print(f"[red]Failed to create virtual environment: {result.stderr}[/red]")
@@ -339,7 +339,7 @@ def create_virtual_environment(self, force: bool = False) -> bool:
             if venv_python.exists():
                 arch_check = subprocess.run(
                     [str(venv_python), "-c", "import platform; print(platform.machine())"],
-                    capture_output=True, text=True
+                    capture_output=True, text=True, encoding="utf-8", errors="replace"
                 )
                 if arch_check.returncode == 0:
                     venv_arch = arch_check.stdout.strip()
@@ -476,7 +476,7 @@ def check_jupyter_kernel(self) -> bool:
         try:
             result = subprocess.run(
                 [sys.executable, "-m", "jupyter", "kernelspec", "list"],
-                capture_output=True, text=True, timeout=10
+                capture_output=True, text=True, encoding="utf-8", errors="replace", timeout=10
             )
             return result.returncode == 0 and "tinytorch" in result.stdout
         except Exception:

tinytorch/tito/commands/system/health.py

@@ -257,7 +257,7 @@ def _check_jupyter_kernel(self):
         try:
             result = subprocess.run(
                 [sys.executable, "-m", "jupyter", "kernelspec", "list"],
-                capture_output=True, text=True, timeout=10
+                capture_output=True, text=True, encoding="utf-8", errors="replace", timeout=10
             )
             if result.returncode == 0 and "tinytorch" in result.stdout:
                 return "[green]✅ Registered[/green]", "tinytorch kernel found"
@@ -283,7 +283,7 @@ def _get_kernel_python(self):
             for kernel_name in ("tinytorch", "python3"):
                 result = subprocess.run(
                     [sys.executable, "-m", "jupyter", "kernelspec", "list", "--json"],
-                    capture_output=True, text=True, timeout=10
+                    capture_output=True, text=True, encoding="utf-8", errors="replace", timeout=10
                 )
                 if result.returncode != 0:
                     return None

tinytorch/tito/commands/system/update.py

@@ -104,7 +104,7 @@ def _get_latest_version(self) -> Tuple[Optional[str], Optional[str]]:
             result = subprocess.run(
                 ['curl', '-fsSL', '--max-time', '10', self.TAGS_API],
                 capture_output=True,
-                text=True
+                text=True, encoding="utf-8", errors="replace"
             )
 
             if result.returncode != 0:
@@ -203,7 +203,7 @@ def _download_latest(self, temp_dir: Path) -> bool:
                     str(repo_dir)
                 ],
                 capture_output=True,
-                text=True
+                text=True, encoding="utf-8", errors="replace"
             )
 
             if result.returncode != 0:
@@ -215,7 +215,7 @@ def _download_latest(self, temp_dir: Path) -> bool:
             result = subprocess.run(
                 ['git', 'sparse-checkout', 'set', self.SPARSE_PATH],
                 capture_output=True,
-                text=True,
+                text=True, encoding="utf-8", errors="replace",
                 cwd=repo_dir
             )