feat(staffml): complete feedback pipeline with tests and CI

Fix the feedback data round-trip end-to-end:
- QuestionFeedback: dedup guard, aria-pressed, hydrate previous
  feedback on mount, wire Report/Suggest to analytics events
- analytics.ts: computeSummary() aggregates thumbs and difficulty
  with last-write-wins dedup per question+session
- dashboard: new thumbs ratio and difficulty distribution panels
- gauntlet: add QuestionFeedback to per-question review
- progress.ts: include analytics in export/import
- worker.js: server-side summary aggregates feedback with dedup

Add Vitest test infrastructure (34 journey tests across 2 files)
and embed type-check + test steps in both CI deploy workflows
so tests gate every build before deployment.

Author: profvjreddi

.github/workflows/staffml-preview-dev.yml

@@ -62,6 +62,14 @@ jobs:
         working-directory: interviews/staffml
         run: npm ci
 
+      - name: 🔍 Type check
+        working-directory: interviews/staffml
+        run: npx tsc --noEmit
+
+      - name: 🧪 Run tests
+        working-directory: interviews/staffml
+        run: npm test
+
       - name: 🔨 Build StaffML
         working-directory: interviews/staffml
         env:

.github/workflows/staffml-publish-live.yml

@@ -58,6 +58,14 @@ jobs:
         working-directory: interviews/staffml
         run: npm ci
 
+      - name: 🔍 Type check
+        working-directory: interviews/staffml
+        run: npx tsc --noEmit
+
+      - name: 🧪 Run tests
+        working-directory: interviews/staffml
+        run: npm test
+
       - name: 🔄 Sync vault data to StaffML
         run: python3 interviews/staffml/scripts/sync-vault.py
 

interviews/staffml/analytics-worker/worker.js

@@ -180,7 +180,11 @@ async function handleSummary(env, corsHeaders) {
     let questionsScored = 0;
     let gauntletsCompleted = 0;
     let questionsReported = 0;
+    let improvementsSuggested = 0;
     const scoresByLevel = {};
+    // Dedup feedback: last-write-wins per (questionId, sessionId)
+    const latestThumbs = new Map();
+    const latestDifficulty = new Map();
 
     for (const event of recentEvents) {
       if (event._sid) sessions.add(event._sid);
@@ -200,9 +204,32 @@ async function handleSummary(env, corsHeaders) {
         case 'question_reported':
           questionsReported++;
           break;
+        case 'improvement_suggested':
+          improvementsSuggested++;
+          break;
+        case 'question_thumbs':
+          if (event.questionId && event._sid) {
+            latestThumbs.set(`${event.questionId}:${event._sid}`, event.value);
+          }
+          break;
+        case 'question_difficulty_feedback':
+          if (event.questionId && event._sid) {
+            latestDifficulty.set(`${event.questionId}:${event._sid}`, event.perceived);
+          }
+          break;
       }
     }
 
+    // Aggregate deduplicated feedback
+    let thumbsUp = 0, thumbsDown = 0;
+    for (const v of latestThumbs.values()) {
+      if (v === 'up') thumbsUp++; else thumbsDown++;
+    }
+    const difficultyDistribution = { too_easy: 0, about_right: 0, too_hard: 0 };
+    for (const v of latestDifficulty.values()) {
+      if (difficultyDistribution[v] !== undefined) difficultyDistribution[v]++;
+    }
+
     // Compute averages
     for (const v of Object.values(scoresByLevel)) {
       v.avg = v.count > 0 ? (v.total / v.count).toFixed(2) : 0;
@@ -215,6 +242,10 @@ async function handleSummary(env, corsHeaders) {
         questionsScored,
         gauntletsCompleted,
         questionsReported,
+        improvementsSuggested,
+        thumbsUp,
+        thumbsDown,
+        difficultyDistribution,
         eventsByDay,
         scoresByLevel,
       },