tinytorch module 09 diagrams and spacing - #1917
Conversation
|
Thanks for the focused diagram pass, @vedant-a-joshi — the alignment and neatness are genuinely welcome. I'm holding it for one more round rather than merging, because a few things would regress module 09 as-is:
Two that are genuinely your call, not bugs — just confirm they were intentional: switching the intro example to a depthwise per-color conv (28×28×3 / 75 params), and deleting the CNN-vs-Dense '62× fewer params' comparison block. Sorry this took so long to get back to you — thanks for your patience, and happy to re-review as soon as it's re-synced. |
2760e0c to
93296c1
Compare
93296c1 to
04731f2
Compare
|
Hello @profvjreddi, I have made the updates per your comments. You were correct about the The intro example that you mentioned was a typo, I meant to change it 30x30x16. I deleted the 62x fewer params comparison block since a similar comparison is being made above it with the same model structure when showcasing parameter efficiency (showed 120x). Please let me know what you think. I appreciate it. |
|
Hi @vedant-a-joshi, I see that your PR has been in waiting for some time and I've tagged prof. vijay to take a look into it and merge it or suggest changes to help you move forward with this. Happy Engineering ! |
|
Thanks @vedant-a-joshi! 🎉 I added @vedant-a-joshi to tinytorch for: code, test, doc. The contributor tables are now handled directly by this workflow; no follow-up command is needed. |
TinyTorch Module 09
Fixed misaligned tables. Fixed calculations for some of the comparisons. Fixed formatting of cells with extra new lines at the top as well as HTML tags. Other minor fixes to make sure everything looks neat.
Tested by running
pytest tests/, and the tests relevant to module 09 passed. Rantito module test 09and appropriate tests were passed. Note, there were some warnings aboutassertvs.returnin the tests. Manually verified that formatting looks good by running it as a jupyter notebook and checking manually.Revision of PR #1885
By submitting this PR, you agree to release your contribution under the project's license.