Skip to content

Bump dompurify from 3.4.11 to 3.4.12 in /socratiq - #1964

Closed
dependabot[bot] wants to merge 1 commit into
devfrom
dependabot/npm_and_yarn/socratiq/dompurify-3.4.12
Closed

Bump dompurify from 3.4.11 to 3.4.12 in /socratiq#1964
dependabot[bot] wants to merge 1 commit into
devfrom
dependabot/npm_and_yarn/socratiq/dompurify-3.4.12

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jul 24, 2026

Copy link
Copy Markdown
Contributor

Bumps dompurify from 3.4.11 to 3.4.12.

Release notes

Sourced from dompurify's releases.

DOMPurify 3.4.12

  • Fixed an issue where a hook would not get called for custom elements, thanks @​Rikuxx0
  • Hardened the handling of hooks removing elements, @​mkrause-bee360
  • Added support for a few new SVG attributes, thanks @​cbn-falias & @​Develop-KIM
  • Hardened the handling of declarative partial updates
  • Updated the documentation is several spots, README, wiki, etc.
  • Bumped several dependencies where possible
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [dompurify](https://github.com/cure53/DOMPurify) from 3.4.11 to 3.4.12.
- [Release notes](https://github.com/cure53/DOMPurify/releases)
- [Commits](cure53/DOMPurify@3.4.11...3.4.12)

---
updated-dependencies:
- dependency-name: dompurify
  dependency-version: 3.4.12
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Jul 24, 2026
@github-actions github-actions Bot added area: socratiq SocratiQ AI chatbot type: bug bug in rendering labels Jul 24, 2026
@Shashank-Tripathi-07

Copy link
Copy Markdown
Collaborator

Checked why CI is red here, and this one actually needs a fix before merge, not just a shrug.

dompurify is a direct dependency here, marked in package.json as the XSS sanitizer for AI-generated content, and it's directly imported in streamdown_markdown.js. The failing check is verify-bundle-matches-source. socratiq ships a separate pre-built file, book/quarto/tools/scripts/socratiQ/bundle.js, and there's a workflow that rebuilds that bundle fresh and fails if it doesn't match what's committed. Dependabot only touches package.json and the lockfile, it can't run the build step, so the committed bundle.js still has the old dompurify code baked in.

Confirmed this isn't a blanket failure on every Dependabot PR here, postcss and seroval bumps on this same project passed this exact check recently, because those two aren't actually reachable in the bundled runtime code. dompurify is, so bumping it genuinely changes what a fresh build produces, and the check is correctly catching that drift.

There's precedent too, a dompurify 3.4.10 to 3.4.11 bump failed this same check back in June, fixed by a separate PR that just ran the rebuild and committed it.

If this merges as-is, package.json says 3.4.12 but the actual bundle.js users load still ships the old 3.4.11 code, so the fix doesn't actually reach anyone. Needs npm run build:vite in socratiq/ and the regenerated bundle.js committed alongside this bump before it's safe to merge.

@dependabot @github

dependabot Bot commented on behalf of github Aug 8, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #1997.

@dependabot dependabot Bot closed this Aug 8, 2026
@dependabot
dependabot Bot deleted the dependabot/npm_and_yarn/socratiq/dompurify-3.4.12 branch August 8, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: socratiq SocratiQ AI chatbot dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code type: bug bug in rendering

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant