Added unit test to TransactionSchedulerService.

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>

Author: ericleponner

back-end/apps/chain/src/transaction-scheduler/transaction-scheduler.service.spec.ts

@@ -18,6 +18,7 @@ import {
   TransactionGroup,
   TransactionGroupItem,
   TransactionStatus,
+  UserKey,
 } from '@entities';
 
 import { TransactionSchedulerService } from './transaction-scheduler.service';
@@ -528,7 +529,7 @@ describe('TransactionStatusService', () => {
               id: 1,
               atomic: false,
               sequential: true,
-            }
+            },
           },
         } as Transaction,
         {
@@ -541,7 +542,7 @@ describe('TransactionStatusService', () => {
               id: 1,
               atomic: false,
               sequential: true,
-            }
+            },
           },
         } as Transaction,
       ];
@@ -553,6 +554,45 @@ describe('TransactionStatusService', () => {
 
       expect(service.collateGroupAndExecute).toHaveBeenCalledTimes(1);
     });
+
+    it('should not call collateGroupAndExecute when transactionGroup is null', async () => {
+      const transactionGroups = [
+        {
+          id: 1,
+          status: TransactionStatus.WAITING_FOR_EXECUTION,
+          validStart: new Date(),
+          groupItem: {
+            groupId: 1,
+            group: {
+              id: 1,
+              atomic: false,
+              sequential: true,
+            },
+          },
+        } as Transaction,
+        {
+          id: 3,
+          status: TransactionStatus.WAITING_FOR_EXECUTION,
+          validStart: new Date(),
+          groupItem: {
+            groupId: 1,
+            group: {
+              id: 1,
+              atomic: false,
+              sequential: true,
+            },
+          },
+        } as Transaction,
+      ];
+
+      transactionGroupRepo.findOne.mockResolvedValueOnce(null);
+      jest.spyOn(service, 'collateGroupAndExecute').mockImplementation(jest.fn());
+      jest.spyOn(service, 'isValidStartExecutable').mockImplementation(() => true);
+
+      await service.prepareTransactions(transactionGroups);
+
+      expect(service.collateGroupAndExecute).toHaveBeenCalledTimes(0);
+    });
   });
 
   describe('collateGroupAndExecute', () => {

back-end/apps/chain/src/transaction-scheduler/transaction-scheduler.service.ts

@@ -214,7 +214,7 @@ export class TransactionSchedulerService {
                 },
               },
             });
-            if (transactionGroup !== null) {
+            if (transactionGroup) {
               // All the transactions for the group are now pulled. If there is an issue validating for even one
               // transaction, the group will not be executed. This is handled in executeTransactionGroup
               this.collateGroupAndExecute(transactionGroup);