Adds scim settings, scim settings integration tests and generated mocks#1307
Adds scim settings, scim settings integration tests and generated mocks#1307
Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR introduces site-level SCIM settings support to the go-tfe Admin Settings surface area (new SCIM settings resource + interface), along with integration tests, helper utilities, and generated GoMock stubs to support the new API.
Changes:
- Adds a new SCIM admin settings resource (
admin_setting_scim.go) and wires it intoAdminSettings. - Adds SCIM settings integration tests and helper functions to exercise read/update/delete behavior.
- Updates changelog and mock generation outputs/scripts for the new SCIM settings interface.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
admin_setting.go |
Adds AdminSettings.SCIM and initializes the SCIM settings client. |
admin_setting_scim.go |
New SCIM settings interface, models, and CRUD methods against admin/scim-settings. |
admin_setting_scim_integration_test.go |
Integration coverage for SCIM settings read/update/delete + SCIM token/group helpers. |
helper_test.go |
Adds SAML enable/provider helpers and a helper to create SCIM groups via the SCIM API. |
generate_mocks.sh |
Adds mockgen invocation for the SCIM settings interface. |
mocks/admin_setting_scim_mocks.go |
Generated GoMock implementation for the SCIM settings interface. |
CHANGELOG.md |
Documents the new SCIM settings API additions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
This PR adds site-level SCIM settings support via a new
admin_setting_scim.goresource and theAdminSettings.SCIMinterface. It also includes integration tests, supporting helper functions, and generated mocks for the new resource.Reviewer Note
generateSCIMTokencurrently performs a direct API call to generate the SCIM token, as go-tfe does not yet expose a SCIM token resource. This will be cleaned up in a subsequent PR that introduces first-class SCIM token support.Testing plan
External links
Output from tests
Rollback Plan
we can revert this pr
Changes to Security Controls
NA