Skip to content

Commit df6ff6b

Browse files
chopratejasTejas Chopraclaude
authored
fix(deps): bump datasets past PYSEC-2026-3716 (#3136)
## Why this is urgent `datasets` 4.5.0 picked up **PYSEC-2026-3716** — path traversal in folder-based dataset builders, where an unvalidated `file_name` metadata field is joined to the dataset directory, so crafted traversal sequences can read arbitrary local files into output on `save_to_disk`/`push_to_hub`. **The advisory was published today between 07:17 and 15:35 UTC.** `main`'s audit passed at 07:17 on `17522fb0`; every PR run after 15:35 fails. So `Dependency audit (pip-audit)` is now **red repo-wide and blocks all open PRs**, not just one. ## Exposure Negligible for us. `datasets` is confined to the `evals` and `voice-train` extras, and every call site in the repo uses `load_dataset` against public Hub datasets — we never build folder-based datasets from untrusted metadata, and never call `save_to_disk`/`push_to_hub` on them. But the gate audits the `[all]` production set and fails on any actionable finding, so it has to be resolved rather than waived. ## The change Bump both extras to `>=5.0.1` and relock. `load_dataset` — the only API this repo touches — is unchanged across 2.x → 5.x. Lock diff is **5 lines, `datasets` alone**; nothing else re-resolved. ## Verification Ran the workflow's own command locally (`uv export --frozen --no-dev --no-emit-project --no-hashes --extra all`, audited under Python 3.12 to match CI): ``` No known vulnerabilities found ``` 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Tejas Chopra <tejas@Tejass-MacBook-Pro.local> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
1 parent 17522fb commit df6ff6b

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

pyproject.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -246,12 +246,12 @@ voice = [
246246
# Voice training (includes voice deps + training extras)
247247
voice-train = [
248248
"headroom-ai[voice]",
249-
"datasets>=2.14.0",
249+
"datasets>=5.0.1",
250250
"accelerate>=0.20.0",
251251
]
252252
# Evaluation framework
253253
evals = [
254-
"datasets>=2.14.0",
254+
"datasets>=5.0.1",
255255
"sentence-transformers>=2.2.0,<6.0; sys_platform != 'darwin' or platform_machine != 'x86_64'",
256256
"numpy>=1.24.0",
257257
"scikit-learn>=1.3.0",

uv.lock

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)