Fix signature help text cutoff

Author: ath3

helix-term/src/handlers/signature_help.rs

@@ -264,6 +264,7 @@ pub fn show_signature_help(
         active_signature,
         lsp_signature,
         signatures,
+        editor.popup_border(),
     );
 
     let mut popup = Popup::new(SignatureHelp::ID, contents)

helix-term/src/ui/lsp/signature_help.rs

@@ -29,6 +29,7 @@ pub struct SignatureHelp {
     active_signature: usize,
     lsp_signature: Option<usize>,
     signatures: Vec<Signature>,
+    popup_border: bool,
 }
 
 impl SignatureHelp {
@@ -40,13 +41,15 @@ impl SignatureHelp {
         active_signature: usize,
         lsp_signature: Option<usize>,
         signatures: Vec<Signature>,
+        popup_border: bool,
     ) -> Self {
         Self {
             language,
             config_loader,
             active_signature,
             lsp_signature,
             signatures,
+            popup_border,
         }
     }
 
@@ -94,7 +97,11 @@ impl Component for SignatureHelp {
     }
 
     fn render(&mut self, area: Rect, surface: &mut Buffer, cx: &mut Context) {
-        let margin = Margin::all(1);
+        let margin = if cx.editor.popup_border() {
+            Margin::horizontal(1)
+        } else {
+            Margin::all(1)
+        };
         let area = area.inner(margin);
 
         let signature = self
@@ -156,9 +163,7 @@ impl Component for SignatureHelp {
             Some(doc) => Markdown::new(doc.clone(), Arc::clone(&self.config_loader)),
         };
         let sig_doc = sig_doc.parse(Some(&cx.editor.theme));
-        let sig_doc_area = area
-            .clip_top(sig_text_area.height + 2)
-            .clip_bottom(u16::from(cx.editor.popup_border()));
+        let sig_doc_area = area.clip_top(sig_text_area.height + 1);
         let sig_doc_para = Paragraph::new(&sig_doc)
             .wrap(Wrap { trim: false })
             .scroll((cx.scroll.unwrap_or_default() as u16, 0));
@@ -206,6 +211,9 @@ impl Component for SignatureHelp {
             0
         };
 
-        Some((width + PADDING + sig_index_width as u16, height + PADDING))
+        Some((
+            width + PADDING + sig_index_width as u16,
+            height + PADDING * !self.popup_border as u16,
+        ))
     }
 }