Skip to content

Unhelpful Theme Errors #2247

Description

@joegm

When writing and experimenting with themes I've noticed that if there is anything wrong with a theme (syntax error, missing key, misspelled key) and you try to select it with :theme <mytheme> the error is always:

Invalid theme: 'ui.selection' required

This message shows up even when ui.selection is present and is most of the time completely irrelevant to the actual issue with the theme. I like the theming in Helix but this makes it a lot harder to work with. I'd prefer individual errors for, say:

  • Syntax errors like missing commas, with line number.
  • Non-existent/misspelled keys.
  • Required keys that aren't implemented, specifying which key it is.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-helix-termArea: Helix term improvementsC-enhancementCategory: Improvements

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions