Multiple quotation mark replacement fails

[aral]

Summary

Replacing multiple quotation marks results in inconsistent behaviour.

Reproduction Steps

To reproduce

1. Add the following code to a JavaScript page:

export default _ => html`
  <script defer src='https://unpkg.com/alpinejs@3.x.x/dist/cdn.min.js'></script>
  <h1 x-data="{ message: 'I ❤️ Alpine'}" x-text='message'></h1>
  <div x-data="{ count: 0 }">
    <button x-on:click="count++" style=>Increment</button>
    <span x-text="count"></span>
  </div>
`

2. Select all and then select all double quote marks. % s"

   

3. Press c and type a single quote(')

What should happen

All double quotes should be replaced with one single quote.

What actually happens

Some double quotes are replaced with one single quote, others are replaced with two.

This is also inconsistent with r which does the right thing.

Helix log

n/a

Platform

Linux (Fedora Silverblue 37)

Terminal Emulator

Black Box

Helix Version

helix 22.12 (0f2ae35)

[CptPotato]

This is caused by auto pairs of quotes, braces, etc. and I think it's the intended behavior.

If you want to replace " quotes to ' use r instead: %s"<ret>r'

If the replacement text is longer (not a single character), yank the desired replacement text, then %s"<ret>R (note the capital R which replaces all selections with the yanked text).

Edit: Regarding the discrepancy between c and r:
r performs a 1:1 character replacement, the number of characters doesn't change. On the other hand, c is a way of writing new text where you generally want auto pairs to work.

[aral]

@CptPotato I perhaps need to open a bug on auto-pairs then because they’re really not working as they should.

e.g., If I type: html` in JavaScript to create a tagged template, I get:

html`

Then, since auto pairs failed, if I type another `, I get:

html``|`

(I’ve added the | to show where the cursor is placed. That’s not in the actual output.)

Should I open a separate issue for this?

CC @the-mikedavis

[the-mikedavis]

I think that's an instance of #4100