fix: normalize custom post type archive slugs (#2133)

Sanitize configured archive slugs both when ACF saves them and before post type registration. This prevents leading or trailing URL separators from producing rewrite rules that WordPress can never match, while preserving existing normalized slugs and fallback behavior.

Co-authored-by: Sebastian Thulin <sebastianthulin@users.noreply.github.com>

Author: jeanfredrik

library/AcfFields/php/options-theme-custom-post-type.php

@@ -54,7 +54,7 @@
                     'name' => 'slug',
                     'aria-label' => '',
                     'type' => 'text',
-                    'instructions' => __('Public /url/ to show archive on.', 'municipio'),
+                    'instructions' => __('Public URL slug for the archive, without leading or trailing slashes.', 'municipio'),
                     'required' => 0,
                     'conditional_logic' => 0,
                     'wrapper' => array(

library/Content/CustomPostType.php

@@ -15,6 +15,11 @@ public function __construct()
             return $value;
         }, 10, 3);
 
+        // Keep stored and runtime rewrite slugs consistent with WordPress rewrite paths.
+        add_filter('acf/update_value/key=field_56b36c01e0619', static function ($value, $post_id, $field) {
+            return sanitize_title($value);
+        }, 10, 3);
+
         //Use page or single template
         add_filter('single_template', array($this, 'setPageTemplate'), 20);
 
@@ -73,13 +78,16 @@ public function registerCustomPostTypes()
             }
 
             $rewrite = ['with_front' => isset($typeDefinition['with_front']) ? $typeDefinition['with_front'] : true];
+            $slug = !empty($typeDefinition['slug'])
+                ? sanitize_title($typeDefinition['slug'])
+                : '';
 
-            if (!empty($typeDefinition['slug'])) {
-                $rewrite['slug'] = $typeDefinition['slug'];
+            if (!empty($slug)) {
+                $rewrite['slug'] = $slug;
             }
 
-            $restBase = !empty($typeDefinition['slug'])
-                ? sanitize_title($typeDefinition['slug'])
+            $restBase = !empty($slug)
+                ? $slug
                 : sanitize_title($typeDefinition['post_type_name']);
 
             $args = array(