Skip to content

refactor: improve parameter display#154

Merged
henry2004y merged 2 commits into
masterfrom
feat-show
May 6, 2026
Merged

refactor: improve parameter display#154
henry2004y merged 2 commits into
masterfrom
feat-show

Conversation

@henry2004y

Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the showhead function in src/io.jl to display parameters as key-value pairs when metadata is available, replacing the previous separate parameter list. Feedback suggests using more idiomatic Julia patterns, such as enumerate and zip for iteration and avoiding string concatenation in print calls to improve performance.

Comment thread src/io.jl Outdated
Comment thread src/io.jl Outdated
@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown

Benchmark Results (Julia v1)

Time benchmarks
master 5ea82dc... master / 5ea82dc...
amrex/load 26.2 ± 0.59 μs 26 ± 0.55 μs 1.01 ± 0.031
amrex/phase_space_3d 6.07 ± 1.3 ms 5.94 ± 0.99 ms 1.02 ± 0.28
amrex/select_region 0.249 ± 0.012 ms 0.246 ± 0.012 ms 1.01 ± 0.07
amrex/select_region_from_files 0.825 ± 0.072 ms 0.822 ± 0.073 ms 1 ± 0.12
read/ASCII 0.755 ± 0.01 ms 0.717 ± 0.0097 ms 1.05 ± 0.02
read/Anisotropy 0.0321 ± 0.00027 ms 0.0322 ± 0.00029 ms 0.997 ± 0.012
read/Anisotropy Symbol 0.0321 ± 0.00026 ms 0.0322 ± 0.0003 ms 0.997 ± 0.012
read/Cutdir 2.35 ± 0.27 μs 2.35 ± 0.28 μs 1 ± 0.16
read/Cutdir subset 3.29 ± 0.35 μs 3.28 ± 0.33 μs 1 ± 0.15
read/Extract Bmag 0.621 ± 0.17 μs 0.601 ± 0.16 μs 1.03 ± 0.39
read/HDF5 0.0827 ± 0.0023 ms 0.0831 ± 0.0024 ms 0.995 ± 0.04
read/HDF5 extract 12.7 ± 0.9 μs 12.3 ± 0.76 μs 1.03 ± 0.097
read/Interp2d 0.931 ± 0.26 μs 0.792 ± 0.14 μs 1.18 ± 0.39
read/Load binary structured 0.044 ± 0.0023 ms 0.044 ± 0.0022 ms 0.998 ± 0.072
time_to_load 1.26 ± 0.0043 s 1.26 ± 0.021 s 1 ± 0.017
Memory benchmarks
master 5ea82dc... master / 5ea82dc...
amrex/load 0.212 k allocs: 9.67 kB 0.212 k allocs: 9.67 kB 1
amrex/phase_space_3d 0.059 k allocs: 18.3 MB 0.059 k allocs: 18.3 MB 1
amrex/select_region 3 allocs: 1.07 MB 3 allocs: 1.07 MB 1
amrex/select_region_from_files 0.05 k allocs: 7.48 MB 0.05 k allocs: 7.48 MB 1
read/ASCII 0.505 k allocs: 0.112 MB 0.505 k allocs: 0.112 MB 1
read/Anisotropy 3 allocs: 4.84 kB 3 allocs: 4.84 kB 1
read/Anisotropy Symbol 3 allocs: 4.84 kB 3 allocs: 4.84 kB 1
read/Cutdir 0.137 k allocs: 5.98 kB 0.137 k allocs: 5.98 kB 1
read/Cutdir subset 0.159 k allocs: 8.89 kB 0.159 k allocs: 8.89 kB 1
read/Extract Bmag 3 allocs: 4.09 kB 3 allocs: 4.09 kB 1
read/HDF5 0.1 k allocs: 3.67 kB 0.1 k allocs: 3.67 kB 1
read/HDF5 extract 17 allocs: 4.55 kB 17 allocs: 4.55 kB 1
read/Interp2d 12 allocs: 4.45 kB 12 allocs: 4.45 kB 1
read/Load binary structured 0.241 k allocs: 0.0757 MB 0.241 k allocs: 0.0757 MB 1
time_to_load 0.149 k allocs: 11.1 kB 0.149 k allocs: 11.1 kB 1

@codecov

codecov Bot commented May 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.30%. Comparing base (d50c096) to head (5ea82dc).

Files with missing lines Patch % Lines
src/io.jl 75.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
- Coverage   81.33%   81.30%   -0.04%     
==========================================
  Files          20       20              
  Lines        3590     3599       +9     
==========================================
+ Hits         2920     2926       +6     
- Misses        670      673       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@henry2004y henry2004y merged commit 3d3d4e3 into master May 6, 2026
6 of 8 checks passed
@henry2004y henry2004y deleted the feat-show branch May 6, 2026 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant