fix: animate with plotrange#159
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request simplifies the indexing logic in animate.jl by removing explicit dimension mapping when applying a plotrange and expands the test suite with new cases for structured and unstructured data. Feedback suggests adding a check for empty data slices to prevent potential crashes when the plotrange does not overlap with coordinates, and refactoring repeated slicing logic for streamlines to improve readability.
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #159 +/- ##
==========================================
+ Coverage 81.78% 81.86% +0.08%
==========================================
Files 20 20
Lines 3595 3601 +6
==========================================
+ Hits 2940 2948 +8
+ Misses 655 653 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.