chore: improve rc discussion post

Author: FelixTJDietrich

scripts/rc_discussion.mjs

@@ -2,7 +2,7 @@
 // Maintains a single rolling RC discussion per upcoming release (vX.Y.Z)
 // - Creates the discussion once (if missing)
 // - Adds a comment for each RC (rc.1, rc.2, ...)
-// - Skips for stable releases
+// - Finalizes the thread on stable release
 
 const GQL_URL = 'https://api.github.com/graphql';
 
@@ -54,12 +54,12 @@ async function main() {
   const repoFull = process.env.GITHUB_REPOSITORY;
   const nextVersion = process.argv[2] || process.env.SEMREL_NEXT_VERSION;
   if (!token || !repoFull || !nextVersion) return;
-  if (!isRc(nextVersion)) return; // RCs only
   const [owner, name] = repoFull.split('/');
 
   // Derive base version without rc suffix
   const baseVersion = nextVersion.replace(/-rc\..*$/, '');
   const title = `Release Candidate: v${baseVersion}`;
+  const today = new Date().toISOString().slice(0, 10);
 
   // Determine last stable tag for proper compare link and cumulative notes
   let lastStableTag = '';
@@ -96,6 +96,16 @@ async function main() {
   const compareUrl = lastStableTag
     ? `https://github.com/${owner}/${name}/compare/${lastStableTag}...v${nextVersion}`
     : '';
+  // Try to find previous RC for delta link
+  let prevRcTag = '';
+  try {
+    const tags = run('git tag --sort=-v:refname').split('\n');
+    const rcTags = tags.filter((t) => t.startsWith(`v${baseVersion}-rc.`));
+    const currentRcNum = Number((nextVersion.match(/-rc\.(\d+)$/) || [])[1] || '0');
+    const prevTarget = `v${baseVersion}-rc.${currentRcNum - 1}`;
+    if (currentRcNum > 1 && rcTags.includes(prevTarget)) prevRcTag = prevTarget;
+  } catch {}
+  const deltaUrl = prevRcTag ? `https://github.com/${owner}/${name}/compare/${prevRcTag}...v${nextVersion}` : '';
 
   // Try to fetch auto-generated release notes from GitHub API (cumulative from last stable)
   let generatedNotes = '';
@@ -113,25 +123,47 @@ async function main() {
     generatedNotes = body?.body || '';
   } catch {}
 
-  const note = `Updated to v${nextVersion}. Release: ${releaseUrl}${compareUrl ? ` | Full changelog: ${compareUrl}` : ''}`;
+  const note = `Released ${today}: v${nextVersion} — ${releaseUrl}${deltaUrl ? ` | Delta since ${prevRcTag}: ${deltaUrl}` : ''}${compareUrl ? ` | Since last stable: ${compareUrl}` : ''}`;
 
-  const bodyTemplate = (v) => {
+
+  const bodyTemplateRc = (v) => {
     return [
       `Tracking thread for the upcoming release v${baseVersion}.`,
       '',
-      `Latest RC: v${v}`,
-      `Release: ${releaseUrl}`,
-      compareUrl ? `Full changelog: ${compareUrl}` : undefined,
+      `Date: ${today}`,
+      '',
+      `## Latest build`,
+      `- RC: v${v}`,
+      `- Release: ${releaseUrl}`,
+      compareUrl ? `- Since last stable: ${compareUrl}` : undefined,
+      deltaUrl ? `- Delta since previous RC (${prevRcTag}): ${deltaUrl}` : undefined,
       '',
+      `## Notes`,
+      `Feedback welcome — report issues here: https://github.com/${owner}/${name}/issues/new?title=${encodeURIComponent(
+        `RC v${v} feedback:`
+      )}`,
       generatedNotes
-        ? `<details><summary>Auto-generated release notes</summary>\n\n${generatedNotes}\n\n</details>`
+        ? `\n<details><summary>Auto-generated release notes</summary>\n\n${generatedNotes}\n\n</details>`
         : undefined,
     ]
       .filter(Boolean)
       .join('\n');
   };
 
-  if (!existing) {
+  const bodyTemplateStable = (v, finalDeltaUrl) => {
+    return [
+      `Status: Released v${v} on ${today}.`,
+      '',
+      `## Links`,
+      `- Stable: https://github.com/${owner}/${name}/releases/tag/v${v}`,
+      finalDeltaUrl ? `- Delta from last RC: ${finalDeltaUrl}` : undefined,
+      lastStableTag ? `- Since previous stable: https://github.com/${owner}/${name}/compare/${lastStableTag}...v${v}` : undefined,
+    ]
+      .filter(Boolean)
+      .join('\n');
+  };
+
+  if (isRc(nextVersion) && !existing) {
     // Create the rolling RC discussion once
   await gqlFetch(
       token,
@@ -140,31 +172,66 @@ async function main() {
           discussion { id number url }
         }
       }`,
-      { repoId: repo.id, catId: category.id, title, body: bodyTemplate(nextVersion) }
+      { repoId: repo.id, catId: category.id, title, body: bodyTemplateRc(nextVersion) }
     );
     // No further comment needed on first creation
     return;
   }
 
-  // Update the discussion body with latest RC details
-  await gqlFetch(
-    token,
-    `mutation UpdateDiscussion($id: ID!, $body: String!) {
-      updateDiscussion(input: { discussionId: $id, body: $body }) { discussion { id url } }
-    }`,
-    { id: existing.id, body: bodyTemplate(nextVersion) }
-  );
+  if (isRc(nextVersion) && existing) {
+    // Update the discussion body with latest RC details
+    await gqlFetch(
+      token,
+      `mutation UpdateDiscussion($id: ID!, $body: String!) {
+        updateDiscussion(input: { discussionId: $id, body: $body }) { discussion { id url } }
+      }`,
+      { id: existing.id, body: bodyTemplateRc(nextVersion) }
+    );
+    // Add a comment to the existing rolling thread
+    await gqlFetch(
+      token,
+      `mutation AddComment($discId: ID!, $body: String!) {
+        addDiscussionComment(input: { discussionId: $discId, body: $body }) {
+          comment { url }
+        }
+      }`,
+      { discId: existing.id, body: note }
+    );
+    return;
+  }
 
-  // Add a comment to the existing rolling thread
-  await gqlFetch(
-    token,
-    `mutation AddComment($discId: ID!, $body: String!) {
-      addDiscussionComment(input: { discussionId: $discId, body: $body }) {
-        comment { url }
-      }
-    }`,
-    { discId: existing.id, body: note }
-  );
+  // Stable release: finalize thread (if exists)
+  if (!isRc(nextVersion) && existing) {
+    // Compute delta from last RC to stable
+    let lastRcTag = '';
+    try {
+      const tags = run('git tag --sort=-v:refname').split('\n');
+      const rcTags = tags.filter((t) => t.startsWith(`v${baseVersion}-rc.`));
+      lastRcTag = rcTags[0] || '';
+    } catch {}
+    const finalDeltaUrl = lastRcTag
+      ? `https://github.com/${owner}/${name}/compare/${lastRcTag}...v${nextVersion}`
+      : '';
+
+    // Update body to show Released status and links
+    await gqlFetch(
+      token,
+      `mutation UpdateDiscussion($id: ID!, $body: String!) {
+        updateDiscussion(input: { discussionId: $id, body: $body }) { discussion { id url } }
+      }`,
+      { id: existing.id, body: bodyTemplateStable(nextVersion, finalDeltaUrl) }
+    );
+    // Post final comment
+    await gqlFetch(
+      token,
+      `mutation AddComment($discId: ID!, $body: String!) {
+        addDiscussionComment(input: { discussionId: $discId, body: $body }) {
+          comment { url }
+        }
+      }`,
+      { discId: existing.id, body: `Stable released ${today}: v${nextVersion} — https://github.com/${owner}/${name}/releases/tag/v${nextVersion}${finalDeltaUrl ? ` | Delta from last RC: ${finalDeltaUrl}` : ''}` }
+    );
+  }
 }
 
 main().catch(() => {