Skip to content

Commit 6992b9c

Browse files
fix(ci): workflows start with no token permissions and the Maven wrapper ships no jar (#1736)
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
1 parent e26e8ca commit 6992b9c

12 files changed

Lines changed: 403 additions & 444 deletions

.changeset/wrapper-ships-no-jar.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
---
2+
---
3+
4+
No release note: the Maven wrapper now downloads Maven through its script alone, so the repository ships no binary; the checksum check and the Maven version are unchanged.

.github/workflows/ci-profile.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ concurrency:
99
group: ci-profile-${{ github.ref }}
1010
cancel-in-progress: true
1111

12+
permissions: {}
13+
1214
jobs:
1315
server-integration:
1416
name: "Server integration profile"

.github/workflows/ci-quality-gates.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@ on:
3434
SURGE_TOKEN:
3535
required: false
3636

37+
permissions: {}
38+
3739
jobs:
3840
quality-gates:
3941
name: "${{ matrix.display-name }}"

.github/workflows/ci-security-scan.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ on:
99
type: string
1010
default: "false"
1111

12+
permissions: {}
13+
1214
jobs:
1315
dependency-review:
1416
name: "New dependency risk"

.github/workflows/deploy-locked-compose.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ on:
2121
required: false
2222
default: ""
2323

24+
permissions: {}
25+
2426
jobs:
2527
deploy:
2628
timeout-minutes: 20

.github/workflows/pull-request.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ concurrency:
1414
group: ${{ github.workflow }}-${{ github.event.pull_request.number }}
1515
cancel-in-progress: true
1616

17+
permissions: {}
18+
1719
jobs:
1820
validate-title:
1921
name: "Validate title"

.github/workflows/reusable-docker-build.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,8 @@ on:
6565
description: "Published image digest; an index digest for multi-architecture builds."
6666
value: ${{ inputs.single-arch && jobs.build.outputs.manifest-digest || jobs.merge.outputs.manifest-digest }}
6767

68+
permissions: {}
69+
6870
env:
6971
STANDARD_IMAGE_TAGS: |
7072
${{ github.event_name == 'push' && github.ref_name || '' }}

docs/contributor/local-development.mdx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,10 @@ Hephaestus supports full-stack development across Java and TypeScript. This guid
1111

1212
Install and configure the following tools before you attempt a local build:
1313

14-
1. **Java JDK 21** – Required for the Spring Boot application server.
14+
1. **Java JDK 21**, plus `curl` or `wget` and `unzip` – Required for the Spring Boot application
15+
server. The Maven wrapper ships no binary: on first use it downloads Maven and verifies the
16+
archive against the checksum in `server/.mvn/wrapper/maven-wrapper.properties`, and without
17+
`unzip` it falls back to an archive that checksum does not cover and refuses it.
1518
2. **Docker and Docker Compose** – Required for PostgreSQL and NATS. Verify both with `docker info`
1619
and `docker compose version`.
1720
3. **Node.js** – Match `package.json#devEngines.runtime`; it executes repository scripts and
-61.6 KB
Binary file not shown.
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1+
# mvnw checks distributionSha256Sum before it unpacks a download. `wrapper:wrapper` regenerates
2+
# the scripts without it, so keep the line when you change the Maven version by hand.
13
wrapperVersion=3.3.4
2-
distributionType=bin
3-
wrapperSha256Sum=4e2fbf6554bc8a4702cdfdd3bef464f423393d784ddbb037216320ce55d5e4e1
4+
distributionType=only-script
45
distributionSha256Sum=5af3b743dd8b876b5c45da33b676251e5f1687712644abb4ee519ca56e1d89ce
56
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.16/apache-maven-3.9.16-bin.zip
6-
wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.3.4/maven-wrapper-3.3.4.jar

0 commit comments

Comments
 (0)