fix(webapp): name the reviewed work's own source

A review run compared its artifact kind against `PULL_REQUEST`, `ISSUE` and
`CONVERSATION_THREAD`. Those are the Java constants' names; `ArtifactKind`
serialises through `@JsonValue` under a grammar that excludes upper case, so the
wire only ever carries `scm.pull_request`, `scm.issue`,
`chat.conversation_thread` and `docs.document`. Every branch was dead: a Slack
thread and an Outline document both took the GitHub mark and the GitHub label,
the channel name was dropped, and a run without a title read "Chat.conversation
thread on GitHub".

The shared registry in `lib/artifact-kinds` already owned these ids, and the
filter on the same page already used them — only the card had been left behind.
It now takes its glyph and its words from there, and the provider mark comes
from a table covering all four providers rather than defaulting to GitHub.
`docs.document` becomes filterable in the same move, and the source sentence
under a standing loses its third private copy of the same vocabulary.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MAQxdMw579siMh1wXKEEh4

Author: Valentin Grüner

webapp/src/components/profile/PracticeGroupDetailPage.tsx

@@ -35,58 +35,65 @@ import {
 	PopoverTrigger,
 } from "@/components/ui/popover";
 import { Skeleton } from "@/components/ui/skeleton";
+import { ARTIFACT_KIND_VALUES, artifactKindPluralLabel } from "@/lib/artifact-kinds";
 import { cn } from "@/lib/utils";
+import { PRACTICE_GROUP_STANDING_BADGE } from "./practice-group-standing-presentation";
 import { PracticeNextStepCallout } from "./PracticeNextStepCallout";
 import { PracticeTrendChip } from "./PracticeTrendChip";
-import { PRACTICE_GROUP_STANDING_BADGE } from "./practice-group-standing-presentation";
-import { ReviewRunTimeline } from "./ReviewRunTimeline";
 import type { FeedbackUsefulness, ObservationDetailState } from "./review-runs";
+import { ReviewRunTimeline } from "./ReviewRunTimeline";
 import { SEVERITY_ORDER, SEVERITY_PRESENTATION, type SeverityKey } from "./severity-presentation";
 
 type PracticeStandingKey = NonNullable<PracticeStanding["standing"]> | "UNMEASURED";
 
+/**
+ * The node's glyph and colour. Its **words** come from the standing registry, so a practice node and
+ * the group badge above it can never name the same value differently — they used to disagree on
+ * three of five. `UNMEASURED` is the one entry the registry cannot own: it is not a standing the
+ * server reports but the client's word for a practice it sent no standing for at all.
+ */
 const STANDING_NODE: Record<
 	PracticeStandingKey,
-	{ Icon: typeof CircleCheckIcon; circleClass: string; textClass: string; label: string }
+	{ Icon: typeof CircleCheckIcon; circleClass: string; textClass: string }
 > = {
 	DEVELOPING: {
 		Icon: CircleAlertIcon,
 		circleClass: "border-destructive/50 text-destructive",
 		textClass: "text-destructive",
-		label: "Needs attention",
 	},
 	MIXED: {
 		Icon: CircleMinusIcon,
 		circleClass: "border-warning/60 text-warning",
 		textClass: "text-warning",
-		label: "Mixed feedback",
 	},
 	STRENGTH: {
 		Icon: CircleCheckIcon,
 		circleClass: "border-success/60 text-success",
 		textClass: "text-success",
-		label: "Going well",
 	},
 	NOT_OBSERVED: {
 		Icon: CircleDashedIcon,
 		circleClass: "border-border text-muted-foreground",
 		textClass: "text-muted-foreground",
-		label: "Not observed yet",
 	},
 	NO_OPPORTUNITY: {
 		Icon: CircleDashedIcon,
 		circleClass: "border-border text-muted-foreground",
 		textClass: "text-muted-foreground",
-		label: "No occasion yet",
 	},
 	UNMEASURED: {
 		Icon: CircleDashedIcon,
 		circleClass: "border-border text-muted-foreground",
 		textClass: "text-muted-foreground",
-		label: "Not measured yet",
 	},
 };
 
+function standingNodeLabel(standing: PracticeStandingKey): string {
+	return standing === "UNMEASURED"
+		? "Not measured yet"
+		: PRACTICE_GROUP_STANDING_BADGE[standing].label;
+}
+
 export type ReviewRunSource = string;
 
 export interface ReviewRunFilters {
@@ -233,11 +240,10 @@ export function PracticeGroupDetailPage({
 	const hasAnyFeedNarrowing = activeFilterCount > 0 || selectedPractice !== undefined;
 	const hasReviewRuns = (reviewRuns?.length ?? 0) > 0;
 
-	const sourceOptions: { value: ReviewRunSource; label: string }[] = [
-		{ value: "scm.pull_request", label: "Pull requests" },
-		{ value: "scm.issue", label: "Issues" },
-		{ value: "chat.conversation_thread", label: "Slack conversations" },
-	];
+	// Every kind the build can name, so a document review is filterable the day the server sends one.
+	const sourceOptions: { value: ReviewRunSource; label: string }[] = ARTIFACT_KIND_VALUES.map(
+		(kind) => ({ value: kind, label: artifactKindPluralLabel(kind) }),
+	);
 
 	const toggleSource = (source: ReviewRunSource, checked: boolean) => {
 		const sources = checked
@@ -384,7 +390,9 @@ export function PracticeGroupDetailPage({
 													{practice.name}
 												</span>
 												<div className="relative z-20 flex flex-wrap items-center gap-x-2 gap-y-1 text-sm leading-5">
-													<span className={node.textClass}>{node.label}</span>
+													<span className={node.textClass}>
+														{standingNodeLabel(practiceStanding)}
+													</span>
 													{practiceTrend && (
 														<PracticeTrendChip
 															direction={practiceTrend.direction}

webapp/src/components/profile/PracticeGroupStandingCard.tsx

@@ -7,17 +7,15 @@ import { Badge } from "@/components/ui/badge";
 import { Button } from "@/components/ui/button";
 import { Card, CardContent, CardHeader, CardTitle } from "@/components/ui/card";
 import { Skeleton } from "@/components/ui/skeleton";
+import { artifactKindCountLabel } from "@/lib/artifact-kinds";
 import { cn } from "@/lib/utils";
+import { PRACTICE_GROUP_STANDING_BADGE } from "./practice-group-standing-presentation";
 import {
 	PracticeGroupStandingRing,
 	STANDING_LEGEND,
 	summarizePracticeStandings,
 } from "./PracticeGroupStandingRing";
 import { PracticeTrendChip } from "./PracticeTrendChip";
-import {
-	PRACTICE_GROUP_SOURCE_META,
-	PRACTICE_GROUP_STANDING_BADGE,
-} from "./practice-group-standing-presentation";
 
 const COLLAPSED_GROUP_COUNT = 3;
 const STANDING_PRIORITY: Record<PracticeGroupStanding["standing"], number> = {
@@ -38,12 +36,6 @@ export interface PracticeGroupStandingSectionProps {
 	practicesByGroup?: Record<string, PracticeStanding[] | undefined>;
 }
 
-function sourceLabel(workKind: string, count: number): string {
-	const metadata = PRACTICE_GROUP_SOURCE_META[workKind];
-	if (!metadata) return `${count} ${workKind}`;
-	return `${count} ${count === 1 ? metadata.singular : metadata.plural}`;
-}
-
 export function PracticeGroupStandingCard({
 	groups,
 	standings,
@@ -162,7 +154,7 @@ export function PracticeGroupStandingCard({
 									<p className="text-xs text-muted-foreground">
 										Based on{" "}
 										{groupStanding.sources
-											.map(({ workKind, count }) => sourceLabel(workKind, count))
+											.map(({ workKind, count }) => artifactKindCountLabel(workKind, count))
 											.join(", ")}
 									</p>
 								)}