feat(SpellAuraStat): Change logic to handle multiple entries with the same id_parent

Author: Cilraaz

scripts/parsers/SpellAuraStat.py

@@ -21,28 +21,23 @@
 
 with open(os.path.join(generatedDir, 'SpellEffect.csv')) as csvfile:
     reader = list(csv.DictReader(csvfile, escapechar='\\'))
-    reader = sorted(reader, key=lambda d: (int(d['id_parent']), -int(d['sub_type'])))
+    # group by id_parent
+    effects_by_parent = {}
+    for row in reader:
+        parent_id = int(row['id_parent'])
+        if parent_id > 0 and int(row['type']) == 6:
+            effects_by_parent.setdefault(parent_id, []).append(row)
+            
+    # iterate through effects_by_parent and check for wanted sub-types
     with open(os.path.join(addonEnumDir, 'SpellAuraStat.lua'), 'w', encoding='utf-8') as file:
         file.write('HeroDBC.DBC.SpellAuraStat = {\n')
-        current = 0
-        for _, row in enumerate(reader):
-            if int(row['id_parent']) > 0 and current != int(row['id_parent']) and int(row['type']) == 6:
-                current = int(row['id_parent'])
-                # Attribute (29)
-                # Modify Total Stat% (137)
-                # Modify Rating (189) with misc values mapping to stats
-                # Modify All Haste% (193)
-                # Modify Critical Strike% (290)
-                # Modify Mastery% (318)
-                # Modify Versatility% (471)
-                if (int(row['sub_type']) == 29 or
-                    int(row['sub_type']) == 137 or
-                    int(row['sub_type']) == 193 or
-                    int(row['sub_type']) == 290 or
-                    int(row['sub_type']) == 318 or
-                    int(row['sub_type']) == 471 or
-                    int(row['sub_type']) == 189 and (int(row['misc_value_1']) == 1792 or int(row['misc_value_1']) == 917504 or int(row['misc_value_1']) == 33554432 or int(row['misc_value_1']) == 1879048192)):
-                    file.write('  [' + row['id_parent'] + '] = true,\n')
-                else:
-                    file.write('  [' + row['id_parent'] + '] = false,\n')
+        for parent_id, rows in sorted(effects_by_parent.items()):
+            match_found = False
+            for row in rows:
+                subtype = int(row['sub_type'])
+                if (subtype in (29, 137, 193, 290, 318, 471) or
+                    (subtype == 189 and int(row['misc_value_1']) in (1792, 917504, 33554432, 1879048192))):
+                    match_found = True
+                    break
+            file.write(f'  [{parent_id}] = {"true" if match_found else "false"},\n')
         file.write('}\n')