feat(1938): change config set options (#1947)

Signed-off-by: mmyslblocky <michal.myslinski@blockydevs.com>

Author: mmyslblocky

README.md

@@ -342,10 +342,10 @@ Configure the default key storage method using the config command:
 
 ```bash
 # Set to plain text storage (development/testing)
-hcli config set -o default_key_manager -V local
+hcli config set --default_key_manager local
 
 # Set to encrypted storage (production)
-hcli config set -o default_key_manager -V local_encrypted
+hcli config set --default_key_manager local_encrypted
 ```
 
 ### Per-Operation Override

docs/adr/ADR-004-key-protection-mechanism.md

@@ -118,7 +118,7 @@ Users can disable encryption entirely for development and testing scenarios:
 **Configuration Method:**
 
 - First-run wizard will prompt: "Enable key encryption? (Recommended for production, can be disabled for local development)"
-- Key storage mode is configurable via: `hcli config set -o default_key_manager -V local|local_encrypted`
+- Key storage mode is configurable via: `hcli config set --default_key_manager local` or `hcli config set --default_key_manager local_encrypted`
 
 **When Encryption is Disabled:**
 

docs/architecture.md

@@ -614,7 +614,7 @@ Core API
 - Keys are stored in the KMS (Key Management Service) with two storage options:
   - **`local`**: Plain text storage (development/testing environments)
   - **`local_encrypted`**: AES-256-GCM encrypted storage (production environments)
-- Default key manager configurable via `hcli config set -o default_key_manager -V local|local_encrypted`
+- Default key manager configurable via `hcli config set --default_key_manager local` or `hcli config set --default_key_manager local_encrypted`
 - Per-operation override available using `--key-manager` flag on commands that store keys
 - No hardcoded credentials in code
 

docs/core-api.md

@@ -583,9 +583,9 @@ The global log level is controlled by the config option `log_level`:
 - configure via CLI, for example:
 
 ```bash
-hcli config set -o log_level -V silent
-hcli config set -o log_level -V error
-hcli config set -o log_level -V debug
+hcli config set --log_level silent
+hcli config set --log_level error
+hcli config set --log_level debug
 ```
 
 All logger output is written to **stderr** so that structured command output on stdout
@@ -611,7 +611,7 @@ The KMS supports two storage modes for private keys:
 - **`local`** - Keys stored as plain text (suitable for development and testing)
 - **`local_encrypted`** - Keys encrypted using AES-256-GCM (recommended for production)
 
-The default storage mode is configured via `hcli config set -o default_key_manager -V local|local_encrypted`. Individual operations can override this using the `--key-manager` flag when available.
+The default storage mode is configured via `hcli config set --default_key_manager local` or `hcli config set --default_key_manager local_encrypted`. Individual operations can override this using the `--key-manager` flag when available.
 
 ```typescript
 interface KmsService {

skills/hiero-cli/references/config.md

@@ -47,18 +47,22 @@ hcli config get --option default_key_manager
 
 ### `hcli config set`
 
-Set the value of a configuration option.
+Set the value of a configuration option. Pass exactly one named option flag per invocation.
 
-| Option     | Short | Type   | Required | Description                                                        |
-| ---------- | ----- | ------ | -------- | ------------------------------------------------------------------ |
-| `--option` | `-o`  | string | **yes**  | Option name to set. Use `config list` to see available options     |
-| `--value`  | `-V`  | string | **yes**  | Value to set. Booleans: `true`/`false`. Numbers as strings: `"10"` |
+| Option                      | Type   | Required | Allowed values                             |
+| --------------------------- | ------ | -------- | ------------------------------------------ |
+| `--default_key_manager`     | string | one of   | `local`, `local_encrypted`                 |
+| `--ed25519_support_enabled` | string | one of   | `true`, `false`                            |
+| `--log_level`               | string | one of   | `silent`, `error`, `warn`, `info`, `debug` |
+| `--skip_confirmations`      | string | one of   | `true`, `false`                            |
 
 **Example:**
 
 ```
-hcli config set --option default_key_manager --value local_encrypted
-hcli config set --option skip_confirmations --value true
+hcli config set --default_key_manager local_encrypted
+hcli config set --skip_confirmations true
+hcli config set --log_level debug
+hcli config set --ed25519_support_enabled false
 ```
 
 **Output:** `{ name, previousValue, newValue }`

src/__tests__/integration/config/config.integration.test.ts

@@ -32,7 +32,7 @@ describe('Config Integration Tests', () => {
     const optionNames = listConfigOutput.options.map((option) => option.name);
     expect(optionNames).toEqual(
       expect.arrayContaining([
-        ConfigOptionKey.ed25519_support_enabled,
+        ConfigOptionKey.ed25519_support,
         ConfigOptionKey.log_level,
         ConfigOptionKey.default_key_manager,
       ]),
@@ -41,8 +41,7 @@ describe('Config Integration Tests', () => {
 
   it('should set config option and then verify it with with get method', async () => {
     const setConfigArgs: Record<string, unknown> = {
-      option: ConfigOptionKey.ed25519_support_enabled,
-      value: 'true',
+      [ConfigOptionKey.ed25519_support]: 'true',
     };
     const setConfigResult = await configSet({
       args: setConfigArgs,
@@ -53,14 +52,14 @@ describe('Config Integration Tests', () => {
     expect(setConfigOutput.newValue).toBe(true);
 
     const getConfigArgs: Record<string, unknown> = {
-      option: ConfigOptionKey.ed25519_support_enabled,
+      option: ConfigOptionKey.ed25519_support,
     };
     const getConfigResult = await configGet({
       args: getConfigArgs,
       api: coreApi,
     });
     const getConfigOutput = getConfigResult.result as ConfigGetOutput;
-    expect(getConfigOutput.name).toBe(ConfigOptionKey.ed25519_support_enabled);
+    expect(getConfigOutput.name).toBe(ConfigOptionKey.ed25519_support);
     expect(getConfigOutput.value).toBe(true);
     expect(getConfigOutput.type).toBe('boolean');
   });

src/core/core-api/core-api.ts

@@ -15,10 +15,7 @@ import type { ContractVerifierService } from '@/core/services/contract-verifier/
 import type { IdentityResolutionService } from '@/core/services/identity-resolution/identity-resolution-service.interface';
 import type { KeyResolverService } from '@/core/services/key-resolver/key-resolver-service.interface';
 import type { KmsService } from '@/core/services/kms/kms-service.interface';
-import type {
-  Logger,
-  LogLevel,
-} from '@/core/services/logger/logger-service.interface';
+import type { Logger } from '@/core/services/logger/logger-service.interface';
 import type { HederaMirrornodeService } from '@/core/services/mirrornode/hedera-mirrornode-service.interface';
 import type { NetworkService } from '@/core/services/network/network-service.interface';
 import type { OutputService } from '@/core/services/output/output-service.interface';
@@ -31,6 +28,7 @@ import type { TopicService } from '@/core/services/topic/topic-transaction-servi
 import type { TransferService } from '@/core/services/transfer/transfer-service.interface';
 import type { TxExecuteService } from '@/core/services/tx-execute/tx-execute-service.interface';
 import type { TxSignService } from '@/core/services/tx-sign/tx-sign-service.interface';
+import type { LogLevel } from '@/core/types/shared.types';
 
 import { AccountServiceImpl } from '@/core/services/account/account-transaction-service';
 import { AliasServiceImpl } from '@/core/services/alias/alias-service';

src/core/index.ts

@@ -36,7 +36,7 @@ export type * from './services/contract-verifier/contract-verifier-service.inter
 export type * from './services/identity-resolution/identity-resolution-service.interface';
 export type * from './services/key-resolver/key-resolver-service.interface';
 export type * from './services/kms/kms-service.interface';
-export * from './services/logger/logger-service.interface';
+export type * from './services/logger/logger-service.interface';
 export type * from './services/mirrornode/hedera-mirrornode-service.interface';
 export type { NetworkService } from './services/network/network-service.interface';
 export type * from './services/output/output-service.interface';

src/core/schemas/common-schemas.ts

@@ -739,29 +739,6 @@ export const ConfigOptionNameSchema = z
   )
   .describe('Configuration option name');
 
-/**
- * Configuration Option Value
- * Value for configuration option (can be string, number, or boolean as string)
- * Handler will parse it to appropriate type
- */
-export const ConfigOptionValueSchema = z
-  .preprocess(
-    (value) => {
-      if (typeof value !== 'string') return value;
-      const s = value.trim().toLowerCase();
-
-      if (s === 'true') return true;
-      if (s === 'false') return false;
-
-      const n = Number(value);
-      if (!Number.isNaN(n) && Number.isFinite(n)) return n;
-
-      return value;
-    },
-    z.union([z.boolean(), z.number(), z.string()]),
-  )
-  .describe('Configuration option value (boolean, number, or string)');
-
 /**
  * Key Reference ID
  * Identifier for a key stored in KMS (Key Management System)
@@ -1242,3 +1219,8 @@ export const ScheduledTransactionDataSchema = z.object({
   ),
   createdAt: z.string().optional(),
 });
+
+export const BooleanStringSchema = z.preprocess(
+  (v) => (v === 'true' ? true : v === 'false' ? false : v),
+  z.boolean({ error: 'Value must be true or false' }),
+);

src/core/services/config/__tests__/unit/config-service.test.ts

@@ -29,7 +29,7 @@ describe('ConfigServiceImpl', () => {
       expect(options).toEqual(
         expect.arrayContaining([
           expect.objectContaining({
-            name: ConfigOptionKey.ed25519_support_enabled,
+            name: ConfigOptionKey.ed25519_support,
             type: 'boolean',
             value: false,
           }),
@@ -51,15 +51,14 @@ describe('ConfigServiceImpl', () => {
 
     it('should return stored values when available', () => {
       stateMock.get.mockImplementation((_: string, key: string) => {
-        if (key === (ConfigOptionKey.ed25519_support_enabled as string))
-          return true;
+        if (key === (ConfigOptionKey.ed25519_support as string)) return true;
         if (key === (ConfigOptionKey.log_level as string)) return 'debug';
         return undefined;
       });
 
       const options = configService.listOptions();
       const ed25519Option = options.find(
-        (o) => o.name === (ConfigOptionKey.ed25519_support_enabled as string),
+        (o) => o.name === (ConfigOptionKey.ed25519_support as string),
       );
       const logLevelOption = options.find(
         (o) => o.name === (ConfigOptionKey.log_level as string),
@@ -89,33 +88,27 @@ describe('ConfigServiceImpl', () => {
     it('should return stored value for boolean option', () => {
       stateMock.get.mockReturnValue(true);
 
-      const result = configService.getOption(
-        ConfigOptionKey.ed25519_support_enabled,
-      );
+      const result = configService.getOption(ConfigOptionKey.ed25519_support);
 
       expect(stateMock.get).toHaveBeenCalledWith(
         'config',
-        ConfigOptionKey.ed25519_support_enabled,
+        ConfigOptionKey.ed25519_support,
       );
       expect(result).toBe(true);
     });
 
     it('should return default value when not set', () => {
       stateMock.get.mockReturnValue(undefined);
 
-      const result = configService.getOption(
-        ConfigOptionKey.ed25519_support_enabled,
-      );
+      const result = configService.getOption(ConfigOptionKey.ed25519_support);
 
       expect(result).toBe(false);
     });
 
     it('should return default value when null', () => {
       stateMock.get.mockReturnValue(null);
 
-      const result = configService.getOption(
-        ConfigOptionKey.ed25519_support_enabled,
-      );
+      const result = configService.getOption(ConfigOptionKey.ed25519_support);
 
       expect(result).toBe(false);
     });
@@ -129,9 +122,7 @@ describe('ConfigServiceImpl', () => {
     it('should convert value to boolean for boolean type', () => {
       stateMock.get.mockReturnValue('truthy_string');
 
-      const result = configService.getOption(
-        ConfigOptionKey.ed25519_support_enabled,
-      );
+      const result = configService.getOption(ConfigOptionKey.ed25519_support);
 
       expect(result).toBe(true);
     });
@@ -155,11 +146,11 @@ describe('ConfigServiceImpl', () => {
 
   describe('setOption', () => {
     it('should set boolean option', () => {
-      configService.setOption(ConfigOptionKey.ed25519_support_enabled, true);
+      configService.setOption(ConfigOptionKey.ed25519_support, true);
 
       expect(stateMock.set).toHaveBeenCalledWith(
         'config',
-        ConfigOptionKey.ed25519_support_enabled,
+        ConfigOptionKey.ed25519_support,
         true,
       );
     });
@@ -172,10 +163,7 @@ describe('ConfigServiceImpl', () => {
 
     it('should throw error when setting non-boolean for boolean option', () => {
       expect(() =>
-        configService.setOption(
-          ConfigOptionKey.ed25519_support_enabled,
-          'not_boolean',
-        ),
+        configService.setOption(ConfigOptionKey.ed25519_support, 'not_boolean'),
       ).toThrow(ValidationError);
     });