Skip to content

Commit 44e20e3

Browse files
authored
chore: consistency and dead code cleanup (#134)
* fix: resolve consistency and dead-code issues across contracts Signed-off-by: ValentinVPK <valentin.krumov@limechain.tech> * fix: correct identifier/doc typos and make send0x1 use .send Signed-off-by: ValentinVPK <valentin.krumov@limechain.tech> --------- Signed-off-by: ValentinVPK <valentin.krumov@limechain.tech>
1 parent 794f0d6 commit 44e20e3

21 files changed

Lines changed: 2835 additions & 1748 deletions

contracts/account-service/HederaAccountService.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ abstract contract HederaAccountService {
8080
}
8181

8282
/// Determines if the signature is valid for the given message hash and account.
83-
/// It is assumed that the signature is composed of a single EDCSA or ED25519 key.
83+
/// It is assumed that the signature is composed of a single ECDSA or ED25519 key.
8484
/// @param account The account to check the signature against
8585
/// @param messageHash The hash of the message to check the signature against
8686
/// @param signature The signature to check

contracts/account-service/IHRC632.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ interface IHRC632 {
2222
function isValidAlias(address addr) external returns (bool response);
2323

2424
/// Determines if the signature is valid for the given message hash and account.
25-
/// It is assumed that the signature is composed of a single EDCSA or ED25519 key.
25+
/// It is assumed that the signature is composed of a single ECDSA or ED25519 key.
2626
/// @param account The account to check the signature against.
2727
/// @param messageHash The hash of the message to check the signature against.
2828
/// @param signature The signature to check.

contracts/account-service/IHederaAccountService.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ interface IHederaAccountService {
4646
function isValidAlias(address addr) external returns (int64 responseCode, bool response);
4747

4848
/// Determines if the signature is valid for the given message hash and account.
49-
/// It is assumed that the signature is composed of a single EDCSA or ED25519 key.
49+
/// It is assumed that the signature is composed of a single ECDSA or ED25519 key.
5050
/// @param account The account to check the signature against.
5151
/// @param messageHash The hash of the message to check the signature against.
5252
/// @param signature The signature to check.

contracts/exchange-rate/ExchangeRateMock.sol

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@ contract ExchangeRateMock is SelfFunding {
77
event TinyBars(uint256 tinybars);
88
event TinyCents(uint256 tinycents);
99

10-
function convertTinycentsToTinybars(uint256 tineycents) external returns (uint256 tinybars) {
11-
tinybars = tinycentsToTinybars(tineycents);
10+
function convertTinycentsToTinybars(uint256 tinycents) external returns (uint256 tinybars) {
11+
tinybars = tinycentsToTinybars(tinycents);
1212
emit TinyBars(tinybars);
1313
}
1414

15-
function convertTinybarsToTinycents(uint256 tinybars) external returns (uint256 tineycents) {
16-
tineycents = tinybarsToTinycents(tinybars);
17-
emit TinyCents(tineycents);
15+
function convertTinybarsToTinycents(uint256 tinybars) external returns (uint256 tinycents) {
16+
tinycents = tinybarsToTinycents(tinybars);
17+
emit TinyCents(tinycents);
1818
}
1919
}

contracts/extensions/hrc-904/Airdrop.sol

Lines changed: 289 additions & 217 deletions
Large diffs are not rendered by default.

contracts/extensions/ihrc-1215/HRC1215Contract.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// SPDX-License-Identifier: UNLICENSED
1+
// SPDX-License-Identifier: Apache-2.0
22
pragma solidity >=0.4.9 <0.9.0;
33

44
import "../../schedule-service/HederaScheduleService.sol";

contracts/extensions/ihrc-755/HRC755Contract.sol

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
pragma solidity >=0.4.9 <0.9.0;
33

44
import "../../schedule-service/HederaScheduleService.sol";
5-
import "../../token-service/HederaTokenService.sol";
65

76
pragma experimental ABIEncoderV2;
87

contracts/extensions/token-create/TokenCreateContract.sol

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,9 @@ pragma solidity >=0.5.0 <0.9.0;
33
pragma experimental ABIEncoderV2;
44

55
import "../../token-service/HederaTokenService.sol";
6-
import "../../token-service/ExpiryHelper.sol";
76
import "../../token-service/KeyHelper.sol";
87

9-
contract TokenCreateContract is HederaTokenService, ExpiryHelper, KeyHelper {
8+
contract TokenCreateContract is HederaTokenService, KeyHelper {
109

1110
string name = "tokenName";
1211
string symbol = "tokenSymbol";

contracts/extensions/token-create/TokenCreateCustom.sol

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,10 @@ pragma solidity >=0.5.0 <0.9.0;
33
pragma experimental ABIEncoderV2;
44

55
import "../../token-service/HederaTokenService.sol";
6-
import "../../token-service/ExpiryHelper.sol";
76
import "../../token-service/KeyHelper.sol";
87
import "../../token-service/FeeHelper.sol";
98

10-
contract TokenCreateCustomContract is HederaTokenService, ExpiryHelper, KeyHelper, FeeHelper {
9+
contract TokenCreateCustomContract is HederaTokenService, KeyHelper, FeeHelper {
1110
bool finiteTotalSupplyType = true;
1211

1312
error TokenTransferFailed(int responseCode);

contracts/extensions/token-manage/TokenManagementContract.sol

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,9 @@ pragma solidity >=0.5.0 <0.9.0;
33
pragma experimental ABIEncoderV2;
44

55
import "../../token-service/HederaTokenService.sol";
6-
import "../../token-service/ExpiryHelper.sol";
7-
import "../../token-service/KeyHelper.sol";
86
import "@openzeppelin/contracts/utils/Strings.sol";
97

10-
contract TokenManagementContract is HederaTokenService, ExpiryHelper, KeyHelper {
8+
contract TokenManagementContract is HederaTokenService {
119

1210
event ResponseCode(int responseCode);
1311
event PausedToken(bool paused);

0 commit comments

Comments
 (0)