Fix draft HIP site refresh (#1527)

Signed-off-by: Michael Garber <michael.garber@hashgraph.com>

Author: mgarbs

.github/workflows/deploy-site.yml

@@ -3,6 +3,10 @@ name: Deploy Site
 on:
   push:
     branches: [main]
+  # Draft HIPs live only in open pull requests, so refresh the published
+  # GitHub Pages artifact even when main has not changed.
+  schedule:
+    - cron: "0 */6 * * *"
   workflow_dispatch:
 
 permissions:
@@ -37,6 +41,10 @@ jobs:
         working-directory: site
         run: npm ci
 
+      - name: Test site
+        working-directory: site
+        run: npm test
+
       - name: Setup Pages
         id: pages
         uses: actions/configure-pages@45bfe0192ca1faeb007ade9deae92b16b8254a0d # v6.0.0
@@ -46,10 +54,11 @@ jobs:
         run: npm run build:data
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          REQUIRE_LIVE_DRAFT_HIPS: "true"
 
       - name: Build site
         working-directory: site
-        run: npm run build
+        run: npm run build:app
         env:
           VITE_BASE: ${{ steps.pages.outputs.base_path }}/
 

.github/workflows/update-draft-hips.yml

@@ -5,9 +5,10 @@
   "scripts": {
     "build:data": "node scripts/build-data.js",
     "dev": "npm run build:data && vite",
-    "build": "npm run build:data && vite build",
+    "build:app": "vite build",
+    "build": "npm run build:data && npm run build:app",
     "preview": "vite preview",
-    "test": "node --test scripts/hip-parse.test.js"
+    "test": "node --test scripts/*.test.js"
   },
   "dependencies": {
     "gray-matter": "^4.0.3",

site/package.json

@@ -14,6 +14,7 @@ const OUT_DIR = path.resolve('public/data');
 const PUBLIC_ASSETS = path.resolve('public/assets');
 const REPO_OWNER = 'hiero-ledger';
 const REPO_NAME = 'hiero-improvement-proposals';
+const REQUIRE_LIVE_DRAFT_HIPS = process.env.REQUIRE_LIVE_DRAFT_HIPS === 'true';
 
 fs.mkdirSync(OUT_DIR, { recursive: true });
 
@@ -88,26 +89,39 @@ async function getDraftPRs() {
         },
         body: JSON.stringify({ query }),
       });
+      if (!res.ok) {
+        throw new Error(`GitHub GraphQL request failed with HTTP ${res.status}`);
+      }
       const json = await res.json();
-      if (json.errors) {
-        console.warn(`  Draft-HIP PR fetch: ${json.errors[0]?.message || 'GraphQL error'} — falling back to committed data`);
-      } else {
-        const nodes = json.data?.repository?.pullRequests?.nodes || [];
-        // Keep only PRs that ADD a new HIP/hip-*.md file — the same filter the
-        // old update-draft-hips.yml workflow used to produce _data/draft_hips.json.
-        const drafts = nodes.filter(pr =>
-          (pr.files?.edges || []).some(e =>
-            e.node.changeType === 'ADDED' &&
-            /^HIP\/hip-[A-Za-z0-9-]+\.md$/.test(e.node.path)
-          )
-        );
-        console.log(`Fetched ${drafts.length} open draft-HIP PRs from GitHub`);
-        return drafts;
+      if (json.errors?.length) {
+        throw new Error(json.errors[0]?.message || 'GitHub GraphQL request failed');
+      }
+
+      const nodes = json.data?.repository?.pullRequests?.nodes;
+      if (!Array.isArray(nodes)) {
+        throw new Error('GitHub GraphQL response did not include pull requests');
       }
+
+      // Keep only PRs that ADD a new HIP/hip-*.md file — the same filter the
+      // old update-draft-hips.yml workflow used to produce _data/draft_hips.json.
+      const drafts = nodes.filter(pr =>
+        (pr.files?.edges || []).some(e =>
+          e.node.changeType === 'ADDED' &&
+          /^HIP\/hip-[A-Za-z0-9-]+\.md$/.test(e.node.path)
+        )
+      );
+      console.log(`Fetched ${drafts.length} open draft-HIP PRs from GitHub`);
+      return drafts;
     } catch (e) {
+      if (REQUIRE_LIVE_DRAFT_HIPS) {
+        throw new Error(`Required live draft-HIP fetch failed: ${e.message}`);
+      }
       console.warn(`  Draft-HIP PR fetch failed (${e.message}) — falling back to committed data`);
     }
   } else {
+    if (REQUIRE_LIVE_DRAFT_HIPS) {
+      throw new Error('GITHUB_TOKEN is required when REQUIRE_LIVE_DRAFT_HIPS=true');
+    }
     console.log('No GITHUB_TOKEN set — using committed _data/draft_hips.json if present');
   }
 
@@ -404,4 +418,7 @@ async function main() {
   if (Object.keys(prReviews).length) console.log(`  ${Object.keys(prReviews).length} PR review threads cached`);
 }
 
-main();
+main().catch((error) => {
+  console.error(`Site data build failed: ${error.message}`);
+  process.exitCode = 1;
+});

site/scripts/build-data.js

@@ -0,0 +1,45 @@
+import test from 'node:test';
+import assert from 'node:assert/strict';
+import fs from 'fs';
+import path from 'path';
+import { fileURLToPath } from 'url';
+
+const repoRoot = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '../..');
+const deployWorkflowPath = path.join(repoRoot, '.github', 'workflows', 'deploy-site.yml');
+const legacyRefreshWorkflowPath = path.join(
+  repoRoot,
+  '.github',
+  'workflows',
+  'update-draft-hips.yml',
+);
+const deployWorkflow = fs.readFileSync(deployWorkflowPath, 'utf8');
+
+function workflowStep(name) {
+  const marker = `      - name: ${name}\n`;
+  const start = deployWorkflow.indexOf(marker);
+  assert.notEqual(start, -1, `Missing workflow step: ${name}`);
+  const next = deployWorkflow.indexOf('\n      - name:', start + marker.length);
+  return deployWorkflow.slice(start, next === -1 ? undefined : next);
+}
+
+test('the GitHub Pages workflow owns the scheduled draft-HIP refresh', () => {
+  assert.match(deployWorkflow, /schedule:\s*\n\s+- cron: "0 \*\/6 \* \* \*"/);
+  assert.equal(
+    fs.existsSync(legacyRefreshWorkflowPath),
+    false,
+    'The obsolete Netlify refresh workflow must not be restored',
+  );
+  assert.doesNotMatch(deployWorkflow, /NETLIFY_BUILD_HOOK/);
+});
+
+test('the production workflow generates data once with live drafts required', () => {
+  const dataStep = workflowStep('Build data');
+  const siteStep = workflowStep('Build site');
+
+  assert.match(dataStep, /run: npm run build:data\s/);
+  assert.match(dataStep, /GITHUB_TOKEN: \$\{\{ secrets\.GITHUB_TOKEN \}\}/);
+  assert.match(dataStep, /REQUIRE_LIVE_DRAFT_HIPS: "true"/);
+  assert.match(siteStep, /run: npm run build:app\s/);
+  assert.doesNotMatch(siteStep, /GITHUB_TOKEN/);
+  assert.equal((deployWorkflow.match(/run: npm run build:data\s/g) || []).length, 1);
+});