Skip to content

Commit a97a85b

Browse files
committed
refactor: use strings.Builder
Signed-off-by: mickychang9 <mickychang9@outlook.com>
1 parent ff28e21 commit a97a85b

4 files changed

Lines changed: 21 additions & 15 deletions

File tree

sdk/abi_decode.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -176,19 +176,20 @@ func (a Address) checksumEncode() string {
176176

177177
hash := hex.EncodeToString(Keccak256Hash([]byte(address)).Bytes())
178178

179-
ret := "0x"
179+
var ret strings.Builder
180+
ret.WriteString("0x")
180181
for i := 0; i < len(address); i++ {
181182
character := string(address[i])
182183

183184
num, _ := strconv.ParseInt(string(hash[i]), 16, 64)
184185
if num > 7 {
185-
ret += strings.ToUpper(character)
186+
ret.WriteString(strings.ToUpper(character))
186187
} else {
187-
ret += character
188+
ret.WriteString(character)
188189
}
189190
}
190191

191-
return ret
192+
return ret.String()
192193
}
193194

194195
func readAddr(b []byte) (Address, error) {

sdk/custom_fee_limit.go

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package hiero
22

3+
import "strings"
4+
35
import "github.com/hiero-ledger/hiero-sdk-go/v2/proto/services"
46

57
// SPDX-License-Identifier: Apache-2.0
@@ -83,13 +85,14 @@ func (feeLimit *CustomFeeLimit) toProtobuf() *services.CustomFeeLimit {
8385
}
8486

8587
func (feeLimit *CustomFeeLimit) String() string {
86-
customFeesStr := "["
88+
var customFeesStr strings.Builder
89+
customFeesStr.WriteString("[")
8790
for i, fee := range feeLimit.CustomFees {
8891
if i > 0 {
89-
customFeesStr += ", "
92+
customFeesStr.WriteString(", ")
9093
}
91-
customFeesStr += fee.String()
94+
customFeesStr.WriteString(fee.String())
9295
}
93-
customFeesStr += "]"
94-
return "CustomFeeLimit{PayerId: " + feeLimit.PayerId.String() + ", CustomFees: " + customFeesStr + "}"
96+
customFeesStr.WriteString("]")
97+
return "CustomFeeLimit{PayerId: " + feeLimit.PayerId.String() + ", CustomFees: " + customFeesStr.String() + "}"
9598
}

sdk/node_address.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ package hiero
44

55
import (
66
"strconv"
7+
"strings"
78

89
"github.com/hiero-ledger/hiero-sdk-go/v2/proto/services"
910
)
@@ -60,9 +61,9 @@ func (nodeAdd *NodeAddress) _ToProtobuf() *services.NodeAddress {
6061

6162
// String returns a string representation of the NodeAddress
6263
func (nodeAdd NodeAddress) String() string {
63-
Addresses := ""
64+
var Addresses strings.Builder
6465
for _, k := range nodeAdd.Addresses {
65-
Addresses += k.String()
66+
Addresses.WriteString(k.String())
6667
}
67-
return "NodeAccountId: " + nodeAdd.AccountID.String() + " " + Addresses + "\n" + "CertHash: " + string(nodeAdd.CertHash) + "\n" + "NodeId: " + strconv.FormatInt(nodeAdd.NodeID, 10) + "\n" + "PubKey: " + nodeAdd.PublicKey
68+
return "NodeAccountId: " + nodeAdd.AccountID.String() + " " + Addresses.String() + "\n" + "CertHash: " + string(nodeAdd.CertHash) + "\n" + "NodeId: " + strconv.FormatInt(nodeAdd.NodeID, 10) + "\n" + "PubKey: " + nodeAdd.PublicKey
6869
}

sdk/token_nft_allowance.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ package hiero
44

55
import (
66
"fmt"
7+
"strings"
78

89
"github.com/hiero-ledger/hiero-sdk-go/v2/proto/services"
910
"google.golang.org/protobuf/types/known/wrapperspb"
@@ -118,7 +119,7 @@ func (approval *TokenNftAllowance) String() string {
118119
var owner string
119120
var spender string
120121
var token string
121-
var serials string
122+
var serials strings.Builder
122123

123124
if approval.OwnerAccountID != nil {
124125
owner = approval.OwnerAccountID.String()
@@ -133,8 +134,8 @@ func (approval *TokenNftAllowance) String() string {
133134
}
134135

135136
for _, serial := range approval.SerialNumbers {
136-
serials += fmt.Sprintf("%d, ", serial)
137+
serials.WriteString(fmt.Sprintf("%d, ", serial))
137138
}
138139

139-
return fmt.Sprintf("OwnerAccountID: %s, SpenderAccountID: %s, TokenID: %s, Serials: %s, ApprovedForAll: %t", owner, spender, token, serials, approval.AllSerials)
140+
return fmt.Sprintf("OwnerAccountID: %s, SpenderAccountID: %s, TokenID: %s, Serials: %s, ApprovedForAll: %t", owner, spender, token, serials.String(), approval.AllSerials)
140141
}

0 commit comments

Comments
 (0)