Skip to content

Commit b7d212d

Browse files
committed
Re-enable fee_estimate_query example and remove mirror-sync sleeps
- Remove fee_estimate_query skip block from Taskfile.yml run-examples task - Remove waitForMirrorNodeSync() calls from sdk/fee_estimate_query_e2e_test.go - Remove mirrorSyncDelay constant and waitForMirrorNodeSync() helper function - Rely on waitForFeeEstimationServiceReady() readiness probe instead of arbitrary sleeps Fixes #1696 Signed-off-by: Mounil Kanakhara <mounilkankhara@gmail.com>
1 parent 9f36936 commit b7d212d

2 files changed

Lines changed: 0 additions & 33 deletions

File tree

Taskfile.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,6 @@ tasks:
1717
echo "Skipping $example"
1818
continue
1919
fi
20-
# fee_estimate_query is flaky on a fresh local mirror node.
21-
if [ "$dir_name" == "fee_estimate_query" ]; then
22-
echo "Skipping $example (mirror node sync flake)"
23-
continue
24-
fi
2520
if [ -d "$example" ]; then
2621
2722
pushd "$example" > /dev/null

sdk/fee_estimate_query_e2e_test.go

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ import (
2222
)
2323

2424
const (
25-
mirrorSyncDelay = 2 * time.Second
2625
feeEstimationProbeInterval = 5 * time.Second
2726
feeEstimationProbeTimeout = 10 * time.Minute
2827
)
@@ -32,10 +31,6 @@ var (
3231
feeEstimationReadyErr error
3332
)
3433

35-
func waitForMirrorNodeSync() {
36-
time.Sleep(mirrorSyncDelay)
37-
}
38-
3934
// waitForFeeEstimationServiceReady blocks until the mirror node's
4035
// FeeEstimationService can answer a known-good probe query. Re-issues
4136
// a fresh INTRINSIC estimate for a 1-hbar self-transfer every 5 seconds
@@ -110,7 +105,6 @@ func TestIntegrationFeeEstimateQueryTokenCreateTransaction(t *testing.T) {
110105
_, err = transaction.SignWithOperator(env.Client)
111106
require.NoError(t, err)
112107

113-
waitForMirrorNodeSync()
114108

115109
response, err := NewFeeEstimateQuery().
116110
SetTransaction(transaction).
@@ -137,8 +131,6 @@ func TestIntegrationFeeEstimateQueryTransferTransactionStateMode(t *testing.T) {
137131
_, err = transaction.SignWithOperator(env.Client)
138132
require.NoError(t, err)
139133

140-
waitForMirrorNodeSync()
141-
142134
response, err := NewFeeEstimateQuery().
143135
SetTransaction(transaction).
144136
SetMode(FeeEstimateModeState).
@@ -161,8 +153,6 @@ func TestIntegrationFeeEstimateQueryTransferTransactionIntrinsicMode(t *testing.
161153
FreezeWith(env.Client)
162154
require.NoError(t, err)
163155

164-
waitForMirrorNodeSync()
165-
166156
response, err := NewFeeEstimateQuery().
167157
SetTransaction(transaction).
168158
SetMode(FeeEstimateModeIntrinsic).
@@ -188,8 +178,6 @@ func TestIntegrationFeeEstimateQueryTransferTransactionDefaultModeIsIntrinsic(t
188178
_, err = transaction.SignWithOperator(env.Client)
189179
require.NoError(t, err)
190180

191-
waitForMirrorNodeSync()
192-
193181
query := NewFeeEstimateQuery().SetTransaction(transaction)
194182
require.Equal(t, FeeEstimateModeIntrinsic, query.GetMode())
195183

@@ -212,8 +200,6 @@ func TestIntegrationFeeEstimateQueryTokenMintTransaction(t *testing.T) {
212200
FreezeWith(env.Client)
213201
require.NoError(t, err)
214202

215-
waitForMirrorNodeSync()
216-
217203
response, err := NewFeeEstimateQuery().
218204
SetTransaction(transaction).
219205
SetMode(FeeEstimateModeIntrinsic).
@@ -239,8 +225,6 @@ func TestIntegrationFeeEstimateQueryTopicCreateTransaction(t *testing.T) {
239225
_, err = transaction.SignWithOperator(env.Client)
240226
require.NoError(t, err)
241227

242-
waitForMirrorNodeSync()
243-
244228
response, err := NewFeeEstimateQuery().
245229
SetTransaction(transaction).
246230
SetMode(FeeEstimateModeState).
@@ -267,8 +251,6 @@ func TestIntegrationFeeEstimateQueryContractCreateTransaction(t *testing.T) {
267251
_, err = transaction.SignWithOperator(env.Client)
268252
require.NoError(t, err)
269253

270-
waitForMirrorNodeSync()
271-
272254
response, err := NewFeeEstimateQuery().
273255
SetTransaction(transaction).
274256
SetMode(FeeEstimateModeState).
@@ -294,8 +276,6 @@ func TestIntegrationFeeEstimateQueryFileCreateTransaction(t *testing.T) {
294276
_, err = transaction.SignWithOperator(env.Client)
295277
require.NoError(t, err)
296278

297-
waitForMirrorNodeSync()
298-
299279
response, err := NewFeeEstimateQuery().
300280
SetTransaction(transaction).
301281
SetMode(FeeEstimateModeState).
@@ -318,8 +298,6 @@ func TestIntegrationFeeEstimateQueryFileAppendTransactionAggregatesChunks(t *tes
318298
FreezeWith(env.Client)
319299
require.NoError(t, err)
320300

321-
waitForMirrorNodeSync()
322-
323301
response, err := NewFeeEstimateQuery().
324302
SetTransaction(transaction).
325303
SetMode(FeeEstimateModeIntrinsic).
@@ -342,8 +320,6 @@ func TestIntegrationFeeEstimateQueryTopicMessageSubmitSingleChunk(t *testing.T)
342320
FreezeWith(env.Client)
343321
require.NoError(t, err)
344322

345-
waitForMirrorNodeSync()
346-
347323
response, err := NewFeeEstimateQuery().
348324
SetTransaction(transaction).
349325
SetMode(FeeEstimateModeIntrinsic).
@@ -366,8 +342,6 @@ func TestIntegrationFeeEstimateQueryTopicMessageSubmitMultipleChunk(t *testing.T
366342
FreezeWith(env.Client)
367343
require.NoError(t, err)
368344

369-
waitForMirrorNodeSync()
370-
371345
response, err := NewFeeEstimateQuery().
372346
SetTransaction(transaction).
373347
SetMode(FeeEstimateModeIntrinsic).
@@ -405,8 +379,6 @@ func TestIntegrationFeeEstimateQueryWithHighVolumeThrottle(t *testing.T) {
405379
_, err = transaction.SignWithOperator(env.Client)
406380
require.NoError(t, err)
407381

408-
waitForMirrorNodeSync()
409-
410382
response, err := NewFeeEstimateQuery().
411383
SetTransaction(transaction).
412384
SetMode(FeeEstimateModeIntrinsic).

0 commit comments

Comments
 (0)