Merge branch 'main' into cancelAirdrop

Author: aceppaluni

.github/scripts/__tests__/jest/post-comment.test.js

@@ -0,0 +1,107 @@
+// __tests__/jest/post-comment.test.js
+//
+// Run from .github/scripts:
+// npm run test:js -- post-comment.test.js
+
+const { postComment } = require('../../shared/helpers/pr-helpers');
+
+function createMockGithub({ shouldFail = false, errorMessage = 'API error' } = {}) {
+  return {
+    rest: {
+      issues: {
+        createComment: jest.fn(async () => {
+          if (shouldFail) {
+            throw new Error(errorMessage);
+          }
+          return { data: { id: 101 } };
+        }),
+      },
+    },
+  };
+}
+
+function createMockCore() {
+  return {
+    info: jest.fn(),
+    error: jest.fn(),
+    warning: jest.fn(),
+    setFailed: jest.fn(),
+  };
+}
+
+describe('postComment helper', () => {
+  test('happy path: returns true and logs info when createComment resolves', async () => {
+    const consoleLogSpy = jest.spyOn(console, 'log').mockImplementation(() => {});
+    const consoleErrorSpy = jest.spyOn(console, 'error').mockImplementation(() => {});
+
+    try {
+      const github = createMockGithub();
+      const core = createMockCore();
+      const owner = 'hiero-ledger';
+      const repo = 'hiero-sdk-python';
+      const prNumber = 123;
+      const body = 'Great work on this PR!';
+
+      const result = await postComment(github, owner, repo, prNumber, body, core);
+
+      expect(result).toBe(true);
+      expect(github.rest.issues.createComment).toHaveBeenCalledTimes(1);
+      expect(github.rest.issues.createComment).toHaveBeenCalledWith({
+        owner,
+        repo,
+        issue_number: prNumber,
+        body,
+      });
+      expect(core.info).toHaveBeenCalledTimes(1);
+      expect(core.info).toHaveBeenCalledWith(`Posted recommendation comment to PR #${prNumber}`);
+      expect(core.error).not.toHaveBeenCalled();
+      expect(consoleLogSpy).not.toHaveBeenCalled();
+      expect(consoleErrorSpy).not.toHaveBeenCalled();
+    } finally {
+      consoleLogSpy.mockRestore();
+      consoleErrorSpy.mockRestore();
+    }
+  });
+
+  test('failure path: returns false, logs error, and does not throw when createComment rejects', async () => {
+    const consoleLogSpy = jest.spyOn(console, 'log').mockImplementation(() => {});
+    const consoleErrorSpy = jest.spyOn(console, 'error').mockImplementation(() => {});
+
+    try {
+      const errorMessage = 'Network error: 500 Internal Server Error';
+      const github = createMockGithub({ shouldFail: true, errorMessage });
+      const core = createMockCore();
+      const owner = 'hiero-ledger';
+      const repo = 'hiero-sdk-python';
+      const prNumber = 456;
+      const body = 'Recommendation comment';
+
+      let result;
+      let thrownError = null;
+
+      try {
+        result = await postComment(github, owner, repo, prNumber, body, core);
+      } catch (err) {
+        thrownError = err;
+      }
+
+      expect(thrownError).toBeNull();
+      expect(result).toBe(false);
+      expect(github.rest.issues.createComment).toHaveBeenCalledTimes(1);
+      expect(github.rest.issues.createComment).toHaveBeenCalledWith({
+        owner,
+        repo,
+        issue_number: prNumber,
+        body,
+      });
+      expect(core.error).toHaveBeenCalledTimes(1);
+      expect(core.error).toHaveBeenCalledWith(`Failed to post comment: ${errorMessage}`);
+      expect(core.info).not.toHaveBeenCalled();
+      expect(consoleLogSpy).not.toHaveBeenCalled();
+      expect(consoleErrorSpy).not.toHaveBeenCalled();
+    } finally {
+      consoleLogSpy.mockRestore();
+      consoleErrorSpy.mockRestore();
+    }
+  });
+});

.github/scripts/shared/api/github-api.js

@@ -65,6 +65,18 @@ async function fetchIssuesBatch(github, repoConfig) {
   }
 }
 
+/**
+ * Returns the number of open issues currently assigned to `username` in the
+ * given repository. Pull requests are excluded because they do not consume
+ * assignment capacity. Returns null on API failure so callers can fail open.
+ *
+ * @param {object} params
+ * @param {import('@actions/github').GitHub} params.github
+ * @param {string} params.owner    - Repo owner.
+ * @param {string} params.repo     - Repo name.
+ * @param {string} params.username - GitHub login of the contributor.
+ * @returns {Promise<number|null>} Count of open issue assignments, or null on failure.
+ */
 async function getOpenAssignments({ github, owner, repo, username }) {
   try {
     const issues = await github.paginate(github.rest.issues.listForRepo, {
@@ -94,6 +106,14 @@ async function getOpenAssignments({ github, owner, repo, username }) {
  * Counts closed issues carrying `label` (in the given repo) assigned to
  * `username`. Returns null (rather than throwing) on unsafe input or API
  * error so callers can choose to fail open.
+ *
+ * @param {object} params
+ * @param {import('@actions/github').GitHub} params.github
+ * @param {string} params.owner    - Repo owner.
+ * @param {string} params.repo     - Repo name.
+ * @param {string} params.username - GitHub login of the contributor.
+ * @param {string} params.label    - Label string to filter by.
+ * @returns {Promise<number|null>} Issue count, or null on invalid input or API failure.
  */
 async function countCompletedIssuesWithLabel({ github, owner, repo, username, label }) {
   if (!isValidSearchToken(owner) || !isValidSearchToken(repo) || !isValidSearchToken(username)) {
@@ -133,12 +153,18 @@ async function countCompletedIssuesWithLabel({ github, owner, repo, username, la
 }
 
 /**
-
  * Determines whether a user has repository collaborator access.
  *
  * Repository owners are always considered collaborators.
  * GitHub returns 204 when the user is a collaborator and 404 otherwise.
  * Unexpected API failures are treated as non-collaborator access.
+ *
+ * @param {object} params
+ * @param {import('@actions/github').GitHub} params.github
+ * @param {string} params.owner    - Repo owner.
+ * @param {string} params.repo     - Repo name.
+ * @param {string} params.username - GitHub login to check.
+ * @returns {Promise<boolean>} True if the user is a collaborator, false otherwise.
  */
 async function isRepoCollaborator({ github, owner, repo, username }) {
   if (username === owner) {
@@ -176,16 +202,46 @@ async function isRepoCollaborator({ github, owner, repo, username }) {
   }
 }
 
+/**
+ * Posts a comment on an issue or pull request via the GitHub REST API.
+ * When `logLabel` is provided, logs the outcome to the console; when omitted,
+ * stays silent so the caller owns all logging. Re-throws any API error either
+ * way so callers can handle or propagate failures themselves.
+ *
+ * @param {object} params
+ * @param {import('@actions/github').GitHub} params.github
+ * @param {string} params.owner       - Repo owner.
+ * @param {string} params.repo        - Repo name.
+ * @param {number} params.issueNumber - Issue or PR number to comment on.
+ * @param {string} params.body        - Markdown body of the comment.
+ * @param {string} [logLabel]         - Optional human-readable label used in console output.
+ * @returns {Promise<void>}
+ * @throws {Error} Re-throws the Octokit error on API failure.
+ */
 async function postIssueComment({ github, owner, repo, issueNumber, body }, logLabel) {
   try {
     await github.rest.issues.createComment({ owner, repo, issue_number: issueNumber, body });
-    console.log(`[github-api] Posted comment: ${logLabel}`);
+    if (logLabel) {
+      console.log(`[github-api] Posted comment: ${logLabel}`);
+    }
   } catch (error) {
-    console.error(`[github-api] Failed to post comment (${logLabel}):`, { message: error.message });
+    if (logLabel) {
+      console.error(`[github-api] Failed to post comment (${logLabel}):`, { message: error.message });
+    }
     throw error;
   }
 }
 
+/**
+ * Fetches all comments on an issue or pull request, paginating automatically.
+ *
+ * @param {object} params
+ * @param {import('@actions/github').GitHub} params.github
+ * @param {string} params.owner       - Repo owner.
+ * @param {string} params.repo        - Repo name.
+ * @param {number} params.issueNumber - Issue or PR number.
+ * @returns {Promise<Array<object>>} Array of comment objects from the GitHub API.
+ */
 async function fetchAllComments({ github, owner, repo, issueNumber }) {
   return github.paginate(github.rest.issues.listComments, {
     owner,
@@ -195,6 +251,17 @@ async function fetchAllComments({ github, owner, repo, issueNumber }) {
   });
 }
 
+/**
+ * Assigns a contributor to an issue.
+ *
+ * @param {object} params
+ * @param {import('@actions/github').GitHub} params.github
+ * @param {string} params.owner       - Repo owner.
+ * @param {string} params.repo        - Repo name.
+ * @param {number} params.issueNumber - Issue number to assign.
+ * @param {string} params.username    - GitHub login of the contributor to assign.
+ * @returns {Promise<void>}
+ */
 async function assignIssue({
     github,
     owner,

.github/scripts/shared/config.js

@@ -58,7 +58,7 @@ const CONFIG = {
 
   // Maximum simultaneous assignments .
   assignmentLimits: {
-    [LEVEL_KEYS.GFI]: 2,
+    [LEVEL_KEYS.GFI]: 1,
     [LEVEL_KEYS.BEGINNER]: 2,
     [LEVEL_KEYS.INTERMEDIATE]: 2,
     [LEVEL_KEYS.ADVANCED]: 2,

.github/scripts/shared/helpers/pr-helpers.js

@@ -3,6 +3,7 @@
 // ---------------------------------------------------------------------------
 
 const { CONFIG } = require('../config');
+const { postIssueComment } = require('../api/github-api');
 
 /**
  * Extracts the first linked issue number from a PR body using closing keywords.
@@ -71,7 +72,9 @@ async function alreadyCommented(github, owner, repo, prNumber) {
  */
 async function postComment(github, owner, repo, prNumber, body, core) {
   try {
-    await github.rest.issues.createComment({ owner, repo, issue_number: prNumber, body });
+    // No logLabel: this wrapper owns logging (via core), matching the
+    // pre-consolidation log output exactly.
+    await postIssueComment({ github, owner, repo, issueNumber: prNumber, body });
     core.info(`Posted recommendation comment to PR #${prNumber}`);
     return true;
   } catch (error) {

.github/workflows/on-review.yml

@@ -45,7 +45,7 @@ jobs:
       - name: Checkout repository
         uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
         with:
-          ref: ${{ github.event.pull_request.base.sha || github.sha }}
+          ref: ${{ github.event.repository.default_branch }}
           persist-credentials: false
 
       - name: Run Add Reviewers as Assignees

.github/workflows/pr-check-primary-codeql.yml

@@ -42,7 +42,7 @@ jobs:
                   egress-policy: audit
 
             - name: Initialize CodeQL
-              uses: github/codeql-action/init@ff2f1c621b7f889edc0d3c761ac2e6a3f8cdb0dd # v4.37.7
+              uses: github/codeql-action/init@db488ddef3bf6cb639b32c2e9a7c0a7ea8271d28 # v4.37.8
               with:
                   languages: ${{ matrix.language }}
                   build-mode: ${{ matrix.build-mode }}
@@ -66,6 +66,6 @@ jobs:
               run: uv sync --frozen --all-groups --all-packages --all-extras
 
             - name: Perform CodeQL Analysis
-              uses: github/codeql-action/analyze@ff2f1c621b7f889edc0d3c761ac2e6a3f8cdb0dd # v4.37.7
+              uses: github/codeql-action/analyze@db488ddef3bf6cb639b32c2e9a7c0a7ea8271d28 # v4.37.8
               with:
                   category: "/language:${{matrix.language}}"

.github/workflows/pr-review-status-evaluator.yml

@@ -55,12 +55,11 @@ jobs:
         with:
           egress-policy: audit
 
-      - name: Checkout trusted evaluator scripts (PR base ref, not head)
+      - name: Checkout trusted evaluator scripts (default branch))
         uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
         with:
-          # For PR events, the trusted base branch; for workflow_dispatch,
-          # the (trusted) ref the workflow was dispatched from.
-          ref: ${{ github.event.pull_request.base.sha || github.sha }}
+          # Always check out trusted evaluator scripts from the repository default branch.
+          ref: ${{ github.event.repository.default_branch }}
           persist-credentials: false
           fetch-depth: 1
 

examples/account/account_create_transaction_create_with_alias.py

@@ -23,6 +23,7 @@
     Client,
     Hbar,
     PrivateKey,
+    ResponseCode,
 )
 
 
@@ -104,6 +105,9 @@ def create_account_with_ecdsa_alias(
 
     response = transaction.execute(client)
 
+    if response.status != ResponseCode.SUCCESS:
+        raise RuntimeError(f"Transaction failed with status: {ResponseCode(response.status).name}")
+
     # Safe retrieval of account ID
     new_account_id = response.account_id
     if new_account_id is None:

examples/account/account_create_transaction_with_fallback_alias.py

@@ -23,6 +23,7 @@
     Client,
     Hbar,
     PrivateKey,
+    ResponseCode,
 )
 
 
@@ -68,6 +69,10 @@ def create_account_with_fallback_alias(client: Client, account_private_key: Priv
     transaction = transaction.freeze_with(client).sign(account_private_key)
 
     response = transaction.execute(client)
+
+    if response.status != ResponseCode.SUCCESS:
+        raise RuntimeError(f"Transaction failed with status: {ResponseCode(response.status).name}")
+
     new_account_id = response.account_id
 
     if new_account_id is None:

examples/transaction/transfer_transaction_fungible.py

@@ -18,6 +18,7 @@
     CryptoGetAccountBalanceQuery,
     Hbar,
     PrivateKey,
+    ResponseCode,
     TokenAssociateTransaction,
     TokenCreateTransaction,
     TransferTransaction,
@@ -58,6 +59,9 @@ def create_account(client, operator_key):
             .set_initial_balance(Hbar.from_tinybars(100_000_000))
         )
         receipt = tx.freeze_with(client).sign(operator_key).execute(client)
+        if receipt.status != ResponseCode.SUCCESS:
+            raise RuntimeError(f"Transaction failed with status: {ResponseCode(receipt.status).name}")
+
         recipient_id = receipt.account_id
         print(f"✅ Success! Created a new recipient account with ID: {recipient_id}")
         return recipient_id, recipient_key
@@ -83,6 +87,9 @@ def create_token(client, operator_id, operator_key):
             .sign(operator_key)
         )
         token_receipt = token_tx.execute(client)
+        if token_receipt.status != ResponseCode.SUCCESS:
+            raise RuntimeError(f"Transaction failed with status: {ResponseCode(token_receipt.status).name}")
+
         token_id = token_receipt.token_id
 
         print(f"✅ Success! Created a token with Token ID: {token_id}")
@@ -103,7 +110,9 @@ def associate_token(client, recipient_id, recipient_key, token_id):
             .freeze_with(client)
             .sign(recipient_key)
         )
-        association_tx.execute(client)
+        receipt = association_tx.execute(client)
+        if receipt.status != ResponseCode.SUCCESS:
+            raise RuntimeError(f"Transaction failed with status: {ResponseCode(receipt.status).name}")
 
         print("✅ Success! Token association complete.")
     except Exception as e:
@@ -139,7 +148,10 @@ def transfer_transaction(client, operator_id, operator_key, recipient_id, token_
             .sign(operator_key)
         )
 
-        tx.execute(client)
+        receipt = tx.execute(client)
+        if receipt.status != ResponseCode.SUCCESS:
+            raise RuntimeError(f"Transaction failed with status: {ResponseCode(receipt.status).name}")
+
         print("✅ Success! Token transfer complete.\n")
 
     except Exception as e: