Merge branch 'main' into feat/tck-create-ethereum-transaction

Author: danielmarv

.github/scripts/__tests__/jest/issue-assign.test.js

@@ -13,6 +13,11 @@ jest.mock('../../shared/api/github-api', () => ({
   assignIssue: jest.fn(),
 }));
 
+jest.mock('../../shared/helpers/coderabbit-plan.js', () => ({
+  triggerCodeRabbitPlan: jest.fn(),
+  hasExistingCodeRabbitPlan: jest.fn(),
+}));
+
 jest.mock('../../shared/helpers/comment', () => ({
   buildAlreadyAssignedComment: jest.fn(() => 'already assigned'),
   buildGuardComment: jest.fn(() => 'guard comment'),
@@ -35,6 +40,11 @@ const { runAssignmentFlow } = require('../../shared/core/issue-assign');
 const githubApi = require('../../shared/api/github-api');
 const spam = require('../../shared/helpers/spam');
 
+const {
+  triggerCodeRabbitPlan,
+  hasExistingCodeRabbitPlan,
+} = require('../../shared/helpers/coderabbit-plan.js');
+
 function createContext(overrides = {}) {
   return {
     payload: {
@@ -86,6 +96,9 @@ beforeEach(() => {
   spam.isSpamBlockedLevel.mockReturnValue(false);
   spam.isSpamLimited.mockReturnValue(false);
   spam.getAssignmentLimit.mockReturnValue(5);
+
+  hasExistingCodeRabbitPlan.mockResolvedValue(false);
+  triggerCodeRabbitPlan.mockResolvedValue(true);
 });
 
 describe('runAssignmentFlow - validation', () => {
@@ -597,8 +610,9 @@ describe('runAssignmentFlow - assignment', () => {
     expect(githubApi.assignIssue).not.toHaveBeenCalled();
   });
 
-  test('assigns issue when all checks pass', async () => {
+  test('assigns issue and triggers CodeRabbit when all checks pass', async () => {
     githubApi.getOpenAssignments.mockResolvedValue(0);
+    hasExistingCodeRabbitPlan.mockResolvedValue(false);
 
     const github = createGithub();
     const context = createContext();
@@ -613,8 +627,54 @@ describe('runAssignmentFlow - assignment', () => {
       username: 'parv',
     });
 
+    expect(hasExistingCodeRabbitPlan).toHaveBeenCalledWith(
+      github,
+      'hiero-ledger',
+      'hiero-sdk-python',
+      10
+    );
+
+    expect(triggerCodeRabbitPlan).toHaveBeenCalledWith(
+      github,
+      'hiero-ledger',
+      'hiero-sdk-python',
+      context.payload.issue
+    );
+
     expect(githubApi.postIssueComment).not.toHaveBeenCalled();
   });
+
+  test('does not trigger CodeRabbit when a plan already exists', async () => {
+    githubApi.getOpenAssignments.mockResolvedValue(0);
+    hasExistingCodeRabbitPlan.mockResolvedValue(true);
+
+    const github = createGithub();
+    const context = createContext();
+
+    await runAssignmentFlow({ github, context });
+
+    expect(githubApi.assignIssue).toHaveBeenCalled();
+    expect(hasExistingCodeRabbitPlan).toHaveBeenCalled();
+    expect(triggerCodeRabbitPlan).not.toHaveBeenCalled();
+  });
+
+  test('does not fail assignment when CodeRabbit trigger fails', async () => {
+    githubApi.getOpenAssignments.mockResolvedValue(0);
+    hasExistingCodeRabbitPlan.mockResolvedValue(false);
+    triggerCodeRabbitPlan.mockRejectedValue(
+      new Error('CodeRabbit API failed')
+    );
+
+    const github = createGithub();
+    const context = createContext();
+
+    await expect(
+      runAssignmentFlow({ github, context })
+    ).resolves.not.toThrow();
+
+    expect(githubApi.assignIssue).toHaveBeenCalled();
+    expect(triggerCodeRabbitPlan).toHaveBeenCalled();
+  });
 });
 
 describe('runAssignmentFlow - error handling', () => {
@@ -676,31 +736,21 @@ describe('runAssignmentFlow - error handling', () => {
     expect(githubApi.assignIssue).toHaveBeenCalled();
   });
 
-  test('propagates post comment errors', async () => {
-    githubApi.postIssueComment.mockRejectedValue(
-      new Error('Comment failed')
+  test('does not trigger CodeRabbit when assignment fails', async () => {
+    githubApi.assignIssue.mockRejectedValue(
+      new Error('Assignment failed')
     );
 
-    githubApi.countCompletedIssuesWithLabel.mockResolvedValue(0);
-
     const github = createGithub();
+    const context = createContext();
 
-    const context = createContext({
-      issue: {
-        number: 42,
-        assignees: [],
-        labels: [
-          {
-            name: 'skill: intermediate',
-          },
-        ],
-      },
+    await runAssignmentFlow({
+      github,
+      context,
     });
 
-    await expect(
-      runAssignmentFlow({ github, context })
-    ).rejects.toThrow('Comment failed');
-
-    expect(githubApi.assignIssue).not.toHaveBeenCalled();
+    expect(githubApi.assignIssue).toHaveBeenCalled();
+    expect(hasExistingCodeRabbitPlan).not.toHaveBeenCalled();
+    expect(triggerCodeRabbitPlan).not.toHaveBeenCalled();
   });
 });

.github/scripts/shared/core/issue-assign.js

@@ -52,6 +52,11 @@ const {
   getAssignmentLimit,
 } = require('../helpers/spam.js');
 
+const {
+  triggerCodeRabbitPlan,
+  hasExistingCodeRabbitPlan,
+} = require('../helpers/coderabbit-plan.js');
+
 /**
  * Returns true if a comment contains the `/assign` command.
  *
@@ -281,14 +286,46 @@ async function runAssignmentFlow({ github, context }) {
       username: commenter,
     });
   } catch (error) {
-    console.error("[assign-bot] Failed to assign issue:", {
+    console.error('[assign-bot] Failed to assign issue:', {
       message: error.message,
     });
+    return;
   }
-  return;
 
-}
+  // Trigger CodeRabbit after successful assignment
+  try {
+    const planExists = await hasExistingCodeRabbitPlan(
+      github,
+      owner,
+      repoName,
+      issueNumber
+    );
 
+    if (planExists === false) {
+      await triggerCodeRabbitPlan(
+      github,
+      owner,
+      repoName,
+      issue
+    );
+    } else if (planExists === true) {
+        console.log(
+        `[assign-bot] CodeRabbit plan already exists for #${issueNumber}`
+      );
+    } else {
+      console.log(
+      `[assign-bot] Unable to determine whether a CodeRabbit plan exists for #${issueNumber}. Skipping trigger.`
+      );
+    }
+  } catch (error) {
+    console.error('[assign-bot] CodeRabbit plan trigger failed:', {
+      message: error.message,
+      issueNumber,
+    });
+  }
+
+  return;
+}
 module.exports = {
   runAssignmentFlow,
 };

…ithub/scripts/coderabbit_plan_trigger.js …cripts/shared/helpers/coderabbit-plan.js.github/scripts/coderabbit_plan_trigger.js renamed to .github/scripts/shared/helpers/coderabbit-plan.js .github/scripts/coderabbit_plan_trigger.js renamed to .github/scripts/shared/helpers/coderabbit-plan.js

@@ -1,7 +1,7 @@
 // Script to trigger CodeRabbit plan for all difficulty-labeled issues (including GFI)
 
 const CODERABBIT_MARKER = '<!-- CodeRabbit Plan Trigger -->';
-const { DIFFICULTY_LABELS } = require('./shared/labels.js');
+const { DIFFICULTY_LABELS } = require('../labels.js');
 
 async function triggerCodeRabbitPlan(github, owner, repo, issue, marker = CODERABBIT_MARKER) {
   const comment = `${marker} @coderabbitai plan`;
@@ -73,7 +73,7 @@ async function hasExistingCodeRabbitPlan(github, owner, repo, issueNumber) {
       issueNumber,
     });
     // Return false to allow plan trigger attempt (fail-open for better UX)
-    return false;
+    return null;
   }
 }
 
@@ -110,10 +110,18 @@ function logSummary(owner, repo, issue) {
 }
 
 // Main workflow handler (default export for workflow usage)
-async function main({ github, context }) {
+async function triggerCodeRabbitPlanForIssue({ github, context }) {
   try {
     const { owner, repo } = context.repo;
-    const { issue: eventIssue, label } = context.payload;
+
+    const payload = context?.payload;
+
+    if (!payload) {
+      console.log('No event payload');
+      return;
+    }
+
+    const { issue: eventIssue, label } = payload;
 
     // Validations
     if (!eventIssue?.number) return console.log('No issue in payload');
@@ -149,10 +157,9 @@ async function main({ github, context }) {
   }
 }
 
-// Default export for workflow usage: await script({ github, context })
-module.exports = main;
-
-// Named exports for reuse by other scripts (e.g., GFI assignment bot)
-module.exports.triggerCodeRabbitPlan = triggerCodeRabbitPlan;
-module.exports.hasExistingCodeRabbitPlan = hasExistingCodeRabbitPlan;
-module.exports.CODERABBIT_MARKER = CODERABBIT_MARKER;
+module.exports = {
+  triggerCodeRabbitPlan,
+  hasExistingCodeRabbitPlan,
+  CODERABBIT_MARKER,
+  triggerCodeRabbitPlanForIssue,
+};

.github/workflows/approved-issues.yml

@@ -63,5 +63,5 @@ jobs:
         uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0
         with:
           script: |
-            const script = require('./.github/scripts/coderabbit_plan_trigger.js');
-            await script({ github, context });
+            const { triggerCodeRabbitPlanForIssue } = require('./.github/scripts/shared/helpers/coderabbit-plan.js');
+            await triggerCodeRabbitPlanForIssue({ github, context });

src/hiero_sdk_python/consensus/topic_message_submit_transaction.py

@@ -4,12 +4,12 @@
 
 from hiero_sdk_python.channels import _Channel
 from hiero_sdk_python.consensus.topic_id import TopicId
-from hiero_sdk_python.crypto.private_key import PrivateKey
 from hiero_sdk_python.executable import _Method
 from hiero_sdk_python.hapi.services import consensus_submit_message_pb2, transaction_pb2
 from hiero_sdk_python.hapi.services.schedulable_transaction_body_pb2 import (
     SchedulableTransactionBody,
 )
+from hiero_sdk_python.schedule.schedule_create_transaction import ScheduleCreateTransaction
 from hiero_sdk_python.transaction.chunked_transaction import ChunkedTransaction
 from hiero_sdk_python.transaction.custom_fee_limit import CustomFeeLimit
 
@@ -107,33 +107,6 @@ def set_message(self, message: bytes | str) -> TopicMessageSubmitTransaction:
         self._total_chunks = self.get_required_chunks()
         return self
 
-    def set_chunk_size(self, chunk_size: int) -> TopicMessageSubmitTransaction:
-        """
-        Set maximum chunk size in bytes.
-
-        Args:
-            chunk_size (int): The size of each chunk in bytes.
-
-        Returns:
-            TopicMessageSubmitTransaction: This transaction instance (for chaining).
-        """
-        super().set_chunk_size(chunk_size)
-        self._total_chunks = self.get_required_chunks()
-        return self
-
-    def set_max_chunks(self, max_chunks: int) -> TopicMessageSubmitTransaction:
-        """
-        Set maximum allowed chunks.
-
-        Args:
-            max_chunks (int): The maximum number of chunks allowed.
-
-        Returns:
-            TopicMessageSubmitTransaction: This transaction instance (for chaining).
-        """
-        super().set_max_chunks(max_chunks)
-        return self
-
     def set_custom_fee_limits(self, custom_fee_limits: list[CustomFeeLimit]) -> TopicMessageSubmitTransaction:
         """
         Sets the maximum custom fees that the user is willing to pay for the message.
@@ -186,27 +159,26 @@ def _build_proto_body(self) -> consensus_submit_message_pb2.ConsensusSubmitMessa
         if not self.message:
             raise ValueError("Missing required fields: message.")
 
-        content = self._message_as_bytes()
+        contents = self._message_as_bytes()
 
-        start_index = self._current_chunk_index * self.chunk_size
-        end_index = min(start_index + self.chunk_size, len(content))
-        chunk_content = content[start_index:end_index]
+        if self._total_chunks > 1 and self._current_chunk_index is not None:
+            chunk_info = consensus_submit_message_pb2.ConsensusMessageChunkInfo(
+                initialTransactionID=self._initial_transaction_id._to_proto(),
+                total=self._total_chunks,
+                number=self._current_chunk_index + 1,
+            )
 
-        body = consensus_submit_message_pb2.ConsensusSubmitMessageTransactionBody(
-            topicID=self.topic_id._to_proto() if self.topic_id else None, message=chunk_content
-        )
+            chunk_content = self._current_chunk_slice(contents)
 
-        # Multi-chunk metadata
-        if self._total_chunks > 1:
-            body.chunkInfo.CopyFrom(
-                consensus_submit_message_pb2.ConsensusMessageChunkInfo(
-                    initialTransactionID=self._initial_transaction_id._to_proto(),
-                    total=self._total_chunks,
-                    number=self._current_chunk_index + 1,
-                )
+            return consensus_submit_message_pb2.ConsensusSubmitMessageTransactionBody(
+                topicID=self.topic_id._to_proto() if self.topic_id else None,
+                message=chunk_content,
+                chunkInfo=chunk_info,
             )
 
-        return body
+        return consensus_submit_message_pb2.ConsensusSubmitMessageTransactionBody(
+            topicID=self.topic_id._to_proto() if self.topic_id else None, message=contents
+        )
 
     def build_transaction_body(self) -> transaction_pb2.TransactionBody:
         """
@@ -220,6 +192,18 @@ def build_transaction_body(self) -> transaction_pb2.TransactionBody:
         transaction_body.consensusSubmitMessage.CopyFrom(consensus_submit_message_body)
         return transaction_body
 
+    def schedule(self) -> ScheduleCreateTransaction:
+        """
+        Converts this transaction into a scheduled transaction.
+        """
+        if self.message is not None and len(self._message_as_bytes()) > self.chunk_size:
+            raise RuntimeError(
+                f"Cannot schedule TopicMessageSubmitTransaction because the message exceeds "
+                f"the maximum chunk size of {self.chunk_size} bytes"
+            )
+
+        return super().schedule()
+
     def build_scheduled_body(self) -> SchedulableTransactionBody:
         """
         Builds the scheduled transaction body for this topic message submit transaction.
@@ -243,16 +227,3 @@ def _get_method(self, channel: _Channel) -> _Method:
             _Method: The method object with bound transaction execution.
         """
         return _Method(transaction_func=channel.topic.submitMessage, query_func=None)
-
-    def sign(self, private_key: PrivateKey) -> TopicMessageSubmitTransaction:
-        """
-        Signs the transaction using the provided private key.
-
-        Args:
-            private_key (PrivateKey): The private key to sign the transaction with.
-
-        Returns:
-            TopicMessageSubmitTransaction: This transaction instance (for chaining).
-        """
-        super().sign(private_key)
-        return self