Merge branch 'main' into feat/sync-issue-labels

Signed-off-by: cheese-cakee <farzanaman99@gmail.com>

Author: cheese-cakee

.coderabbit.yaml

@@ -1249,12 +1249,12 @@ reviews:
         2. Extract the module name before `_pb2`
            (e.g. `transaction_record` from `transaction_record_pb2`)
         3. Build the canonical URL:
-           `https://github.com/hashgraph/hedera-protobufs/blob/v0.66.0/<path>/<module>.proto`
+           `https://github.com/hashgraph/hedera-protobufs/blob/v0.72.0-rc.2/<path>/<module>.proto`
 
         **Example:**
         ```
         Import:  from hiero_sdk_python.hapi.services import transaction_record_pb2
-        Schema:  https://github.com/hashgraph/hedera-protobufs/blob/v0.66.0/services/transaction_record.proto
+        Schema:  https://github.com/hashgraph/hedera-protobufs/blob/v0.72.0-rc.2/services/transaction_record.proto
         ```
 
         ### Step 3 — Compare the SDK class against the proto schema
@@ -1816,7 +1816,7 @@ reviews:
         - Flag the **missing override** in `TopicMessageSubmitTransaction` as **MAJOR**
           if the base-class default is not appropriate for message submission, or add a
           comment confirming the base-class value is intentional.
-        - Flag any value that deviates from the table above without a comment as **MAJOR**.
+        - Flag any value that deviates from sibling-class defaults as **MAJOR**.
 
         #### 5c) General fee/limit logic
         - Confirm any fee/max payment logic is consistent and does not allow unintended
@@ -1850,6 +1850,102 @@ reviews:
     - path: "src/hiero_sdk_python/crypto/**/*.py"
       instructions: *crypto_review_instructions
 
+    - path: "src/hiero_sdk_python/account/**/*.py"
+      instructions: |
+        You are reviewing Python files in the `src/hiero_sdk_python/account/` directory.
+        These files implement account-related transactions, queries, and data types for the Hiero SDK.
+
+        > Note: Protobuf schema alignment (field names, types, oneof, bytes normalization,
+        > repeated defaults, and canonical `.proto` URL derivation) is already enforced by
+        > the global `src/hiero_sdk_python/**/*.py` instruction. Do NOT re-run those checks
+        > here — focus exclusively on the account-domain concerns below.
+
+        ---
+
+        ## Review priorities (highest → lowest)
+
+        ### 1) Protobuf correctness (must-not-break)
+        - Validate field names, field types, and field numbers +
+          repeated/optional semantics against the canonical `.proto` schema.
+        - Ensure `_to_proto` / `_from_proto` set the correct oneof branches
+          and do not drop fields.
+        - Treat silent coercions, defaulting, or ignored exceptions as
+          **BLOCKER** if they could change what is signed or sent.
+
+        ### 2) AccountId — alias / EVM address handling
+        `AccountId` has three identity modes: numeric `num`, `alias_key`,
+        and `evm_address`. Verify `_from_proto`/`_to_proto` symmetry across
+        all three. `__hash__` only covers `(shard, realm, num)` — alias-only
+        IDs with `num=0` can collide in dicts/sets. **MAJOR** if broken.
+
+        ### 3) Allowance mutation paths
+        When modifying existing `TokenNftAllowance` entries, mutation path and
+        append path must set `approved_for_all` to the same intended value.
+        `None` passed to typed arguments like `amount` must raise, not silently
+        produce zero. **MAJOR**.
+
+        ### 4) Errors & API ergonomics
+        - Errors should be actionable and consistent; avoid swallowing or
+          printing RPC/precheck errors.
+        - Ambiguous exceptions or inconsistent return types are **MINOR** /
+          **MAJOR** depending on impact.
+
+        ---
+
+        ## ARCHITECTURAL INVARIANTS (stable)
+        These describe what must always be true, regardless of code changes.
+        They are ordered by severity.
+
+        1. **Falsy-guard trap on optional integers** — Fields like
+          `staked_node_id` where `0` is a valid value must never use
+          `if field:` guards. Use `if field is not None:`. **BLOCKER**
+          if it silently drops valid data.
+
+        2. **Mutable default arguments** — Flag any mutable object
+          (`list`, `dict`, `set`, or non-frozen class instance) used as
+          a default parameter in `__init__`. Default to `None` and assign
+          in the body. **MAJOR**.
+
+          Exception: frozen/immutable types are safe as defaults and must
+          NOT be flagged. This includes `@dataclass(frozen=True)` classes
+          (e.g., `Duration`), tuples, frozensets, and primitives (int, str,
+          bool, None).
+
+        3. **Library-safe error handling** — No bare `except Exception`
+          with `print`/`traceback` in library code. Callers cannot
+          suppress stdout side effects. **MAJOR**.
+
+        ---
+
+        ## KNOWN INSTANCES (transient — remove when fixed)
+
+        _Check if these still exist before flagging._
+
+        - `AccountRecordsQuery._make_request`: bare except + print
+          → violates invariant #3
+        - `AccountId.from_string`: verify `from e` chaining not removed
+          → exception context silently lost if removed
+        - `AccountInfo._to_proto`: falsy guard on `staked_node_id`
+          → violates invariant #1
+
+        ---
+
+        ## Test expectations
+        PRs modifying account code should have tests covering:
+        - AccountId round-trip across all three identity modes
+        - `__hash__` behavior for alias-only IDs with `num=0`
+        - Invalid/None arguments raising errors, not silently defaulting
+        - `_from_proto(_to_proto(x))` field round-trip equality
+        
+        ---
+
+        ## Severity labels
+        Use exactly these labels in all findings:
+        - **BLOCKER** — must be fixed before merge; wire-format, signing, or data-loss risk
+        - **MAJOR** — should be fixed; correctness or significant usability issue
+        - **MINOR** — should be fixed; low-risk correctness or ergonomics issue
+        - **NIT** — optional; style, naming, or documentation only
+
 chat:
   art: false # Don't draw ASCII art (false)
   auto_reply: false # Don't allow bot to converse (spammy)

.github/ISSUE_TEMPLATE/01_good_first_issue_candidate.yml

@@ -36,7 +36,7 @@ body:
       label: 🆕🐥 Newcomer Friendly
       description: Who is this issue for?
       value: |
-        This **[Good First Issue](https://github.com/hiero-ledger/hiero-sdk-python/issues?q=is%3Aissue%20state%3Aopen%20label%3A%22Good%20First%20Issue%22%20no%3Aassignee)** is a guided, well-scoped task intended for new contributors to the Hiero Python SDK.
+        This **[Good First Issue](https://github.com/hiero-ledger/hiero-sdk-python/issues?q=is%3Aissue%20state%3Aopen%20label%3A%22Good%20First%20Issue%22%20no%3Aassignee)** is a guided, well-scoped task intended for new human contributors to the Hiero Python SDK.
 
         #### What you’ll do
         - ✅ understand how the repository is structured
@@ -269,7 +269,7 @@ body:
 
         - [ ] **Connect** origin with upstream: [Guide](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/training/workflow/03_staying_in_sync.md)
 
-        - [ ] **Install Packages** and protobufs: [Guide](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/training/setup/02_installing_hiero_python_sdk.md) (or [Windows Setup Guide](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/training/setup/setup_windows.md) for Windows users)
+        - [ ] **Install Packages** and protobufs: [Guide](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/training/setup/02_installing_hiero_python_sdk.md) (or [Windows Setup Guide](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/setup_windows.md) for Windows users)
 
         - [ ] **Sync Main** pull any recent upstream changes: [Guide](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/rebasing.md)
 
@@ -394,12 +394,7 @@ body:
       label: 🤖 AI usage guidelines
       description: Guidance on using AI tools responsibly for this issue.
       value: |
-        You’re welcome to use AI tools while working on this issue.
-
-        Many contributors do — especially for:
-        - understanding unfamiliar code
-        - drafting small refactors
-        - sanity-checking approaches
+        Humans are welcome to use AI tools while working on this issue but we do not accept AI bot-authored PRs.
 
         **Use AI responsibly:**
         - review suggestions carefully

.github/ISSUE_TEMPLATE/02_good_first_issue.yml

@@ -20,7 +20,7 @@ body:
       label: 🆕🐥 Newcomer Friendly
       description: Who is this issue for?
       value: |
-        This **[Good First Issue](https://github.com/hiero-ledger/hiero-sdk-python/issues?q=is%3Aissue%20state%3Aopen%20label%3A%22Good%20First%20Issue%22%20no%3Aassignee)** is a guided, well-scoped task intended for new contributors to the Hiero Python SDK.
+        This **[Good First Issue](https://github.com/hiero-ledger/hiero-sdk-python/issues?q=is%3Aissue%20state%3Aopen%20label%3A%22Good%20First%20Issue%22%20no%3Aassignee)** is a guided, well-scoped task intended for new human contributors to the Hiero Python SDK.
 
         #### What you’ll do
         - ✅ understand how the repository is structured
@@ -253,7 +253,7 @@ body:
 
         - [ ] **Connect** origin with upstream: [Guide](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/training/workflow/03_staying_in_sync.md)
 
-        - [ ] **Install Packages** and protobufs: [Guide](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/training/setup/02_installing_hiero_python_sdk.md) (or [Windows Setup Guide](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/training/setup/setup_windows.md) for Windows users)
+        - [ ] **Install Packages** and protobufs: [Guide](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/training/setup/02_installing_hiero_python_sdk.md) (or [Windows Setup Guide](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/setup_windows.md) for Windows users)
 
         - [ ] **Sync Main** pull any recent upstream changes: [Guide](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/rebasing.md)
 
@@ -378,12 +378,7 @@ body:
       label: 🤖 AI usage guidelines
       description: Guidance on using AI tools responsibly for this issue.
       value: |
-        You’re welcome to use AI tools while working on this issue.
-
-        Many contributors do — especially for:
-        - understanding unfamiliar code
-        - drafting small refactors
-        - sanity-checking approaches
+        Humans are welcome to use AI tools while working on this issue but we do not accept AI bot-authored PRs.
 
         **Use AI responsibly:**
         - review suggestions carefully

.github/scripts/bot-intermediate-assignment.js

@@ -6,7 +6,7 @@ const EXEMPT_PERMISSION_LEVELS = (process.env.INTERMEDIATE_EXEMPT_PERMISSIONS ||
   .map((entry) => entry.trim().toLowerCase())
   .filter(Boolean);
 const DRY_RUN = /^true$/i.test(process.env.DRY_RUN || '');
-const REQUIRED_BEGINNER_ISSUE_COUNT = 0 ;
+const REQUIRED_BEGINNER_ISSUE_COUNT = 1 ;
 
 function isSafeSearchToken(value) {
   return typeof value === 'string' && /^[a-zA-Z0-9._/-]+$/.test(value);