Skip to content

Commit e0225bf

Browse files
authored
Merge branch 'main' into unpause-token
2 parents 39f17e0 + 9c28077 commit e0225bf

9 files changed

Lines changed: 30 additions & 15 deletions

.coderabbit.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1249,12 +1249,12 @@ reviews:
12491249
2. Extract the module name before `_pb2`
12501250
(e.g. `transaction_record` from `transaction_record_pb2`)
12511251
3. Build the canonical URL:
1252-
`https://github.com/hashgraph/hedera-protobufs/blob/v0.72.0-rc.2/<path>/<module>.proto`
1252+
`https://github.com/hashgraph/hedera-protobufs/blob/v0.76.1/<path>/<module>.proto`
12531253
12541254
**Example:**
12551255
```
12561256
Import: from hiero_sdk_python.hapi.services import transaction_record_pb2
1257-
Schema: https://github.com/hashgraph/hedera-protobufs/blob/v0.72.0-rc.2/services/transaction_record.proto
1257+
Schema: https://github.com/hashgraph/hedera-protobufs/blob/v0.76.1/services/transaction_record.proto
12581258
```
12591259
12601260
### Step 3 — Compare the SDK class against the proto schema

.github/workflows/pr-check-primary-codeql.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ jobs:
4242
egress-policy: audit
4343

4444
- name: Initialize CodeQL
45-
uses: github/codeql-action/init@db488ddef3bf6cb639b32c2e9a7c0a7ea8271d28 # v4.37.8
45+
uses: github/codeql-action/init@cdf488f595d80d6e07e03d4674febd5ab45fa938 # v4.37.9
4646
with:
4747
languages: ${{ matrix.language }}
4848
build-mode: ${{ matrix.build-mode }}
@@ -66,6 +66,6 @@ jobs:
6666
run: uv sync --frozen --all-groups --all-packages --all-extras
6767

6868
- name: Perform CodeQL Analysis
69-
uses: github/codeql-action/analyze@db488ddef3bf6cb639b32c2e9a7c0a7ea8271d28 # v4.37.8
69+
uses: github/codeql-action/analyze@cdf488f595d80d6e07e03d4674febd5ab45fa938 # v4.37.9
7070
with:
7171
category: "/language:${{matrix.language}}"

.github/workflows/pr-check-secondary-examples.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ jobs:
7777
installMirrorNode: true
7878
soloVersion: v0.79.1
7979
mirrorNodeVersion: v0.153.0
80-
hieroVersion: v0.73.0
80+
hieroVersion: v0.76.1
8181

8282
- name: Run Examples
8383
env:

.github/workflows/pr-check-secondary-unit-integration-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ jobs:
134134
installMirrorNode: true
135135
soloVersion: v0.79.1
136136
mirrorNodeVersion: v0.153.0
137-
hieroVersion: v0.73.0
137+
hieroVersion: v0.76.1
138138

139139
- name: Run integration tests
140140
id: integration

examples/nodes/node_create_transaction.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,10 @@ def node_create():
6666

6767
# Node account ID - this should be an existing account
6868
# that will be associated with the node
69+
node_account_key = PrivateKey.generate_ecdsa()
6970
account_id = (
7071
AccountCreateTransaction()
71-
.set_key_without_alias(PrivateKey.generate_ecdsa())
72+
.set_key_without_alias(node_account_key)
7273
.freeze_with(client)
7374
.execute(client)
7475
.account_id
@@ -103,6 +104,7 @@ def node_create():
103104
.set_decline_reward(True)
104105
.freeze_with(client)
105106
.sign(admin_key) # Sign with the admin key
107+
.sign(node_account_key) # Sign with the node account key
106108
.execute(client)
107109
)
108110

examples/nodes/node_delete_transaction.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,10 @@ def create_node(client):
6565
"""Create a node on the network and return its ID and admin key."""
6666
# Node account ID - this should be an existing account
6767
# that will be associated with the node
68-
account_id = account_id = (
68+
node_account_key = PrivateKey.generate_ecdsa()
69+
account_id = (
6970
AccountCreateTransaction()
70-
.set_key_without_alias(PrivateKey.generate_ecdsa())
71+
.set_key_without_alias(node_account_key)
7172
.freeze_with(client)
7273
.execute(client)
7374
.account_id
@@ -102,6 +103,7 @@ def create_node(client):
102103
.set_decline_reward(True)
103104
.freeze_with(client)
104105
.sign(admin_key) # Sign with the admin key
106+
.sign(node_account_key) # Sign with the node account key
105107
.execute(client)
106108
)
107109

examples/nodes/node_update_transaction.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ def setup_client():
6161
return client
6262

6363

64-
def create_node(client, account_id):
64+
def create_node(client, account_id, node_account_private_key):
6565
"""Create a node on the network and return its ID and admin key."""
6666
# Node description
6767
description = "Example node"
@@ -92,6 +92,7 @@ def create_node(client, account_id):
9292
.set_decline_reward(True)
9393
.freeze_with(client)
9494
.sign(admin_key) # Sign with the admin key
95+
.sign(node_account_private_key) # Sign with the node account key
9596
.execute(client)
9697
)
9798

@@ -168,7 +169,7 @@ def node_update():
168169
)
169170

170171
# Create a new node and get its ID and admin key
171-
node_id, admin_key = create_node(client, node_account_id)
172+
node_id, admin_key = create_node(client, node_account_id, node_account_private_key)
172173

173174
# Update the newly created node with modified parameters
174175
update_node(client, node_account_id, node_account_private_key, node_id, admin_key)

generate_proto.py

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
from urllib.parse import urlparse
3535

3636

37-
VERSION = "v0.73.0"
37+
VERSION = "v0.76.1"
3838
SOURCES = [
3939
{
4040
"name": "hedera-protobufs",
@@ -55,6 +55,13 @@
5555
OUTPUT_DIR = "src/hiero_sdk_python/hapi"
5656
CACHE_DIR = ".protos"
5757

58+
# Protos that must be skipped during compilation as they are
59+
# not used by the SDK and have broken imports that cannot be resolved
60+
61+
EXCLUDED_PROTOS = {
62+
"blocks/publish_stream_request_bytes.proto",
63+
}
64+
5865
# Map common broken imports in mirror/platform proto
5966
REPLACEMENTS = {
6067
'import "basic_types.proto";': 'import "services/basic_types.proto";',
@@ -169,7 +176,9 @@ def run_protoc(proto_root: Path, output_root: Path) -> None:
169176
from grpc_tools import protoc
170177

171178
google_include = str(Path(grpc_tools.__file__).parent / "_proto")
172-
all_protos = [p.as_posix() for p in proto_root.rglob("*.proto")]
179+
all_protos = [
180+
p.as_posix() for p in proto_root.rglob("*.proto") if p.relative_to(proto_root).as_posix() not in EXCLUDED_PROTOS
181+
]
173182

174183
args = [
175184
"protoc",

tests/integration/associated_registered_nodes_e2e_test.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,10 @@ def _setup_client():
3535

3636
def _create_consensus_node(client, admin_key, associated_ids=None):
3737
"""Helper: create a consensus node with optional associated_registered_nodes."""
38+
node_account_key = PrivateKey.generate_ecdsa()
3839
account_id = (
3940
AccountCreateTransaction()
40-
.set_key_without_alias(PrivateKey.generate_ecdsa())
41+
.set_key_without_alias(node_account_key)
4142
.freeze_with(client)
4243
.execute(client)
4344
.account_id
@@ -61,7 +62,7 @@ def _create_consensus_node(client, admin_key, associated_ids=None):
6162
if associated_ids is not None:
6263
tx.set_associated_registered_nodes(associated_ids)
6364

64-
receipt = tx.freeze_with(client).sign(admin_key).execute(client)
65+
receipt = tx.freeze_with(client).sign(admin_key).sign(node_account_key).execute(client)
6566
assert receipt.status == ResponseCode.SUCCESS, f"Node create failed: {ResponseCode(receipt.status).name}"
6667
return receipt.node_id
6768

0 commit comments

Comments
 (0)