chore:added review changes

Signed-off-by: Manish Dait <daitmanish88@gmail.com>

Author: manishdait

src/hiero_sdk_python/transaction/transaction_response.py

@@ -45,16 +45,17 @@ def get_receipt_query(self, validate_status: bool = False, client: Client | None
 
         Returns:
             TransactionGetReceiptQuery: A configured receipt query.
+
+        Raises:
+            TypeError: If `validate_status` is not a bool or `client` is not a Client.
         """
         from hiero_sdk_python.query.transaction_get_receipt_query import TransactionGetReceiptQuery
 
-        if client is None or not client.allow_receipt_node_failover:
-            return (
-                TransactionGetReceiptQuery()
-                .set_transaction_id(self.transaction_id)
-                .set_node_account_ids([self.node_id])
-                .set_validate_status(validate_status)
-            )
+        if not isinstance(validate_status, bool):
+            raise TypeError("validate_status must be a boolean")
+
+        if client is not None and not isinstance(client, Client):
+            raise TypeError("client must be an instance of Client")
 
         node_account_ids = self._resolve_node_account_ids(client)
         return (
@@ -90,11 +91,14 @@ def get_record_query(self, client: Client | None = None):
 
         Returns:
             TransactionRecordQuery: A configured record query.
+
+        Raises:
+            TypeError: If `client` is not a Client.
         """
         from hiero_sdk_python.query.transaction_record_query import TransactionRecordQuery
 
-        if client is None or not client.allow_receipt_node_failover:
-            return TransactionRecordQuery().set_transaction_id(self.transaction_id).set_node_account_ids([self.node_id])
+        if client is not None and not isinstance(client, Client):
+            raise TypeError("client must be an instance of Client")
 
         node_account_ids = self._resolve_node_account_ids(client)
         return TransactionRecordQuery().set_transaction_id(self.transaction_id).set_node_account_ids(node_account_ids)
@@ -114,8 +118,11 @@ def get_record(self, client: Client, timeout: int | float | None = None) -> Tran
 
     def _resolve_node_account_ids(self, client: Client) -> list[AccountId]:
         """Resolve node account IDs for receipt or record query failover."""
-        available_node_ids = self._transaction_node_ids if self._transaction_node_ids else client.get_node_account_ids()
-
         node_account_ids = [self.node_id]
+
+        if client is None or not client.allow_receipt_node_failover:
+            return node_account_ids
+
+        available_node_ids = self._transaction_node_ids if self._transaction_node_ids else client.get_node_account_ids()
         node_account_ids.extend(node_id for node_id in available_node_ids if node_id != self.node_id)
         return node_account_ids

tests/unit/transaction_response_test.py

@@ -12,6 +12,7 @@
 import pytest
 
 from hiero_sdk_python.account.account_id import AccountId
+from hiero_sdk_python.client.client import Client
 from hiero_sdk_python.exceptions import ReceiptStatusError
 from hiero_sdk_python.hapi.services import (
     basic_types_pb2,
@@ -253,6 +254,73 @@ def test_transaction_response_get_receipt_is_pinned_to_submitting_node(
         assert receipt.status == ResponseCode.SUCCESS
 
 
+@pytest.mark.parametrize("status", [1, 1.2, None, Client(), "True", [], {}])
+def test_get_receipt_query_invalid_status_type(status):
+    """Test that get_receipt_query raises TypeError for an invalid status type."""
+    response = TransactionResponse()
+    with pytest.raises(TypeError, match="validate_status must be a boolean"):
+        response.get_receipt_query(validate_status=status)
+
+
+@pytest.mark.parametrize(
+    "client",
+    [1, 1.2, True, "True", [], {}],  # None is allow for client
+)
+def test_get_receipt_query_invalid_client_type(client):
+    """Test that get_receipt_query raises TypeError for an invalid client type."""
+    response = TransactionResponse()
+    with pytest.raises(TypeError, match="client must be an instance of Client"):
+        response.get_receipt_query(client=client)
+
+
+@pytest.mark.parametrize(
+    "client",
+    [1, 1.2, True, "True", [], {}],  # None is allow for client
+)
+def test_get_record_query_invalid_client_type(client):
+    """Test that get_record_query raises TypeError for an invalid client type."""
+    response = TransactionResponse()
+    with pytest.raises(TypeError, match="client must be an instance of Client"):
+        response.get_record_query(client=client)
+
+
+def test_resolve_node_account_ids_with_failover_diabled(mock_client):
+    """Test that only the transaction node is returned when no client or failover is disabled."""
+    response = TransactionResponse()
+    response.node_id = AccountId.from_string("0.0.3")
+
+    # When client is None
+    node_ids = response._resolve_node_account_ids(None)
+    assert node_ids == [AccountId.from_string("0.0.3")]
+
+    # With failover disabled
+    node_ids = response._resolve_node_account_ids(mock_client)
+    assert node_ids == [AccountId.from_string("0.0.3")]
+
+
+def test_resolve_node_account_ids_with_transaction_nodes(mock_client):
+    """Test that transaction nodes are used when receipt failover is enabled."""
+    response = TransactionResponse()
+    response.node_id = AccountId.from_string("0.0.3")
+    response._transaction_node_ids = [AccountId.from_string("0.0.3"), AccountId.from_string("0.0.4")]
+
+    mock_client.set_allow_receipt_node_failover(True)
+    node_ids = response._resolve_node_account_ids(mock_client)
+    assert node_ids == [AccountId.from_string("0.0.3"), AccountId.from_string("0.0.4")]
+
+
+def test_resolve_node_account_ids_uses_client_nodes_when_transaction_nodes_unavailable(mock_client):
+    """Test that client nodes are used when transaction nodes are unavailable."""
+    response = TransactionResponse()
+    response.node_id = AccountId.from_string("0.0.3")
+    response._transaction_node_ids = []
+
+    mock_client.set_allow_receipt_node_failover(True)
+    node_ids = response._resolve_node_account_ids(mock_client)
+
+    assert node_ids == mock_client.get_node_account_ids()
+
+
 def test_default_receipt_query_is_pinned_to_submitting_node(mock_client):
     """Test that receipt queries use only the submitting node by default."""
     node_id = AccountId.from_string("0.0.4")
@@ -271,7 +339,7 @@ def test_default_receipt_query_is_pinned_to_submitting_node(mock_client):
     assert query.node_account_ids == [node_id]
 
     # With failover disabled
-    query = response.get_receipt_query(mock_client)
+    query = response.get_receipt_query(client=mock_client)
     assert isinstance(query, TransactionGetReceiptQuery)
     assert query.node_account_ids == [node_id]