Skip to content

Update pytest version constraint to allow pytest 9.x (#1797) - #1906

Closed
Halbot100 wants to merge 1 commit into
hiero-ledger:mainfrom
Halbot100:update-pytest-version
Closed

Update pytest version constraint to allow pytest 9.x (#1797)#1906
Halbot100 wants to merge 1 commit into
hiero-ledger:mainfrom
Halbot100:update-pytest-version

Conversation

@Halbot100

@Halbot100 Halbot100 commented Mar 4, 2026

Copy link
Copy Markdown

📋 Summary

Fixes #1797

✅ Changes

  • Updated pytest version constraint from <9 to <10
  • Enables support for pytest 9.0.2 and forward compatibility

📝 Change Details

-    "pytest>=8.3.4,<9",
+    "pytest>=8.3.4,<10",

🎯 Why This Matters

  • ✅ Unlocks pytest 9.0.2 features for users
  • ✅ Maintains backward compatibility with pytest 8.x
  • ✅ Future-proof for upcoming pytest releases

📝 Files Changed

  • pyproject.toml (1 line)

Built with ❤️ by Halbot100 🤖

Update pytest from <9 to <10 to enable support for pytest 9.0.2
and forward compatibility.

Closes hiero-ledger#1797
@Halbot100
Halbot100 requested review from a team as code owners March 4, 2026 20:20
@github-actions

github-actions Bot commented Mar 4, 2026

Copy link
Copy Markdown
Hi @Halbot100, this is **LinkBot** 👋

🚨 This pull request is linked to issue(s), but you are not assigned to any of them.
If this remains unchanged, this pull request will be automatically closed.

Linked issue(s): #1797

Please get assigned to one of the linked issues and keep the link in this PR description.
Comment /assign on the issue to request assignment (works for all issue types).
Note: assignment for intermediate/advanced issues is not automatic.

📖 Guide:
docs/sdk_developers/how_to_link_issues.md

Thanks!

@github-actions

github-actions Bot commented Mar 4, 2026

Copy link
Copy Markdown

[commit-verification-bot]
Hi, this is VerificationBot.
Your pull request cannot be merged as it has 1 unverified commit(s):

  • 9c96bc3 Update pytest version constraint to allow pytest 9

View your commit verification status: Commits Tab.

To achieve verified status, please read:

Remember, you require a GPG key and each commit must be signed with:
git commit -S -s -m "Your message here"

Thank you for contributing!

From the Hiero Python SDK Team

@coderabbitai

coderabbitai Bot commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

The pytest dependency constraint in pyproject.toml is widened from <9 to <10, allowing pytest 9.x releases to be installed alongside the existing version constraint >=8.3.4.

Changes

Cohort / File(s) Summary
Dependency Update
pyproject.toml
Pytest upper bound constraint updated from <9 to <10 in the dev dependency group, enabling compatibility with pytest 9.x releases.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR partially meets issue #1797 requirements: the pytest constraint is updated correctly, but the required CHANGELOG.md entry under [UNRELEASED] is missing from the changeset. Add a corresponding CHANGELOG.md entry under [UNRELEASED] section as specified in issue #1797 to complete the requirement.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: updating the pytest version constraint to allow pytest 9.x versions.
Out of Scope Changes check ✅ Passed All changes in the PR are directly related to the objective of updating the pytest version constraint; no out-of-scope modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The pull request description clearly explains the change (pytest version constraint update from <9 to <10), references the linked issue #1797, provides context about enabling pytest 9.x support, and is directly related to the changeset.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 829975e8-08f5-41ea-8653-76c61f656be1

📥 Commits

Reviewing files that changed from the base of the PR and between 828adc1 and 9c96bc3.

📒 Files selected for processing (1)
  • pyproject.toml

Comment thread pyproject.toml
Comment on lines 46 to 51
[dependency-groups]
dev = [
"grpcio-tools>=1.76.0,<2",
"pytest>=8.3.4,<9",
"pytest>=8.3.4,<10",
"pytest-cov>=7.0.0,<8",
]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Missing CHANGELOG.md entry per issue #1797.

The linked issue explicitly requires adding a corresponding .CHANGELOG.md entry under [UNRELEASED]. This does not appear to be included in the PR files. Please ensure this is added before merging.

@github-actions

github-actions Bot commented Mar 6, 2026

Copy link
Copy Markdown

Hi there! I'm the LinkedIssueBot.
This pull request has been automatically closed due to the following reason(s):

Thank you,
From Python SDK team

@github-actions github-actions Bot closed this Mar 6, 2026
@exploreriii exploreriii added the notes: spam Irrelevant, low-quality, or malicious, created solely for self-promotion, credit, or deception. label Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

notes: spam Irrelevant, low-quality, or malicious, created solely for self-promotion, credit, or deception.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Good First Issue]: Update pytest

2 participants