Skip to content

Commit be19b30

Browse files
JeffreyDallasclaude
andcommitted
ci: fix Windows E2E cluster setup being skipped
- Remove runner.os != 'Windows' guard from Setup E2E Tests — the step uses shell: bash (Git Bash on Windows) and already handles EXEC_CG for Windows; skipping it left no cluster for the tests to connect to - Add || true to docker info | grep -i cgroup in setup-dual-e2e.sh so set -eo pipefail does not abort setup when cgroup info is absent on Windows Docker Desktop Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent ecf82b7 commit be19b30

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

.github/workflows/zxc-e2e-test.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -393,7 +393,7 @@ jobs:
393393
cd ../solo
394394
395395
- name: Setup E2E Tests
396-
if: ${{ inputs.custom-job-label != 'One Shot Single - using Podman' && runner.os != 'Windows' && !cancelled() && !failure() }}
396+
if: ${{ inputs.custom-job-label != 'One Shot Single - using Podman' && !cancelled() && !failure() }}
397397
uses: step-security/retry@e1d59ce1f574b32f0915e3a8df055cfe9f99be5d # v3.0.4
398398
with:
399399
max_attempts: 3

test/e2e/dual-cluster/setup-dual-e2e.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ done
5151

5252
docker network rm -f kind || true
5353
docker network create kind --scope local --subnet 172.19.0.0/16 --driver bridge
54-
docker info | grep -i cgroup
54+
docker info | grep -i cgroup || true
5555

5656
# Setup Helm Repos
5757
helm repo add metrics-server https://kubernetes-sigs.github.io/metrics-server/ --force-update

0 commit comments

Comments
 (0)