fix: preserve offline preflight across throttled scans (#63)

* fix: preserve offline preflight across throttled scans (app/production_outcome_runtime.py)

* fix: preserve offline preflight across throttled scans (tests/test_production_outcome_runtime.py)

Author: hiidkaboutyou-spec

app/production_outcome_runtime.py

@@ -67,6 +67,17 @@ async def run_scheduled_scan(self: Application) -> None:
         # After collection, examine collector state
         collector = getattr(self, "collector", None)
         last_errors = list(getattr(collector, "last_errors", []) or [])
+        # A throttled/not-due scan can return before the collector populates
+        # ``last_errors``.  The live preflight still proved that every active X
+        # source was unreachable, so preserve that provider-wide truth in the
+        # outcome instead of mislabelling all sources complete.
+        if os.environ.get("X_PROVIDER_PREFLIGHT", "").strip().casefold() == "offline":
+            last_errors = [
+                f"@{str(source.get('handle', '')).lstrip('@').strip().lower()}: "
+                "provider_preflight_offline"
+                for source in enabled
+                if str(source.get("handle", "")).lstrip("@").strip()
+            ]
 
         # Parse source-level outcomes from errors
         attempted_handles: set[str] = set()

tests/test_production_outcome_runtime.py

@@ -2,6 +2,7 @@
 import unittest
 from pathlib import Path
 from types import SimpleNamespace
+from unittest.mock import patch
 
 from app import production_outcome_runtime as runtime
 from app.production_outcome import OutcomeStatus, load_outcome
@@ -21,10 +22,9 @@ def __init__(self):
                     data={"last_auto_run": "2026-09-07T00:00:00+00:00"}
                 )
                 self.collector = SimpleNamespace(
-                    last_errors=[
-                        "@source_one: provider_preflight_offline",
-                        "@source_two: provider_preflight_offline",
-                    ]
+                    # A not-due scan returns before the collector can populate
+                    # errors; live preflight must still govern the outcome.
+                    last_errors=[]
                 )
 
             async def run_scheduled_scan(self):
@@ -39,7 +39,8 @@ async def run(self):
             with tempfile.TemporaryDirectory() as tmp:
                 runtime._OUTCOME_PATH = Path(tmp) / "outcome.json"
                 runtime.start_run(run_id="concrete-app-test", trigger_event="test")
-                await ConcreteApplication().run()
+                with patch.dict("os.environ", {"X_PROVIDER_PREFLIGHT": "offline"}):
+                    await ConcreteApplication().run()
                 outcome = load_outcome(runtime._OUTCOME_PATH)
         finally:
             runtime._OUTCOME_PATH = old_path