Fix SAT warnings (openhab#5170)

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>

Author: holgerfriedrich

bundles/org.openhab.core.automation.module.script/src/main/java/org/openhab/core/automation/module/script/internal/handler/AbstractScriptModuleHandler.java

@@ -145,7 +145,7 @@ public String getRuleUID() {
      * 
      * @return the type identifier
      */
-    abstract public String getTypeId();
+    public abstract String getTypeId();
 
     /**
      * Gets the script engine identifier for this module

bundles/org.openhab.core.semantics/src/main/java/org/openhab/core/semantics/internal/SemanticsServiceImpl.java

@@ -289,7 +289,7 @@ ItemSemanticsProblem getItemTagProblems(Item item, @Nullable Class<? extends Tag
      * @return true if the semantics are valid, false otherwise
      */
     boolean checkSemantics(Item item) {
-        return getItemSemanticsProblems(item, true).size() == 0 ? true : false;
+        return getItemSemanticsProblems(item, true).isEmpty();
     }
 
     @Override

bundles/org.openhab.core.test.magic/src/main/resources/OH-INF/thing/channel-types.xml

@@ -33,7 +33,7 @@
 		</description>
 		<category>ColorLight</category>
 		<tags>
-			<tag>Lighting</tag>
+			<tag>Light</tag>
 		</tags>
 		<autoUpdatePolicy>recommend</autoUpdatePolicy>
 		<config-description>

bundles/org.openhab.core/src/main/java/org/openhab/core/service/ReadyMarker.java

@@ -75,10 +75,7 @@ public boolean equals(@Nullable Object obj) {
         if (!identifier.equals(other.identifier)) {
             return false;
         }
-        if (!type.equals(other.type)) {
-            return false;
-        }
-        return true;
+        return type.equals(other.type);
     }
 
     @Override