chore: fix reviews

Author: datbth

cmd/anfra/main.go

@@ -16,10 +16,14 @@ type exitCodeError struct{ code int }
 func (e *exitCodeError) Error() string { return fmt.Sprintf("exit code %d", e.code) }
 
 func main() {
-	err := newRootCmd().Execute()
+	// ExecuteC returns the command that actually ran, so we get the real
+	// subcommand name (handles flags/args/aliases) rather than parsing os.Args.
+	executed, err := newRootCmd().ExecuteC()
 	// After the command runs, surface a cached "update available" notice (and, if
 	// opted in, kick a background update). Best-effort; never affects exit status.
-	maybeNotifyUpdate(invokedCommand())
+	if executed != nil {
+		maybeNotifyUpdate(executed.Name())
+	}
 
 	if err == nil {
 		return
@@ -32,17 +36,6 @@ func main() {
 	os.Exit(1)
 }
 
-// invokedCommand returns the first non-flag CLI arg (the subcommand name), or ""
-// for a bare `anfra`. Used to suppress the notice on update/serve commands.
-func invokedCommand() string {
-	for _, a := range os.Args[1:] {
-		if len(a) > 0 && a[0] != '-' {
-			return a
-		}
-	}
-	return ""
-}
-
 func newRootCmd() *cobra.Command {
 	root := &cobra.Command{
 		Use:   "anfra",

install.sh

@@ -12,9 +12,9 @@
 #   ANFRA_INSTALL_DIR    install location (default: $HOME/.anfra/bin)
 #   ANFRA_VERSION        pin a version, e.g. 0.1.0 (default: latest)
 #   ANFRA_NO_MODIFY_PATH if set, don't touch shell rc files; just print the hint
-#   GITHUB_TOKEN         optional; sent as a bearer token (for pre-public access)
 #
-# Trust model: downloads over HTTPS from GitHub Releases (TOFU). Signature
+# Downloads from public GitHub Releases (no auth). Trust model: downloads over
+# HTTPS from GitHub Releases (TOFU). Signature
 # verification is not done here yet — `anfra update` is where verification will
 # live (see .agents/projects/anfra/signing.md).
 
@@ -53,16 +53,11 @@ else
     url="https://github.com/${REPO}/releases/latest/download/${asset}"
 fi
 
-auth=()
-if [ -n "${GITHUB_TOKEN:-}" ]; then
-    auth=(-H "Authorization: Bearer ${GITHUB_TOKEN}")
-fi
-
 # --- download ---
 tmp="$(mktemp -d)"
 trap 'rm -rf "$tmp"' EXIT
 echo "Downloading ${asset} (~250 MB) for ${os}/${arch}..."
-if ! curl -fL ${auth[@]+"${auth[@]}"} -o "${tmp}/${BIN_NAME}" "$url"; then
+if ! curl -fL -o "${tmp}/${BIN_NAME}" "$url"; then
     err "download failed from ${url} (is the release published for this platform?)"
 fi
 

internal/update/update.go

@@ -154,7 +154,17 @@ func (r *Release) IsNewer() bool {
 	if cur == "dev" || cur == "" {
 		return true
 	}
-	return semver.Compare("v"+r.Version, "v"+cur) > 0
+	// Normalize to canonical vX.Y.Z so a stray "v"/"anfra-v" prefix on either side
+	// can't produce an invalid string (e.g. "vv0.2.0"), which Compare treats as 0.
+	return semver.Compare(canonicalVersion(r.Version), canonicalVersion(cur)) > 0
+}
+
+// canonicalVersion strips any anfra-v / v prefix and re-adds a single "v", so
+// semver.Compare always sees a valid version regardless of the input format.
+func canonicalVersion(v string) string {
+	v = strings.TrimPrefix(v, tagPrefix)
+	v = strings.TrimPrefix(v, "v")
+	return "v" + v
 }
 
 // Apply downloads the platform asset and atomically replaces the running binary.

internal/update/update_test.go

@@ -25,6 +25,11 @@ func TestIsNewer(t *testing.T) {
 		{"dev", "0.1.0", true}, // local build is always outdated
 		{"", "0.1.0", true},    // unset behaves like dev
 		{"1.0.0", "0.9.9", false},
+		// Mixed prefixes must normalize, not degrade to a 0/invalid compare.
+		{"v0.1.0", "0.2.0", true},
+		{"0.1.0", "v0.2.0", true},
+		{"v1.0.0", "v1.0.0", false},
+		{"anfra-v0.1.0", "0.2.0", true},
 	}
 	for _, c := range cases {
 		meta.Version = c.current