Skip to content

Commit 6815184

Browse files
TimoPtrTimoPtr
committed
Update lint baseline
1 parent dad25ae commit 6815184

4 files changed

Lines changed: 72 additions & 50 deletions

File tree

‎app/lint-baseline.xml‎

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
99
<location
1010
file="src/full/kotlin/io/homeassistant/companion/android/sensors/ActivitySensorManager.kt"
11-
line="233"
11+
line="236"
1212
column="13"/>
1313
</issue>
1414

@@ -19,40 +19,40 @@
1919
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
2020
<location
2121
file="src/full/kotlin/io/homeassistant/companion/android/sensors/ActivitySensorManager.kt"
22-
line="238"
22+
line="241"
2323
column="17"/>
2424
</issue>
2525

2626
<issue
2727
id="MissingPermission"
2828
message="Call requires permission which may be rejected by user: code should explicitly check to see if permission is available (with `checkPermission`) or explicitly handle a potential `SecurityException`"
29-
errorLine1=" ActivityRecognition.getClient(context).requestSleepSegmentUpdates("
29+
errorLine1=" ActivityRecognition.getClient(applicationContext).requestSleepSegmentUpdates("
3030
errorLine2=" ^">
3131
<location
3232
file="src/full/kotlin/io/homeassistant/companion/android/sensors/ActivitySensorManager.kt"
33-
line="258"
33+
line="260"
3434
column="25"/>
3535
</issue>
3636

3737
<issue
3838
id="MissingPermission"
3939
message="Call requires permission which may be rejected by user: code should explicitly check to see if permission is available (with `checkPermission`) or explicitly handle a potential `SecurityException`"
40-
errorLine1=" ActivityRecognition.getClient(context).requestSleepSegmentUpdates("
40+
errorLine1=" ActivityRecognition.getClient(applicationContext).requestSleepSegmentUpdates("
4141
errorLine2=" ^">
4242
<location
4343
file="src/full/kotlin/io/homeassistant/companion/android/sensors/ActivitySensorManager.kt"
44-
line="266"
44+
line="268"
4545
column="25"/>
4646
</issue>
4747

4848
<issue
4949
id="MissingPermission"
5050
message="Call requires permission which may be rejected by user: code should explicitly check to see if permission is available (with `checkPermission`) or explicitly handle a potential `SecurityException`"
51-
errorLine1=" ActivityRecognition.getClient(context).requestSleepSegmentUpdates("
51+
errorLine1=" ActivityRecognition.getClient(applicationContext).requestSleepSegmentUpdates("
5252
errorLine2=" ^">
5353
<location
5454
file="src/full/kotlin/io/homeassistant/companion/android/sensors/ActivitySensorManager.kt"
55-
line="274"
55+
line="276"
5656
column="25"/>
5757
</issue>
5858

@@ -74,7 +74,7 @@
7474
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
7575
<location
7676
file="src/full/kotlin/io/homeassistant/companion/android/location/HighAccuracyLocationService.kt"
77-
line="128"
77+
line="129"
7878
column="17"/>
7979
</issue>
8080

@@ -85,7 +85,7 @@
8585
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
8686
<location
8787
file="src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt"
88-
line="1113"
88+
line="1116"
8989
column="17"/>
9090
</issue>
9191

@@ -107,7 +107,7 @@
107107
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
108108
<location
109109
file="src/full/kotlin/io/homeassistant/companion/android/location/HighAccuracyLocationService.kt"
110-
line="115"
110+
line="116"
111111
column="26"/>
112112
</issue>
113113

@@ -118,7 +118,7 @@
118118
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
119119
<location
120120
file="src/full/kotlin/io/homeassistant/companion/android/location/HighAccuracyLocationService.kt"
121-
line="116"
121+
line="117"
122122
column="25"/>
123123
</issue>
124124

@@ -690,7 +690,7 @@
690690
errorLine2=" ~~~~~~~~~~~~~">
691691
<location
692692
file="src/main/kotlin/io/homeassistant/companion/android/settings/sensor/SensorDetailViewModel.kt"
693-
line="369"
693+
line="371"
694694
column="38"/>
695695
</issue>
696696

@@ -756,7 +756,7 @@
756756
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
757757
<location
758758
file="src/full/kotlin/io/homeassistant/companion/android/location/HighAccuracyLocationService.kt"
759-
line="53"
759+
line="54"
760760
column="9"/>
761761
</issue>
762762

@@ -767,7 +767,7 @@
767767
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
768768
<location
769769
file="src/full/kotlin/io/homeassistant/companion/android/location/HighAccuracyLocationService.kt"
770-
line="55"
770+
line="56"
771771
column="9"/>
772772
</issue>
773773

‎automotive/lint-baseline.xml‎

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
99
<location
1010
file="${:automotive*fullDebug*MAIN*sourceProvider*0*javaDir*7}/io/homeassistant/companion/android/sensors/ActivitySensorManager.kt"
11-
line="233"
11+
line="236"
1212
column="13"/>
1313
</issue>
1414

@@ -19,40 +19,40 @@
1919
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
2020
<location
2121
file="${:automotive*fullDebug*MAIN*sourceProvider*0*javaDir*7}/io/homeassistant/companion/android/sensors/ActivitySensorManager.kt"
22-
line="238"
22+
line="241"
2323
column="17"/>
2424
</issue>
2525

2626
<issue
2727
id="MissingPermission"
2828
message="Call requires permission which may be rejected by user: code should explicitly check to see if permission is available (with `checkPermission`) or explicitly handle a potential `SecurityException`"
29-
errorLine1=" ActivityRecognition.getClient(context).requestSleepSegmentUpdates("
29+
errorLine1=" ActivityRecognition.getClient(applicationContext).requestSleepSegmentUpdates("
3030
errorLine2=" ^">
3131
<location
3232
file="${:automotive*fullDebug*MAIN*sourceProvider*0*javaDir*7}/io/homeassistant/companion/android/sensors/ActivitySensorManager.kt"
33-
line="258"
33+
line="260"
3434
column="25"/>
3535
</issue>
3636

3737
<issue
3838
id="MissingPermission"
3939
message="Call requires permission which may be rejected by user: code should explicitly check to see if permission is available (with `checkPermission`) or explicitly handle a potential `SecurityException`"
40-
errorLine1=" ActivityRecognition.getClient(context).requestSleepSegmentUpdates("
40+
errorLine1=" ActivityRecognition.getClient(applicationContext).requestSleepSegmentUpdates("
4141
errorLine2=" ^">
4242
<location
4343
file="${:automotive*fullDebug*MAIN*sourceProvider*0*javaDir*7}/io/homeassistant/companion/android/sensors/ActivitySensorManager.kt"
44-
line="266"
44+
line="268"
4545
column="25"/>
4646
</issue>
4747

4848
<issue
4949
id="MissingPermission"
5050
message="Call requires permission which may be rejected by user: code should explicitly check to see if permission is available (with `checkPermission`) or explicitly handle a potential `SecurityException`"
51-
errorLine1=" ActivityRecognition.getClient(context).requestSleepSegmentUpdates("
51+
errorLine1=" ActivityRecognition.getClient(applicationContext).requestSleepSegmentUpdates("
5252
errorLine2=" ^">
5353
<location
5454
file="${:automotive*fullDebug*MAIN*sourceProvider*0*javaDir*7}/io/homeassistant/companion/android/sensors/ActivitySensorManager.kt"
55-
line="274"
55+
line="276"
5656
column="25"/>
5757
</issue>
5858

@@ -74,7 +74,7 @@
7474
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
7575
<location
7676
file="${:automotive*fullDebug*MAIN*sourceProvider*0*javaDir*7}/io/homeassistant/companion/android/location/HighAccuracyLocationService.kt"
77-
line="128"
77+
line="129"
7878
column="17"/>
7979
</issue>
8080

@@ -85,7 +85,7 @@
8585
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
8686
<location
8787
file="${:automotive*fullDebug*MAIN*sourceProvider*0*javaDir*5}/io/homeassistant/companion/android/notifications/MessagingManager.kt"
88-
line="1113"
88+
line="1116"
8989
column="17"/>
9090
</issue>
9191

@@ -129,7 +129,7 @@
129129
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
130130
<location
131131
file="${:automotive*fullDebug*MAIN*sourceProvider*0*javaDir*7}/io/homeassistant/companion/android/location/HighAccuracyLocationService.kt"
132-
line="115"
132+
line="116"
133133
column="26"/>
134134
</issue>
135135

@@ -140,7 +140,7 @@
140140
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
141141
<location
142142
file="${:automotive*fullDebug*MAIN*sourceProvider*0*javaDir*7}/io/homeassistant/companion/android/location/HighAccuracyLocationService.kt"
143-
line="116"
143+
line="117"
144144
column="25"/>
145145
</issue>
146146

@@ -646,7 +646,7 @@
646646
errorLine2=" ~~~~~~~~~~~~~">
647647
<location
648648
file="${:automotive*fullDebug*MAIN*sourceProvider*0*javaDir*5}/io/homeassistant/companion/android/settings/sensor/SensorDetailViewModel.kt"
649-
line="369"
649+
line="371"
650650
column="38"/>
651651
</issue>
652652

@@ -1616,7 +1616,7 @@
16161616
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
16171617
<location
16181618
file="${:automotive*fullDebug*MAIN*sourceProvider*0*javaDir*7}/io/homeassistant/companion/android/location/HighAccuracyLocationService.kt"
1619-
line="53"
1619+
line="54"
16201620
column="9"/>
16211621
</issue>
16221622

@@ -1627,7 +1627,7 @@
16271627
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
16281628
<location
16291629
file="${:automotive*fullDebug*MAIN*sourceProvider*0*javaDir*7}/io/homeassistant/companion/android/location/HighAccuracyLocationService.kt"
1630-
line="55"
1630+
line="56"
16311631
column="9"/>
16321632
</issue>
16331633

‎common/lint-baseline.xml‎

Lines changed: 38 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -4,44 +4,44 @@
44
<issue
55
id="MissingPermission"
66
message="Call requires permission which may be rejected by user: code should explicitly check to see if permission is available (with `checkPermission`) or explicitly handle a potential `SecurityException`"
7-
errorLine1=" telephonyManager.isDataRoamingEnabled"
8-
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
7+
errorLine1=" telephonyManager.isDataRoamingEnabled"
8+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
99
<location
1010
file="src/main/kotlin/io/homeassistant/companion/android/common/sensors/MobileDataManager.kt"
11-
line="77"
12-
column="17"/>
11+
line="82"
12+
column="21"/>
1313
</issue>
1414

1515
<issue
1616
id="MissingPermission"
1717
message="Call requires permission which may be rejected by user: code should explicitly check to see if permission is available (with `checkPermission`) or explicitly handle a potential `SecurityException`"
18-
errorLine1=" telephonyManager.isDataEnabled"
19-
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
18+
errorLine1=" telephonyManager.isDataEnabled"
19+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
2020
<location
2121
file="src/main/kotlin/io/homeassistant/companion/android/common/sensors/MobileDataManager.kt"
22-
line="79"
23-
column="17"/>
22+
line="85"
23+
column="21"/>
2424
</issue>
2525

2626
<issue
2727
id="MissingPermission"
2828
message="Call requires permission which may be rejected by user: code should explicitly check to see if permission is available (with `checkPermission`) or explicitly handle a potential `SecurityException`"
29-
errorLine1=" val subscription = context.applicationContext.getSystemService&lt;SubscriptionManager>()"
29+
errorLine1=" val subscription = applicationContext.getSystemService&lt;SubscriptionManager>()"
3030
errorLine2=" ^">
3131
<location
3232
file="src/main/kotlin/io/homeassistant/companion/android/common/sensors/PhoneStateSensorManager.kt"
33-
line="274"
33+
line="285"
3434
column="28"/>
3535
</issue>
3636

3737
<issue
3838
id="MissingPermission"
3939
message="Call requires permission which may be rejected by user: code should explicitly check to see if permission is available (with `checkPermission`) or explicitly handle a potential `SecurityException`"
40-
errorLine1=" val subscription = context.applicationContext.getSystemService&lt;SubscriptionManager>()"
40+
errorLine1=" val subscription = applicationContext.getSystemService&lt;SubscriptionManager>()"
4141
errorLine2=" ^">
4242
<location
4343
file="src/main/kotlin/io/homeassistant/companion/android/common/sensors/PhoneStateSensorManager.kt"
44-
line="319"
44+
line="329"
4545
column="28"/>
4646
</issue>
4747

@@ -52,7 +52,7 @@
5252
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
5353
<location
5454
file="src/main/kotlin/io/homeassistant/companion/android/common/sensors/PhoneStateSensorManager.kt"
55-
line="327"
55+
line="337"
5656
column="46"/>
5757
</issue>
5858

@@ -85,18 +85,40 @@
8585
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
8686
<location
8787
file="src/main/kotlin/io/homeassistant/companion/android/common/sensors/StorageSensorManager.kt"
88-
line="138"
88+
line="145"
8989
column="42"/>
9090
</issue>
9191

92+
<issue
93+
id="NewApi"
94+
message="Call requires API level 29 (current min is 23): `android.telephony.TelephonyManager#isDataRoamingEnabled`"
95+
errorLine1=" telephonyManager.isDataRoamingEnabled"
96+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~">
97+
<location
98+
file="src/main/kotlin/io/homeassistant/companion/android/common/sensors/MobileDataManager.kt"
99+
line="82"
100+
column="38"/>
101+
</issue>
102+
103+
<issue
104+
id="NewApi"
105+
message="Call requires API level 26 (current min is 23): `android.telephony.TelephonyManager#isDataEnabled`"
106+
errorLine1=" telephonyManager.isDataEnabled"
107+
errorLine2=" ~~~~~~~~~~~~~">
108+
<location
109+
file="src/main/kotlin/io/homeassistant/companion/android/common/sensors/MobileDataManager.kt"
110+
line="85"
111+
column="38"/>
112+
</issue>
113+
92114
<issue
93115
id="AppBundleLocaleChanges"
94116
message="Found dynamic locale changes, but did not find corresponding Play Core library calls for downloading languages and splitting by language is not disabled in the `bundle` configuration"
95117
errorLine1=" config.setLocale(Locale(&quot;en&quot;))"
96118
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
97119
<location
98120
file="src/main/kotlin/io/homeassistant/companion/android/common/sensors/SensorReceiverBase.kt"
99-
line="403"
121+
line="411"
100122
column="9"/>
101123
</issue>
102124

@@ -129,7 +151,7 @@
129151
errorLine2=" ~~~~~~~~~~~~~">
130152
<location
131153
file="src/main/kotlin/io/homeassistant/companion/android/common/sensors/SensorManager.kt"
132-
line="299"
154+
line="296"
133155
column="61"/>
134156
</issue>
135157

‎wear/lint-baseline.xml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -114,12 +114,12 @@
114114
<issue
115115
id="LocalContextGetResourceValueCall"
116116
message="Querying resource values using LocalContext.current"
117-
errorLine1=" return SensorReceiver.MANAGERS.sortedBy { context.getString(it.name) }.filter { it.hasSensor(context) }"
118-
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~">
117+
errorLine1=" return allManagers.sortedBy { context.getString(it.name) }.filter { it.hasSensor() }"
118+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~">
119119
<location
120120
file="src/main/kotlin/io/homeassistant/companion/android/home/views/SensorsView.kt"
121-
line="49"
122-
column="47"/>
121+
line="48"
122+
column="35"/>
123123
</issue>
124124

125125
<issue

0 commit comments

Comments
 (0)