Fix missing DeviceId in tests

Author: TimoPtr

app/src/test/kotlin/io/homeassistant/companion/android/onboarding/BaseOnboardingNavigationTest.kt

@@ -2,7 +2,6 @@ package io.homeassistant.companion.android.onboarding
 
 import android.content.Context
 import android.content.pm.PackageManager
-import android.provider.Settings
 import androidx.activity.compose.LocalActivityResultRegistryOwner
 import androidx.activity.result.ActivityResultRegistry
 import androidx.activity.result.ActivityResultRegistryOwner
@@ -18,6 +17,7 @@ import androidx.navigation.testing.TestNavHostController
 import androidx.test.core.app.ApplicationProvider
 import dagger.hilt.android.testing.HiltAndroidRule
 import io.homeassistant.companion.android.HiltComponentActivity
+import io.homeassistant.companion.android.testing.unit.seedFakeAndroidId
 import io.homeassistant.companion.android.util.FakePermissionResultRegistry
 import io.homeassistant.companion.android.util.compose.navigateToUri
 import io.mockk.Runs
@@ -29,10 +29,6 @@ import kotlinx.coroutines.test.runTest
 import org.junit.Before
 import org.junit.Rule
 
-// Robolectric leaves Settings.Secure.ANDROID_ID null, but the integration graph injects it as a
-// non-null @NamedDeviceId, so we seed a value to avoid a null-from-@Provides crash during DI.
-private const val FAKE_ANDROID_ID = "robolectric-android-id"
-
 /**
  * Base class for onboarding navigation tests providing shared setup, mocks, and utilities.
  *
@@ -53,11 +49,7 @@ internal abstract class BaseOnboardingNavigationTest {
 
     @Before
     fun baseSetup() {
-        Settings.Secure.putString(
-            ApplicationProvider.getApplicationContext<Context>().contentResolver,
-            Settings.Secure.ANDROID_ID,
-            FAKE_ANDROID_ID,
-        )
+        ApplicationProvider.getApplicationContext<Context>().seedFakeAndroidId()
         mockkStatic(NavController::navigateToUri)
         coEvery { any<NavController>().navigateToUri(any(), any()) } just Runs
     }

app/src/test/kotlin/io/homeassistant/companion/android/sensors/SensorManagerCompletenessTest.kt

@@ -1,13 +1,17 @@
 package io.homeassistant.companion.android.sensors
 
+import android.content.Context
+import androidx.test.core.app.ApplicationProvider
 import dagger.hilt.android.testing.HiltAndroidRule
 import dagger.hilt.android.testing.HiltAndroidTest
 import dagger.hilt.android.testing.HiltTestApplication
 import io.github.classgraph.ClassGraph
 import io.homeassistant.companion.android.common.sensors.SensorManager
+import io.homeassistant.companion.android.testing.unit.seedFakeAndroidId
 import javax.inject.Inject
 import org.junit.Assert.assertEquals
 import org.junit.Assert.assertTrue
+import org.junit.Before
 import org.junit.Rule
 import org.junit.Test
 import org.junit.runner.RunWith
@@ -31,6 +35,11 @@ class SensorManagerCompletenessTest {
     @Inject
     lateinit var managers: Set<@JvmSuppressWildcards SensorManager>
 
+    @Before
+    fun setup() {
+        ApplicationProvider.getApplicationContext<Context>().seedFakeAndroidId()
+    }
+
     @Test
     fun `Given every SensorManager on the classpath then each is bound into the injected set`() {
         hilt.inject()

common/src/test/kotlin/io/homeassistant/companion/android/sensors/SensorManagerCompletenessTest.kt

@@ -1,21 +1,25 @@
 package io.homeassistant.companion.android.sensors
 
+import android.content.Context
+import androidx.test.core.app.ApplicationProvider
 import dagger.hilt.android.testing.HiltAndroidRule
 import dagger.hilt.android.testing.HiltAndroidTest
 import dagger.hilt.android.testing.HiltTestApplication
 import io.github.classgraph.ClassGraph
 import io.homeassistant.companion.android.common.sensors.SensorManager
+import io.homeassistant.companion.android.testing.unit.seedFakeAndroidId
 import javax.inject.Inject
 import org.junit.Assert.assertEquals
 import org.junit.Assert.assertTrue
+import org.junit.Before
 import org.junit.Rule
 import org.junit.Test
 import org.junit.runner.RunWith
 import org.robolectric.RobolectricTestRunner
 import org.robolectric.annotation.Config
 
 /**
- * Guards against forgetting a `@Binds @IntoSet` for a new wear [SensorManager]: every concrete
+ * Guards against forgetting a `@Binds @IntoSet` for a new [SensorManager]: every concrete
  * implementation on the classpath must be present in the Hilt-injected `Set<SensorManager>`.
  * ClassGraph is used because neither Hilt nor reflection can enumerate an interface's
  * implementations — only a classpath scan can.
@@ -30,6 +34,11 @@ class SensorManagerCompletenessTest {
     @Inject
     lateinit var managers: Set<@JvmSuppressWildcards SensorManager>
 
+    @Before
+    fun setup() {
+        ApplicationProvider.getApplicationContext<Context>().seedFakeAndroidId()
+    }
+
     @Test
     fun `Given every SensorManager on the classpath then each is bound into the injected set`() {
         hilt.inject()

testing-unit/src/main/kotlin/io/homeassistant/companion/android/testing/unit/AndroidIdTestUtil.kt

@@ -0,0 +1,18 @@
+package io.homeassistant.companion.android.testing.unit
+
+import android.content.Context
+import android.provider.Settings
+
+/** Fake `Settings.Secure.ANDROID_ID` seeded by [seedFakeAndroidId]. */
+const val FAKE_ANDROID_ID = "robolectric-android-id"
+
+/**
+ * Seeds [Settings.Secure.ANDROID_ID] with [FAKE_ANDROID_ID] on this context.
+ *
+ * Robolectric leaves the value null, but the integration graph injects it as a non-null
+ * `@NamedDeviceId`, so any test that builds that graph must seed it first to avoid a
+ * null-from-`@Provides` crash during dependency injection.
+ */
+fun Context.seedFakeAndroidId() {
+    Settings.Secure.putString(contentResolver, Settings.Secure.ANDROID_ID, FAKE_ANDROID_ID)
+}

wear/src/test/kotlin/io/homeassistant/companion/android/sensors/SensorManagerCompletenessTest.kt

@@ -1,13 +1,17 @@
 package io.homeassistant.companion.android.sensors
 
+import android.content.Context
+import androidx.test.core.app.ApplicationProvider
 import dagger.hilt.android.testing.HiltAndroidRule
 import dagger.hilt.android.testing.HiltAndroidTest
 import dagger.hilt.android.testing.HiltTestApplication
 import io.github.classgraph.ClassGraph
 import io.homeassistant.companion.android.common.sensors.SensorManager
+import io.homeassistant.companion.android.testing.unit.seedFakeAndroidId
 import javax.inject.Inject
 import org.junit.Assert.assertEquals
 import org.junit.Assert.assertTrue
+import org.junit.Before
 import org.junit.Rule
 import org.junit.Test
 import org.junit.runner.RunWith
@@ -30,6 +34,11 @@ class SensorManagerCompletenessTest {
     @Inject
     lateinit var managers: Set<@JvmSuppressWildcards SensorManager>
 
+    @Before
+    fun setup() {
+        ApplicationProvider.getApplicationContext<Context>().seedFakeAndroidId()
+    }
+
     @Test
     fun `Given every SensorManager on the classpath then each is bound into the injected set`() {
         hilt.inject()