fix: clarify the addon-not-back error message (#2132)

* fix: clarify the addon-not-back error message

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NgWpy7arov56hET1PzoeCS

* fix: gate the live-tree no-op invariant and align the JS fallback wording

The canary flushed out one more ungated live-tree assertion:
test_clean_tree_plans_no_work asserts build_plan() over the real repo
returns no work, which any English-changing PR legitimately violates
until the sync runs. Gated behind LOCALE_COMPLETENESS_CHECKS and run in
the workflow's verification as the sync's own no-op invariant (a third
pytest invocation with the same junit skip assertion; the shape test
now scans the file's marker and filter names).

Bot review round: settings.js's inline fallback for errors.addon_not_back
still carried the clipped wording (CodeRabbit), and the restart-probe
behavior test only pinned the first sentence (Codex) — both now match
the corrected string.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NgWpy7arov56hET1PzoeCS

---------

Co-authored-by: kingpanther13 <kingpanther13@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

Author: kingpanther13

.github/workflows/locale-sync.yml

@@ -218,8 +218,14 @@ jobs:
         uv run pytest tests/src/unit/test_settings_ui_i18n.py -q --maxfail=0 \
           -k "test_shipped_catalog_translates_the_tools_tab" \
           --junitxml="$RUNNER_TEMP/verify-i18n.xml"
+        # The sync's own no-op invariant: a rerun against the tree this run
+        # just translated and repinned must plan zero work.
+        uv run pytest tests/src/unit/test_translate_locales.py -q --maxfail=0 \
+          -k "test_clean_tree_plans_no_work" \
+          --junitxml="$RUNNER_TEMP/verify-noop.xml"
         assert_nothing_skipped "$RUNNER_TEMP/verify-parity.xml"
         assert_nothing_skipped "$RUNNER_TEMP/verify-i18n.xml"
+        assert_nothing_skipped "$RUNNER_TEMP/verify-noop.xml"
 
     - name: Check for held English-source staleness
       id: staleness

src/ha_mcp/settings_ui/locales/en.json

@@ -184,7 +184,7 @@
     "errors.stop_failed": "Stop failed",
     "errors.restart_failed": "Restart failed",
     "errors.failed_detail": "Failed: {detail}",
-    "errors.addon_not_back": "App (add-on) did not come back online. Reload manually",
+    "errors.addon_not_back": "App (add-on) did not come back online. Reload the page manually.",
     "errors.unparseable_suffix": " (response body unparseable)",
     "common.operation_failed": "{operation} failed: {detail}",
     "common.enabled": "enabled",

src/ha_mcp/settings_ui/settings.js

@@ -648,7 +648,7 @@ async function _runRestartReloadCycle(previousInstanceId) {
     // never actually fired (silent supervisor failure → instance_id
     // never flipped) OR supervisor is genuinely slower than the cap.
     // Surface a clear next-step instead of silently doing nothing.
-    btn.textContent = t('errors.addon_not_back', {}, 'App (add-on) did not come back online. Reload manually');
+    btn.textContent = t('errors.addon_not_back', {}, 'App (add-on) did not come back online. Reload the page manually.');
     btn.disabled = false;
     restartInProgress = false;
   }

tests/src/unit/test_locale_sync_gate_shape.py

@@ -28,6 +28,7 @@
 _GATED_TEST_FILES = (
     Path(__file__).with_name("test_locale_parity.py"),
     Path(__file__).with_name("test_settings_ui_i18n.py"),
+    Path(__file__).with_name("test_translate_locales.py"),
 )
 
 
@@ -58,10 +59,7 @@ def _verification_steps() -> list[dict[str, Any]]:
         step
         for step in steps
         if "pytest" in str(step.get("run", ""))
-        and (
-            "test_locale_parity.py" in str(step.get("run", ""))
-            or "test_settings_ui_i18n.py" in str(step.get("run", ""))
-        )
+        and any(path.name in str(step.get("run", "")) for path in _GATED_TEST_FILES)
     ]
 
 

tests/src/unit/test_settings_ui_js_behavior.py

@@ -923,9 +923,9 @@ def test_probe_waits_for_instance_id_flip_not_just_200(
             "probe must not reload when instance_id never flips — "
             "that would land the user back on the same broken instance"
         )
-        assert "did not come back online" in result.dom.lower(), (
-            f"expected manual-reload fallback message, dom={result.dom[:600]}"
-        )
+        assert (
+            "did not come back online. reload the page manually." in result.dom.lower()
+        ), f"expected manual-reload fallback message, dom={result.dom[:600]}"
 
 
 # ---------------------------------------------------------------------------

tests/src/unit/test_translate_locales.py

@@ -12,6 +12,7 @@
 from __future__ import annotations
 
 import json
+import os
 import sys
 from pathlib import Path
 from types import SimpleNamespace
@@ -479,9 +480,21 @@ def dead_engine(prompt: str) -> dict[str, str]:
             "engine calls"
         )
 
+    # Same gate as ``test_locale_parity.completeness`` (see the marker
+    # comment there): this asserts the LIVE tree owes no translations, which
+    # any PR that changes an English string legitimately violates until the
+    # post-merge sync runs. ``test_locale_sync_gate_shape`` pins the wiring.
+    @pytest.mark.skipif(
+        not os.environ.get("LOCALE_COMPLETENESS_CHECKS"),
+        reason=(
+            "translated-catalog completeness is verified by the post-merge "
+            "locale-sync workflow — set LOCALE_COMPLETENESS_CHECKS=1 to run"
+        ),
+    )
     def test_clean_tree_plans_no_work(self) -> None:
-        """The no-op invariant the CI loop terminates on: after a translation
-        commit repins the baseline, the retriggered run must find nothing."""
+        """The sync's own no-op invariant: after a run repins the baseline,
+        a rerun must find nothing — verified in the workflow, where it runs
+        against the freshly translated tree."""
         module = translate_locales._load_test_module()
         plan = translate_locales.build_plan(module)
         assert plan.items == []