ci: reduce Docker Hub pulls in performance-tests workflow (#1549)

* ci: reduce Docker Hub pulls in performance-tests workflow

The performance-tests job timed out booting BuildKit while pulling
moby/buildkit from Docker Hub (registry-1.docker.io: context deadline
exceeded). The job never runs `docker build`, so the buildx builder it
sets up is unused — remove the step to drop that Docker Hub pull.

Also set TESTCONTAINERS_RYUK_DISABLED=true, matching e2e-tests.yml and
pr.yml. performance-tests.yml was the only testcontainers workflow
missing it, so it uniquely pulled testcontainers/ryuk from Docker Hub on
every run; the fixture cleans up via its `with container:` context
manager, so the reaper is unneeded on ephemeral CI runners.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* docs(internal): list performance-tests.yml in ryuk-disable cleanup note

The container-cleanup comment in conftest.py enumerated the workflows that
set TESTCONTAINERS_RYUK_DISABLED=true ({pr,e2e-tests}.yml). This PR adds
that env to performance-tests.yml as well, so include it in the list to
keep the cross-reference accurate.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: kingpanther13 <kingpanther13@users.noreply.github.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: kingpanther13

.github/workflows/performance-tests.yml

@@ -29,6 +29,13 @@ env:
   UV_CACHE_DIR: /tmp/.uv-cache
   # renovate: datasource=docker depName=ghcr.io/home-assistant/home-assistant
   HA_IMAGE_GHCR: "ghcr.io/home-assistant/home-assistant:2026.5.4"
+  # Disable Testcontainers' Ryuk reaper: it has been reported to leave
+  # zombie containers on GHA runners (see #366, Ilya0527 2026-05-18).
+  # The E2E fixture in tests/src/e2e/conftest.py relies instead on the
+  # enclosing ``with container:`` context manager — Python guarantees
+  # its ``__exit__`` fires on both normal and exception flows, so the
+  # Ryuk safety net is not needed for deterministic cleanup. Refs #366.
+  TESTCONTAINERS_RYUK_DISABLED: "true"
 
 jobs:
   performance-tests:
@@ -39,11 +46,6 @@ jobs:
     steps:
     - uses: actions/checkout@v6
 
-    - name: Set up Docker Buildx
-      uses: docker/setup-buildx-action@v4
-      with:
-        cache-binary: true
-
     - name: Cache HA Docker image
       id: cache-ha-image
       uses: actions/cache@v5

tests/src/e2e/conftest.py

@@ -1741,7 +1741,8 @@ def ha_container_with_fresh_config(_blueprint_http_server):
             # Container cleanup runs via the enclosing ``with container:``
             # block's ``__exit__`` (calls ``stop()`` which removes the
             # container). With ``TESTCONTAINERS_RYUK_DISABLED=true`` set in
-            # the CI workflow env (see .github/workflows/{pr,e2e-tests}.yml)
+            # the CI workflow env (see
+            # .github/workflows/{pr,e2e-tests,performance-tests}.yml)
             # the with-block exit IS the only cleanup mechanism — Python's
             # context-manager protocol guarantees ``__exit__`` fires on
             # both normal and exception flows, so the Ryuk reaper safety