fix(addon): bound the job-collision give-up message too

Moving the bound to _raise_supervisor_api_failure left one reporting
path uncovered: when a job-group collision exhausts the retry budget,
_supervisor_api_call raises its own error from the raw error_text it
computed for the marker test, so an oversized collision message was
still reported in full. That path was bounded before the move, on the
direct REST transport, so this closes a gap the move opened.

Bind the size after the marker classification is settled, and cover the
give-up path with a regression test.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: Patch76

src/ha_mcp/tools/tools_addons.py

@@ -726,6 +726,10 @@ async def _supervisor_api_call(
             if _JOB_COLLISION_MARKER not in error_text.lower():
                 _raise_supervisor_api_failure(result, endpoint)
 
+            # The marker test runs on the raw text; everything below reports
+            # it, so bind the size once the classification is settled.
+            error_text = _bounded_supervisor_text(error_text)
+
             remaining = deadline - time.monotonic()
             if remaining <= 0:
                 # The retry budget is exhausted; the group may be stuck or

tests/src/unit/test_tools_addons.py

@@ -4623,6 +4623,34 @@ async def test_addon_mode_invalid_json_error_caps_response_body(self, monkeypatc
             "x" * (50 * 1024 - len(suffix)) + suffix
         )
 
+    @pytest.mark.asyncio
+    async def test_job_collision_giveup_message_is_capped(self, monkeypatch):
+        """An exhausted job-collision retry cannot report an unbounded error."""
+        from ha_mcp.tools import tools_addons
+        from ha_mcp.tools.tools_addons import _supervisor_api_call
+
+        monkeypatch.delenv("SUPERVISOR_TOKEN", raising=False)
+        monkeypatch.setattr(tools_addons, "_JOB_COLLISION_RETRY_WINDOW", 0.0)
+        client = _make_mock_client()
+        client.send_websocket_message = AsyncMock(
+            return_value={
+                "success": False,
+                "error": (
+                    "Command failed: another job is running for job group "
+                    + "v" * (50 * 1024 + 1)
+                ),
+            }
+        )
+
+        with pytest.raises(ToolError) as exc_info:
+            await _supervisor_api_call(client, "/addons/x/restart", method="POST")
+
+        payload = _parse_tool_error(exc_info)
+        suffix = "\n[Supervisor response truncated to 50 KiB]"
+        message = payload["error"]["message"]
+        assert message.endswith(suffix)
+        assert len(message) == 50 * 1024
+
     @pytest.mark.asyncio
     async def test_core_routed_failure_message_is_capped(self, monkeypatch):
         """A Core-relayed Supervisor failure cannot produce an unbounded error."""