Skip to content

Commit 858d09e

Browse files
sergeykadSergey
andauthored
docs(internal): drop hardcoded home path from bat-story-eval skill (#2253)
* docs(internal): drop hardcoded home path from bat-story-eval skill - Replace /home/julien/github/ha-mcp/worktree/uat-stories with $(git rev-parse --show-toplevel)/worktree/uat-stories (3 sites) - Fix `Error: <agent>` placeholder to `{agent}`, matching the f-string in tests/uat/stories/scripts/ha_query.py:250 * fix(internal): resolve uat-stories worktree from the git common dir --show-toplevel returns the *current* worktree root, so invoking the skill from any worktree (the repo's normal flow) built the nested, nonexistent <worktree>/worktree/uat-stories. Flagged by Codex and CodeRabbit on #2253. --------- Co-authored-by: Sergey <sergey@example.com>
1 parent fc75b66 commit 858d09e

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

.claude/skills/bat-story-eval/SKILL.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ If `$ARGUMENTS` is `--help` or missing `--baseline`, show usage and stop:
3333
### 0a. Compute Diff
3434

3535
```bash
36-
cd /home/julien/github/ha-mcp/worktree/uat-stories
36+
cd "$(dirname "$(git rev-parse --path-format=absolute --git-common-dir)")/worktree/uat-stories"
3737
git diff <baseline>..HEAD -- src/ha_mcp/ --stat
3838
git diff <baseline>..HEAD -- src/ha_mcp/ --name-only
3939
```
@@ -112,7 +112,7 @@ For EACH agent, run all stories against the **baseline** version. One container
112112
### 1a. Start container with first story
113113
114114
```bash
115-
cd /home/julien/github/ha-mcp/worktree/uat-stories
115+
cd "$(dirname "$(git rev-parse --path-format=absolute --git-common-dir)")/worktree/uat-stories"
116116
uv run python tests/uat/stories/run_story.py \
117117
catalog/<first_story>.yaml \
118118
--agents <agent> --keep-container \
@@ -370,4 +370,4 @@ Flag >5% total size increase (directly impacts token cost per turn).
370370
- Reuse containers: first story starts it (`--keep-container`), rest use `--ha-url`
371371
- Custom story YAMLs go to `/tmp/` (ephemeral); full details reported in Step 6
372372
- See "Metrics" section in Step 4 for primary vs secondary metric classification
373-
- The working directory MUST be `/home/julien/github/ha-mcp/worktree/uat-stories` for `uv run`
373+
- The working directory MUST be the `worktree/uat-stories` worktree root (where `pyproject.toml` lives) for `uv run`

.claude/skills/bat-story-eval/references/evaluation-protocol.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ uv run python tests/uat/stories/scripts/ha_query.py \
3232
Check the exit code first. `ha_query.py` exits non-zero when the agent CLI
3333
itself failed, and prints `[exit N]` (plus stderr, when there is any) after
3434
whatever text the CLI managed to produce — `[exit 124]` for a query that hung
35-
past its timeout. The one non-zero exit without a marker is `Error: <agent>
35+
past its timeout. The one non-zero exit without a marker is `Error: {agent}
3636
CLI not found`, which means the agent is not installed: fix the environment
3737
rather than re-running. A failed query is **not a measurement**: do not score
3838
it as any of the three outcomes below — re-run it, and if it keeps failing,

0 commit comments

Comments
 (0)