Commit 910051f
fix: remove redundant asyncio.sleep calls in E2E helper tests (#470)
* fix: remove redundant asyncio.sleep calls in E2E helper tests
Remove three instances of `await asyncio.sleep(5)` that were immediately
followed by `wait_for_entity_registration()` calls. These sleeps were
completely redundant because:
1. wait_for_entity_registration() already polls with a 20-second timeout
2. The fixed 5-second sleep wastes time even when entities are ready
3. The sleeps don't improve reliability - polling handles timing naturally
This change saves ~15 seconds per test run and addresses part of issue #366
regarding flaky E2E tests and technical debt from fixed sleep patterns.
Also removes unused asyncio import and fixes a pre-existing f-string lint
warning (string without placeholders).
Relates to #366
* refactor: remove redundant comments per code review
Remove explanatory comments that duplicate what the self-documenting
function name `wait_for_entity_registration` already communicates.
Addresses Gemini Code Assist review feedback on PR #470.
---------
Co-authored-by: Claude <noreply@anthropic.com>1 parent 7f57e2c commit 910051f
1 file changed
Lines changed: 1 addition & 38 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
11 | 10 | | |
12 | 11 | | |
13 | 12 | | |
| |||
242 | 241 | | |
243 | 242 | | |
244 | 243 | | |
245 | | - | |
246 | | - | |
247 | | - | |
248 | | - | |
249 | | - | |
250 | | - | |
251 | | - | |
252 | | - | |
253 | | - | |
254 | | - | |
255 | 244 | | |
256 | | - | |
257 | | - | |
258 | 245 | | |
259 | 246 | | |
260 | 247 | | |
| |||
347 | 334 | | |
348 | 335 | | |
349 | 336 | | |
350 | | - | |
351 | | - | |
352 | | - | |
353 | | - | |
354 | | - | |
355 | | - | |
356 | | - | |
357 | | - | |
358 | | - | |
359 | | - | |
360 | 337 | | |
361 | | - | |
362 | | - | |
363 | 338 | | |
364 | 339 | | |
365 | 340 | | |
| |||
445 | 420 | | |
446 | 421 | | |
447 | 422 | | |
448 | | - | |
449 | | - | |
450 | | - | |
451 | | - | |
452 | | - | |
453 | | - | |
454 | | - | |
455 | | - | |
456 | | - | |
457 | | - | |
458 | 423 | | |
459 | | - | |
460 | | - | |
461 | 424 | | |
462 | 425 | | |
463 | 426 | | |
| |||
853 | 816 | | |
854 | 817 | | |
855 | 818 | | |
856 | | - | |
| 819 | + | |
857 | 820 | | |
858 | 821 | | |
859 | 822 | | |
| |||
0 commit comments