Skip to content

Commit b477695

Browse files
committed
fix(install): correct pre-download check and improve test coverage
1 parent ccf8582 commit b477695

2 files changed

Lines changed: 7 additions & 4 deletions

File tree

scripts/install-macos.sh

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -157,8 +157,11 @@ printf "\n"
157157
# Step 3: Pre-download dependencies
158158
printf "${YELLOW}Step 3: Pre-downloading ha-mcp...${NC}\n"
159159
printf " This speeds up Claude Desktop startup...\n"
160-
"$UVX_PATH" --refresh ha-mcp@latest --version > /dev/null 2>&1 || true
161-
printf "${GREEN} Dependencies cached${NC}\n"
160+
if "$UVX_PATH" --refresh ha-mcp@latest --version > /dev/null 2>&1; then
161+
printf "${GREEN} Dependencies cached${NC}\n"
162+
else
163+
printf "${YELLOW} Warning: Failed to pre-cache dependencies. Installation continues...${NC}\n"
164+
fi
162165
printf "\n"
163166

164167
# Success message

tests/src/unit/test_usage_logger.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -173,8 +173,8 @@ class TestUsageLoggerDefaults:
173173
def test_default_log_path(self):
174174
"""Test that default log path is in user home directory."""
175175
logger = UsageLogger()
176-
assert str(logger.log_file_path).startswith(str(Path.home()))
177-
assert ".ha-mcp" in str(logger.log_file_path)
176+
expected_path = Path.home() / ".ha-mcp" / "logs" / "mcp_usage.jsonl"
177+
assert logger.log_file_path == expected_path
178178
logger.shutdown()
179179

180180

0 commit comments

Comments
 (0)